From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22C02332EC5 for ; Mon, 15 Jun 2026 07:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781508142; cv=none; b=AgFzhwDG5TyX8eV7S3eyfY1J80JTBYOS2fiVdLhqlwqh4oT3gR/sFRDEyDPNliREQc8T3uMvbLtjBr3kh3w4+0cNI86+HzNt5ItFZOtUj7bTRUZZsbcOpG/WBPbVR6CUoEytcNYZsiy4LljT+R5Fs9wI0SSsdgzrPsSUZ0fh50M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781508142; c=relaxed/simple; bh=q/LjLwsNZeVWRdpomEsJmQRIeT+eVk51ndti/vp7ZJg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VrG/RlYx1/yuuOtiZWGvcULs5YxvE0cwkMoLIrPkluY3jp2SlP1y9wwh7zFrTt+sO2oGOISa7lZJJGyBIvrEQp1OPSwOHmvAX6/cWoXZxl55BiZLacW2ITPrRfRTGBKZRsBKw2vZffGcvyxQSpJNjRxa1IOTVMxxySPBfONEr/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LeirWdVV; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LeirWdVV" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-490c1915793so26123915e9.2 for ; Mon, 15 Jun 2026 00:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781508139; x=1782112939; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dccX/noafFTQkYLMmmr9krd/IkjkNKqkd36N21cGVWk=; b=LeirWdVVNUvD6YWneBMXzByvudmuZ3qN0MPK1EYp+tDeb0xjQN0uzdR/5NQAKOIo8G vF9Pu+AbPbnIPycnKYLPsXk5kVJkMR5CKkuf7vmnvPVjZCN+rDo5/PMQ1Kxp38hsVuWp i9zhoJZqHWjd5F/9Mp0IJNCGfL3SyhpL2twjTnjQ9u/Bw7eXovSBMnViTkLHBq9wCuas fdZ92ZYUsx583zX7WTTnF5Uoq58tHSrbpfQ2spG/qbiSKLBeLOCmU8hQp3gFRj6NJ0NV zivEx7yNzBusAdJ0Mq/K25lhmVprVXdfBW6xEYz2roQCtFrdpqZJrzYN6ggNoIOO4oT4 XSZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781508139; x=1782112939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dccX/noafFTQkYLMmmr9krd/IkjkNKqkd36N21cGVWk=; b=mAT+N7YoNiYDOqtXWGske+G8RDjHSKfVD/Gj4J2y690aIPfGkopRQhF4W2rgrGHOYY J780guaNy0fM8WjXbX3YanXqpeVuureMR7iJC4SR5ju5zOnV8YiFoILNd3eAU93vW4ya aKYtTsw0KmxzkITpJUNIambi2rpamdrZz0l6tUw4u56AOjgJPQtRFGZIXQ2+kgmpT3bG T0fwW7dFdeIEPCDmsuXrxQIkEeLsPlBf0oDV3yT10bUotDjbZG1Ka1HlmE8P2+1ALCY2 UfFvAkQoUpfCrdHsQQlKNlf7oS2EsPhletwIMllWVXCZpHIbAotgFwXe7Tg5nXI4sSPX ZJdA== X-Forwarded-Encrypted: i=1; AFNElJ8AAW0Lxc4abBj0C7+dHUhItfNjaBYVDLBFAsGm3G6ac40n4AAtGqrkWlFC5hO645WT9CZ5ziNYlA2Bc6M=@vger.kernel.org X-Gm-Message-State: AOJu0YwwlbY+kPOPE8hm0PIA4Xyl5NFphdtnY2TBYuwrKzqr7QBZgAFU YJ0+UYQe5ujapcxKgWjctFrns9EjXjLN/7U+f33jiKqWQeYVS8FUdexs X-Gm-Gg: Acq92OE8fZ9Z9lZDDvFnlFFM5wv1gm5q/1dQ5q4O/8mlTY/EffDEJ0Wuy1PR+BsoANC ZDIptM9BovDgVik+CJ7OLEYL4TWbgN1Qtiu0rDLo5UuQ7xUeFclRjAc+zzc88pBWryO+My+AxMY 12WB0nVBmigSMJLLRx/HcqjgWRLQhZb+fMBYEguyZtoDycpxjMi4V8FChNrGfntf334R22U9UNS aZAuPil6AdYov9WdlKr+7VKVP9HdYqOkBFBV8nS9U+OnL7LJN/lbPp9NXlf9F/vmfTJwAiUAhDp d0gg4t2B/2NUB/fSOTFcwtXsZO3DL+qKIp5K2GshPR6IPX0rW3T99+OXoUwZO5pME5RYWdNiQnB j5GIg5KTpaTxoIzx2LUHMCZpUm4Agih7QFGluITzzGKkqJzTrsOhYEPAuzRe3IkVp6bjE1VuVsU 4M/gYG5Be2qb7+yAvZpLHo3FtV1uaF7gqnszcfXzXoMq5+yxjZlBcEFI0LMu5ICxirL13psURtP aYU/Axhyll7rjcfxEEvs9FajNK0PZb2v7rHyjLD0vIx/eOBVEVru9aEaIzkS8udUbf2Z9hm7lYR cDRtkojEUXRUJVscvPqfmpn3/LOgtdkCsRgEZoJ31GxbdBIa8P/nqvf/yoIaCLT2ig== X-Received: by 2002:a05:600c:3556:b0:490:b92f:ef5b with SMTP id 5b1f17b1804b1-490ec4d4f30mr164914315e9.13.1781508139308; Mon, 15 Jun 2026 00:22:19 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490ea95c512sm180246365e9.2.2026.06.15.00.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 00:22:19 -0700 (PDT) Date: Mon, 15 Jun 2026 09:22:19 +0200 From: Joshua Crofts To: Kim Seer Paller Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , "Andy Shevchenko" , Michael Hennerich , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , , , , Subject: Re: [PATCH v2 1/4] iio: dac: ad3530r: Refactor setup to table-driven register bank approach Message-ID: <20260615092219.00007709@gmail.com> In-Reply-To: <20260615-iio-ad3532r-support-v2-1-84a0af8b83fa@analog.com> References: <20260615-iio-ad3532r-support-v2-0-84a0af8b83fa@analog.com> <20260615-iio-ad3532r-support-v2-1-84a0af8b83fa@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 15 Jun 2026 14:20:15 +0800 Kim Seer Paller wrote: > @@ -344,7 +387,14 @@ static const struct ad3530r_chip_info ad3530r_chip = { > .name = "ad3530r", > .channels = ad3530r_channels, > .num_channels = ARRAY_SIZE(ad3530r_channels), > - .sw_ldac_trig_reg = AD3530R_SW_LDAC_TRIG_A, > + .sw_ldac_trig_reg = ad3530r_trigger_sw_ldac_reg, > + .input_ch_reg = ad3530r_input_ch_reg, You're overwriting this field below. > + .interface_config_a = ad3530r_if_config, > + .output_control = ad3530r_out_ctrl, > + .reference_control = ad3530r_ref_ctrl, > + .op_mode = ad3530r_op_mode, > + .num_banks = ARRAY_SIZE(ad3530r_if_config), > + .num_op_mode_regs = ARRAY_SIZE(ad3530r_op_mode), > .input_ch_reg = ad3530r_input_ch_reg, Slight issue, this will cause an error if compiled with W=1, as you've already initialized this field earlier. Remove this line. -- Kind regards CJD