From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5823B30C143; Mon, 15 Jun 2026 12:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781527898; cv=none; b=Ga6cXz4nPnIzK2MDnWUkiQ81PKQ+JnTFNMsT5rL35FS+sjaAIj+CslkJ3Qb1NZU3cYxJrwgsAZzf2VKblh6FeMaTWGE/wWd3+cii9kfhOvbZ6x9VDgG/JciA5Hssv75I7Og9Rv/z23ZEklfVq937EP3hbe2I0QKB0Xz/THUUBww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781527898; c=relaxed/simple; bh=pYDSdXWHSIEwt9uHynbFQmsVT4AYiA6lTSQKn5Wpwn0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BbnD+6ONNmfVNTunrMIoCYDNfQ13dLlYM1iEkE8tCjwqns/6qwerOwul7zlwagdVb9fUr3HNSIlK9a0kI/LBiUWvqkbYT0MTkDSrJB995E77JolcQajGuaQQeMc7+yvkq6zoYQFo9Ii2NmmpTF82zbpBa0Mk/O8450dgXu/x16A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mr7KAvQC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mr7KAvQC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B4D21F000E9; Mon, 15 Jun 2026 12:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781527897; bh=i4K+f5gCCnhbLOrjygqtS/KpJ6yUBGuciB7yvW4kNZg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Mr7KAvQCBKRS5dSYPrzizqQcNlkc6Q3EvjhwTlakNWJ/SpyjnOPKSZia4v3IIRYTT ZpVtsRtk9sh2aGwCEQBaGQC3itvijg1E6I1mTVmSGZrKkISZZBuIOYDEz4Jyvq07BQ w81L2mnGq8+v+Ja8bl/hsoau24odQc2KMvf4Ho9EOIJrtZkQIEet127duOsDiklZoJ UObX9hhpfz1ImSXnyoz0IMBqTxJsNA7t+L8jpfLe01267kL7BfCQX8D4Ap8+R4pgBw GdNSJ6hy7/fViOSlIYFssaPqqqtf5ybe8SEanB9d57QoHg6hDLE8tTh7olCNNDVrVE p22Y4wlqVUtAg== Date: Mon, 15 Jun 2026 13:51:31 +0100 From: Simon Horman To: Haiyang Zhang Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Konstantin Taranov , Shradha Gupta , Erni Sri Satya Vennela , Dipayaan Roy , Aditya Garg , Breno Leitao , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, paulros@microsoft.com Subject: Re: [PATCH net-next v4] net: mana: Add Interrupt Moderation support Message-ID: <20260615125131.GL712698@horms.kernel.org> References: <20260613205812.2659945-1-haiyangz@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260613205812.2659945-1-haiyangz@linux.microsoft.com> On Sat, Jun 13, 2026 at 01:57:54PM -0700, Haiyang Zhang wrote: > From: Haiyang Zhang > > Add Static and Dynamic Interrupt Moderation (DIM) support for > Rx and Tx. > Update queue creation procedure with new data struct with the related > settings. > Add functions to collect stat for DIM, and workers to update DIM data > and settings. > Update ethtool handler to get/set the moderation settings from a user. > To avoid detach/re-attach ops, ring DIM doorbell to change settings > at run time. > By default, adaptive-rx/tx (DIM) are enabled if supported by HW. > > Signed-off-by: Haiyang Zhang > --- > v4: > Fixed tx stat, concurrency, and mb issues from Simon's review. ... Thanks for your comprehensive reply to the AI-generated review of v3 that I forwarded. And for fixing the issues present in v3. Reviewed-by: Simon Horman