The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: Dragos Tatulea <dtatulea@nvidia.com>,
	Donald Hunter <donald.hunter@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>, Jens Axboe <axboe@kernel.dk>,
	Yael Chemla <ychemla@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	io-uring@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] netdev: expose io_uring rx_page_order order via netlink
Date: Mon, 15 Jun 2026 13:00:56 -0700	[thread overview]
Message-ID: <20260615130056.028c5ed4@kernel.org> (raw)
In-Reply-To: <a773d177-82f3-4046-866d-852d0d83e08b@gmail.com>

On Mon, 15 Jun 2026 12:16:47 +0100 Pavel Begunkov wrote:
> On 6/14/26 01:02, Jakub Kicinski wrote:
> > On Sat, 13 Jun 2026 16:09:03 +0200 Dragos Tatulea wrote:  
> >> In io_pp_nl_fill() or in page_pool_nl_fill() as it was done in v1 for order?  
> > 
> > It's fine. We decided to make the "page size" a memory provider
> > property, now we're going back to making it a queue level param?
> > Like my RFC had that everyone hated so much? Sigh.  
> 
> TBH, I never cared much how nl would show it, so not opposing either
> version. My idea is that even without plumbing in per-queue non-mp size
> configuration, it'd be nice to have a common way to check it b/w
> providers.
> 
>  From the semantics and observability perspective, zcrx is probably not
> that interesting as the parameter is basically just a hint with no affect
> on uapi, and I'd assume people would rather see the page pool size or even
> the NIC's page size. But I guess it depends on what Dragos is really after
> with this patch.

Not sure what Dragos's use case is but IMO it's useful as system admin
/ vendor to be able to peek at the important params when user reports
bad perf. The netlink MP info is meant for system observability.

  reply	other threads:[~2026-06-15 20:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 21:17 [PATCH net-next v2 0/2] netdev: expose page pool order via netlink Dragos Tatulea
2026-06-12 21:17 ` [PATCH net-next v2 1/2] netdev: expose io_uring rx_page_order " Dragos Tatulea
2026-06-13  9:53   ` Pavel Begunkov
2026-06-13 14:09     ` Dragos Tatulea
2026-06-14  0:02       ` Jakub Kicinski
2026-06-15 11:16         ` Pavel Begunkov
2026-06-15 20:00           ` Jakub Kicinski [this message]
2026-06-15 10:53       ` Pavel Begunkov
2026-06-12 21:17 ` [PATCH net-next v2 2/2] io_uring/zcrx: selftests: verify rx_buf_len for large chunks Dragos Tatulea
2026-06-15 20:30 ` [PATCH net-next v2 0/2] netdev: expose page pool order via netlink patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260615130056.028c5ed4@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=dtatulea@nvidia.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tariqt@nvidia.com \
    --cc=ychemla@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox