From: SeongJae Park <sj@kernel.org>
To: Philippe Laferriere <plafer@proton.me>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon/stat: use secs_to_jiffies() instead of msecs_to_jiffies()
Date: Mon, 15 Jun 2026 18:04:18 -0700 [thread overview]
Message-ID: <20260616010419.142184-1-sj@kernel.org> (raw)
In-Reply-To: <20260615214113.122923-1-plafer@proton.me>
On Mon, 15 Jun 2026 21:41:43 +0000 Philippe Laferriere <plafer@proton.me> wrote:
> The conversion of a duration expressed in seconds reads as
> msecs_to_jiffies(5 * MSEC_PER_SEC), which obscures the intent and
> needlessly goes through milliseconds. Use the dedicated
> secs_to_jiffies() helper, which expresses the 5-second refresh
> interval directly. No functional change.
Thank you for this patch!
>
> Found using Coccinelle (scripts/coccinelle/misc/secs_to_jiffies.cocci).
>
> Signed-off-by: Philippe Laferriere <plafer@proton.me>
Reviewed-by: SeongJae Park <sj@kernel.org>
I applied this patch to damon/next [1] tree. We are now in the merge window.
We (mm community) want to focus on making the stabilized mm changes be merged
into the mainline until the merge window is closed, rather than adding more
changes that are not really urgent. I understand this patch is not really
urgent. Hence, Andrew might not add this patch until next -rc1 release. In
the case, I will request adding this to mm.git after next -rc1 release. So, no
action from your side is needed for now. Let me know if you think this is
really urgent.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-06-16 1:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 21:41 [PATCH] mm/damon/stat: use secs_to_jiffies() instead of msecs_to_jiffies() Philippe Laferriere
2026-06-16 1:04 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616010419.142184-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=plafer@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox