From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 881EB1D5CC6 for ; Tue, 16 Jun 2026 03:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781579328; cv=none; b=qkomXn9Fvp+O5mtCxKgwD7uJvi3mwm4wy0WrQfQC7JmmQzXv9HtT/lISI6wunGgEPJBWDwXaR8aRZ58iT65jbvyuzxLBD/ueEHFTb+ZW6856lkb9/Iur68mNGpET19WJzO97Z2cW8rtk+NPxPPMx/7PuYaWbV3fDWCBmioidGuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781579328; c=relaxed/simple; bh=HCQ6qtKhF9EMVm1CRWI7J25L2G3MnCmQf+c04h6eW/M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nJ1Xs8bLNNuJwvyNjshI8mg39aielStQqe8Yu6XtcrHGxycanUcTNML79GAHaGBmw8kVo8uyJtQXlNm2gTso91WMrhNvh9P+CK56upnbkiQ6fKN9HgapLjmLw/p3zzri06H9tKBj/y5DB5IRWLoc1s3yXk+EBvgBeZgvQ6NqVEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eOLmhALu; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eOLmhALu" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-36ba285e98bso4029931a91.2 for ; Mon, 15 Jun 2026 20:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781579326; x=1782184126; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KlE0MRVFcLUCpfu4xttIQYVS/IifqiP8sdgnIGomkDo=; b=eOLmhALuT5T0iquZmdnbNG/6IXhDz2ji+GnrfhxYYXEtZmmSiOuGS/Knf97VPN9s1s BXxighdfg/Z0BDsYZSQgk5BmZNuUVSDdX+ORDarkq1eSh9WHF96mCXICz74ybnun+3I3 IrHfNEwCmiwCoVCU67f6bzZenovb1lHzrnmNOoDSP0Lba0z4mMPJ5jTc74X2vG4WIHx2 g4PjOwnmvkb5CM2SWdqtwPLuKcaC1DWMxGVE5IkxQoSCnvpSys+iRW1rN+x3jxjQFSXL 42+pD62V8Cz/9tWH4jQC/zatrFdN57lhfyxNfNBMafpuSVYZFv5AYdD4PVOne0LV+o+a c/lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781579326; x=1782184126; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KlE0MRVFcLUCpfu4xttIQYVS/IifqiP8sdgnIGomkDo=; b=YMWXfz23HvkN83oVRH4LLDkmdx4ImyFg5qXR84WPxUvFJOTX5TqEvA4kYUjTo9lICa ZEc72Dq4S/hYYvpCRb4u89F0o10DFKKPeBiyTKV0Lnma1ExlIsFrbaoM7FQPT4aEOsjE DN1vs1rJ8B30AtxXYXYx6rm7BCf8elDxC+sQZmo1Vd4+Mn0CUZVnU1S6AdaEVYBMDiQi Zef3oBWfONevDNGxPId7XO4Hs7PAyUupDLYHHGf8nNfopser8c51HQS0FVJkjqoKWx/B 1qH9fRG7+FH52cBnSYQB0+gL4+AHwwj2lcKyZ7UpkcNzYUU/g4/+/KPcOZaItb7Fx4on jugg== X-Forwarded-Encrypted: i=1; AFNElJ8xQJyLQmBAPfFunz/09PjCTc5lBy2nAS4CQ9/+zXHhRIf45Zsk9PpRFCt8aV2QDCBA8QWLiwbW8WQzfPQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8g/lmWT+67Mak12d1ka29c4GlFDficE1UvI9TEz6dYCjY4UAb ksy+B6+wyiQR+AAkOtk1yApVmN0lEYKvZHJQXs/uHqbO2ckZXK7UrZxkcDOdlg== X-Gm-Gg: Acq92OFYkSKA2cwQmJugMgKzEcwiYuRVh0aeQSsVrPLiWmFPBvIsh4H6c4fN/8oajL0 vYkEonpujQEFqiLBhyLOT5J/UOgZev3hrov3kZ7lPkpm45lns1G/nsLg5OIQKOUaazvIFf1xB8q YmlRnIw0mUu67Yeop2ytFjicWhuRp0AS88FSeI4GRLqmGTzR7FoSx1DKHv5SJjT2U+CUHtTNBEn IDWdUPvGTwtFAUa+Zmn1Q16jK12/aSrvPL2trKNc9XFWNIIq3HCHkqeHZpPnFVWLLNnGmRf2gLg puo2fzMR6tIPZoWoOj1OCcVZNdE/4p/jTaCrU94Z0YInItIi72UB1mXzg7uFF9/yBzdQmwmbiel aYRyeC1ak0kZEH2CiKEL9IpNpdJ4xK0cxiJOzYZYTjADBZ8D5AYPi/oUg8SPIOeK9fYIE+43oZ/ ZxVKXgzn/ZhyQEpcsEme9T9sSTJ+eXDjesGrv0WMjNDROBUSvlCSBerQgM6QpenKtvQJ1NqDDdn j8198t+EBj4y6R6f3rOb40soZRUGRY8QT0= X-Received: by 2002:a17:90b:3c03:b0:36d:b12f:613c with SMTP id 98e67ed59e1d1-37a0202ecdbmr18758831a91.10.1781579325886; Mon, 15 Jun 2026 20:08:45 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:33c4:7c66:bf93:6ee2]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37c521ae039sm1054607a91.1.2026.06.15.20.08.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 20:08:45 -0700 (PDT) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , linux-kernel@vger.kernel.org (open list) Subject: [PATCH ath-next] wifi: ath9k: drop static from local pdadc and vpdTable arrays Date: Mon, 15 Jun 2026 20:08:28 -0700 Message-ID: <20260616030828.655310-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the static qualifier from mutable local arrays in three EEPROM power-calibration functions. These arrays are written to during normal operation, so static storage is both unnecessary and misleading: it implies sharing across calls when no such sharing is intended, and it makes the code subtly non-reentrant. The sibling function in eeprom_9287.c already uses an automatic (stack-local) pdadcValues, confirming this is the correct pattern. This keeps ~1 KB of data off the static data section at the cost of stack usage, consistent with the rest of the driver's coding style. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/net/wireless/ath/ath9k/eeprom.c | 6 +++--- drivers/net/wireless/ath/ath9k/eeprom_4k.c | 2 +- drivers/net/wireless/ath/ath9k/eeprom_def.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c index df58dc02e104..fe5eb0d68b2e 100644 --- a/drivers/net/wireless/ath/ath9k/eeprom.c +++ b/drivers/net/wireless/ath/ath9k/eeprom.c @@ -460,11 +460,11 @@ void ath9k_hw_get_gain_boundaries_pdadcs(struct ath_hw *ah, int i, j, k; int16_t ss; u16 idxL = 0, idxR = 0, numPiers; - static u8 vpdTableL[AR5416_NUM_PD_GAINS] + u8 vpdTableL[AR5416_NUM_PD_GAINS] [AR5416_MAX_PWR_RANGE_IN_HALF_DB]; - static u8 vpdTableR[AR5416_NUM_PD_GAINS] + u8 vpdTableR[AR5416_NUM_PD_GAINS] [AR5416_MAX_PWR_RANGE_IN_HALF_DB]; - static u8 vpdTableI[AR5416_NUM_PD_GAINS] + u8 vpdTableI[AR5416_NUM_PD_GAINS] [AR5416_MAX_PWR_RANGE_IN_HALF_DB]; u8 *pVpdL, *pVpdR, *pPwrL, *pPwrR; diff --git a/drivers/net/wireless/ath/ath9k/eeprom_4k.c b/drivers/net/wireless/ath/ath9k/eeprom_4k.c index 3e16cfe059f3..eec7efdc21c3 100644 --- a/drivers/net/wireless/ath/ath9k/eeprom_4k.c +++ b/drivers/net/wireless/ath/ath9k/eeprom_4k.c @@ -288,7 +288,7 @@ static void ath9k_hw_set_4k_power_cal_table(struct ath_hw *ah, struct cal_data_per_freq_4k *pRawDataset; u8 *pCalBChans = NULL; u16 pdGainOverlap_t2; - static u8 pdadcValues[AR5416_NUM_PDADC_VALUES]; + u8 pdadcValues[AR5416_NUM_PDADC_VALUES]; u16 gainBoundaries[AR5416_PD_GAINS_IN_MASK]; u16 numPiers, i, j; u16 numXpdGain, xpdMask; diff --git a/drivers/net/wireless/ath/ath9k/eeprom_def.c b/drivers/net/wireless/ath/ath9k/eeprom_def.c index 5ba467cb7425..a1b10c826fe5 100644 --- a/drivers/net/wireless/ath/ath9k/eeprom_def.c +++ b/drivers/net/wireless/ath/ath9k/eeprom_def.c @@ -769,7 +769,7 @@ static void ath9k_hw_set_def_power_cal_table(struct ath_hw *ah, struct cal_data_per_freq *pRawDataset; u8 *pCalBChans = NULL; u16 pdGainOverlap_t2; - static u8 pdadcValues[AR5416_NUM_PDADC_VALUES]; + u8 pdadcValues[AR5416_NUM_PDADC_VALUES]; u16 gainBoundaries[AR5416_PD_GAINS_IN_MASK]; u16 numPiers, i, j; int16_t diff = 0; -- 2.54.0