From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E68F3348C7C for ; Tue, 16 Jun 2026 09:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781602408; cv=none; b=aCX58Q8JnJauQdXwk2omptkP7aMJNgmtyISIZ1nAL0pW6R6S8/0Ya3pWuVkUWAMBgGohGSiDugdz7GTCDD/oSyb3kQ/P2vZsp6fQLW1tkJlLcviu7jgIxSTYkBMa+UizmA1ZkQhBScbauWaXNDlxG2ej8Lh7wMxPDdIeG3wr+aE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781602408; c=relaxed/simple; bh=zcSczsjl+oUTupPg0K9goQ+v/ljMWZqjCyJlP2xDGRw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KJltJVOjOoEvi9m9Kb12gwuTKS6z+Ft67Bv6DTdM6p5FbK3fWXmN0IEf+296D0iyEdWvUKq5ipscXNsr1boZ5pykvFsN1bhnRTjuKYDh7mnH+JG3yybjXF6YzwnoiK1eexCRqCZ5SLwCu/q4Yv3fI7kLp1Djp3KHisDHOdAWWGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E5FQ/phW; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E5FQ/phW" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-46013161068so2153193f8f.2 for ; Tue, 16 Jun 2026 02:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781602405; x=1782207205; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vwhTbpSf3S7rURBKa5GxlH2Q5fxRXSJEjfD06CTwETQ=; b=E5FQ/phWhY5vmLKA6S4Qj945+TwjCqMTeU7AHc5bI6EGUS1ss1ixzB3XLt0r0tvYEQ WgZOWMn16j0PXgtK0UdF6h9/WM6cVk5Bk/ZVQBK2KsvlVFupdAfnyji4+qokW5W+G1T7 AxMfcyXqYVPzac+YsnbMljhIa7l9dPzadgn5e7wzG6gy5JJC08UXRf9clfbKMSAhVBk1 TSkOQyHMC+S8rfHxYh13+Tg8cW7g+pwt8roiU0IASTiFi689DjGCx9hC7zDviZuTpSM5 hqGlJqf8PDVGmTtXWI4M/FOP4AErkjiISY+CTCHWs5abkLJeZ0VRFDkXAgwdu+7eLmRo BUiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781602405; x=1782207205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vwhTbpSf3S7rURBKa5GxlH2Q5fxRXSJEjfD06CTwETQ=; b=jomJhrQhCnKpmaM/BN2nkknjTIaT/v5BDomZl7Ym4eIfM6kBG5TxkqojVB+0iAs+RA mpB+D8bi5z4CgzRs3lpUrfCUapzpRVsNf4+shS+6fPwswQ+6e17904cqvdPyUcmiIxvo aoR4dG/9NzVsU1w6Kxt/RwmOc88//D08q3exs7LAhtpJW9aF/xqkCgfW13oMYDbi++HU Vt6XIuZuOaVXw/sY27Bv2w8D5j6HCP4BUg8CbbOAxBS/sgeekfT/WgCJNt3EMsAZGlAj T88nMXUUVjVgrFiE6fRtzKZVeCMyDXDbjcnFH/Lkx6nsRn4qsLd/hRdHRmVVif2jWn8U HJ8w== X-Forwarded-Encrypted: i=1; AFNElJ9V9sCrEtf9ntRuVLAxiCmUvwODQVGVjhla7ppxJfbXdMcrIjXe9Mz+HHI9snd/bca+tHjn7so+xNCfUWk=@vger.kernel.org X-Gm-Message-State: AOJu0YxanpfOF+1Exig7NCww42GKnk5WYGD8XKdqy+Tu97Eo9k7gZpqf k9m9Km0y3VhqpZY5TiyPs+pKSdJ0+OjbCWcorM5kmL/HCgAOTIkJ1w4w X-Gm-Gg: Acq92OG6UxZzU/IDVXGHTrA3vyqWlIxUVjrQVVxlsrwgyWpVSfPOWGxlOegj9U3Z0Et wzuijW4q4FSgwkVGEzEXCTQ/Vf/zY3Shie/zvApIQTYAP+fzpo+Dvv1VEIEfy3VQcsAyHCw2GTT 02N3ArM2NRQ0DYglLCmUsb/d0rArofPmT3o3Kda+K23/S9E5fxgqu+mIH3rl07XiHIDy+4k66f+ fPZzQQGSFOBwvO9ffqTeJ4O4ueOpkapw7i1x228eD/MZV96duenzcfKKyivCyDVZfFEzGcoSSFH X+ndPM3EP9s9wGd6DQtsM4uXakVVj6x0t/9i2DnSU9WqlhcDrgzsi7Gw6KW4ReTeOKO/rufyfGE H8ccwVyOqqxpobRsU1lY1ZAsRO5UCxugDNXVuVMmIXN8crALY2JbiSSKcwVL3g6MCsUWtIj/hWw raWYc54uZT5awZQs1v79dRYsRxN6xYfKyXMoeOBQbPb3q2vdBILRqe+PkboG4e0skjHaoklW2KH YtP6NnQqvqo32LsbBTbDijWEVtSGX8vmKtq4dZhpWnRwdsjpT9UnAbaB8IW6XMDixV3zArp4CbV +/+EKcS/Cf+KTuXd5bfuB0J06vurHsZew9MtnZ9xg9WMoe1idNuc3+rdRWkwM5OdQA== X-Received: by 2002:a05:6000:136e:b0:45a:e3dd:5865 with SMTP id ffacd0b85a97d-4619f3871d5mr4200728f8f.13.1781602405394; Tue, 16 Jun 2026 02:33:25 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2d9becsm40724271f8f.34.2026.06.16.02.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 02:33:25 -0700 (PDT) Date: Tue, 16 Jun 2026 11:33:22 +0200 From: Joshua Crofts To: Rodrigo Alencar via B4 Relay Cc: rodrigo.alencar@analog.com, Michael Auchter , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kees Cook , "Gustavo A. R. Silva" Subject: Re: [PATCH v3 05/12] iio: dac: ad5686: add support for missing power supplies Message-ID: <20260616113322.00005273@gmail.com> In-Reply-To: <20260616-ad5686-new-features-v3-5-f829fb7e9262@analog.com> References: <20260616-ad5686-new-features-v3-0-f829fb7e9262@analog.com> <20260616-ad5686-new-features-v3-5-f829fb7e9262@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 16 Jun 2026 09:21:11 +0100 Rodrigo Alencar via B4 Relay wrote: > st->use_internal_vref = ret == -ENODEV; > st->vref_mv = st->use_internal_vref ? st->chip_info->int_vref_mv : ret / 1000; I'd use a macro from instead of just doing / 1000. > + if (!st->vref_mv) > + return dev_err_probe(dev, -EINVAL, > + "invalid or not provided vref voltage\n"); > + > + fsleep(5); /* power-up time */ I'd recommend using a macro to define the sleep time, removing the need for a comment. > /* Initialize masks to all ones */ > st->pwr_down_mask = ~0; > Otherwise LGTM! -- Kind regards CJD