From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1BC8428462 for ; Tue, 16 Jun 2026 11:38:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781609888; cv=none; b=WcgDWSHwtTCy1lXEsSx6cXRNAMnmTTFG/BwLQhh41HRcATWV326LQUrtjglAfC7Apt+8yVbRWVxZSvl9StFHnKeSDBXWCNE7Z5eMpRkh7uqBS4wqh9mTBOMxP9nNg0y2A5BofwICVXWEAjL7kGfnhVZql/ekOm6dg5QrB6cToB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781609888; c=relaxed/simple; bh=vzjCOULK10zhhW9cPNbW0uto8mZkx13NVRPck38PmTo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fh+/RT1i8Af6SPW1T9suU2jT3zoK4zN6hltrITM6W91ULJzhWRdz+sCm9pkUm/BcvfPkuW9adp1xF647EZNrdHa0ZeWtttFX+MOr2nAR/cwIXvZUkmHAbITkySDVt0PAJ2vn3a7elgSyqobJgyfJy3NokWINQIYIBUMVNV/jibc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gk91Bbd6; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gk91Bbd6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781609887; x=1813145887; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vzjCOULK10zhhW9cPNbW0uto8mZkx13NVRPck38PmTo=; b=gk91Bbd64qiWDs9gv+YwWPFjHgRUEHFgBhG0+Y8VF637VpwP3dOVvRNe KyOQDRw9RrHvyjtyYSi+rNT828tuToaTDxyhm3rld/ET2TZR4gPKY3s+o hWpi9HOTDcOHKa6ACGUBFduJFaWMZAjsMys71TN8qqWzfE1it0s1TQNxG sSXkXcl+/0WEISgXqSNVRT9ON0IZgznRafBm/XSCZDEBwOMOxYgHuJJlh nyiBXw1i5mM3kkBr7eWT4kXM1F18PSyCJIcaN2XJlESk8nedDlN6vtr41 DlbFksGpL+j0/6AuqKJdCLAUSNzY5CPhz08kxaP2Vud67YGI4qsNidMOO g==; X-CSE-ConnectionGUID: 4974IFoDS7GX6sczqePkfw== X-CSE-MsgGUID: L/kOdwbAR9Gu0u3d7itzzg== X-IronPort-AV: E=McAfee;i="6800,10657,11818"; a="82383815" X-IronPort-AV: E=Sophos;i="6.24,208,1774335600"; d="scan'208";a="82383815" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2026 04:38:07 -0700 X-CSE-ConnectionGUID: vJS4FGKfTyeuoR/cIpnrOw== X-CSE-MsgGUID: tHklzjwjTnmGHYpBkedKhw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,208,1774335600"; d="scan'208";a="251666733" Received: from abityuts-desk.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.244.134]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2026 04:38:05 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, Adrian Ng Ho Yin , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] i3c: master: Add missing runtime PM get in dev_nack_retry_count_store() Date: Tue, 16 Jun 2026 14:37:51 +0300 Message-ID: <20260616113752.196140-3-adrian.hunter@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260616113752.196140-1-adrian.hunter@intel.com> References: <20260616113752.196140-1-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit Ensure the device is runtime resumed while updating the retry configuration to avoid accessing the controller while suspended. Call i3c_master_rpm_get() before accessing the controller in dev_nack_retry_count_store() and release it with i3c_master_rpm_put() afterwards. Fixes: 990c149c61ee4 ("i3c: master: Introduce optional Runtime PM support") Signed-off-by: Adrian Hunter --- drivers/i3c/master.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 66cf5d3bd987..903ac01ab413 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -767,12 +767,18 @@ static ssize_t dev_nack_retry_count_store(struct device *dev, if (ret) return ret; + ret = i3c_master_rpm_get(master); + if (ret) + return ret; + i3c_bus_maintenance_lock(i3cbus); ret = master->ops->set_dev_nack_retry(master, val); if (!ret) master->dev_nack_retry_count = val; i3c_bus_maintenance_unlock(i3cbus); + i3c_master_rpm_put(master); + return ret ?: count; } -- 2.51.0