From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1868142B75E for ; Tue, 16 Jun 2026 11:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781609890; cv=none; b=kAFUJrkC9K33/IT1ULIzEncwDV+rPrjVJz6E6FgFI1Sao2xYn88qw+tLOCpHNVxKG5KfIqa2eWRtOfI5u3Ouzltbiee51ZlplYXa8alCTfcWeqNVmmiYguSZJsoPnrEFcL0KZtzYO20F3AwKymc7NMswI2iTU2RqqCBi3wZqPrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781609890; c=relaxed/simple; bh=jQv/ThlKjqGZZhnQNN9SDpBuZM0obGbAGQDEWX6hUJ0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fl7JHVgoMkQLUs+Kb6bfiRsxoDmNAEF86mRrZs31ACrYkS+8XY0+vdkFgmZ0p8CvTSXAl59HkII29WZCLSUDFUjzrntuLva4nhn7WxqAr/6t3bDb0adbuGUwbKXoxm1AzBVHv9qfB1kQobgyYT5ZMz7f3O98YWf4BZSOcKWxfJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BXXooh7K; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BXXooh7K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781609889; x=1813145889; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jQv/ThlKjqGZZhnQNN9SDpBuZM0obGbAGQDEWX6hUJ0=; b=BXXooh7KEeLDJ0cdnyOfCF6F/MzKupETiJaYqmbd5O9vZRncy+VXtN76 52KzFAMR1VBHvLzEDWJRCWQdLxBYBQpi3CLfhBfvfWvZ6+pMXmHBNvbR/ qwcg3rJtganfzk4mgNs1fjNZfwmlwsqBefQ/NCZctXT45IYAKFuhFZQGy c6v9f7ogzJ/UB6rBbxNGHTYTxkE51A+1O9hOs6P1s44qRLLplc6PWOw1U /DlRvNeIU1mGFhEgVqbmkVMdUwaVqoCJiRdMOnqYZUgQIBL3pJ+UKECYT kyLE7w3gohUMvifUTccumbtAT8U4fcj1hQkj/+dPkWQxSiOpn7RFcZSLl g==; X-CSE-ConnectionGUID: Pl2mlWItSY2EwLYmx9kszQ== X-CSE-MsgGUID: saOL6RCyTnm8lxV61jqZhA== X-IronPort-AV: E=McAfee;i="6800,10657,11818"; a="82383820" X-IronPort-AV: E=Sophos;i="6.24,208,1774335600"; d="scan'208";a="82383820" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2026 04:38:09 -0700 X-CSE-ConnectionGUID: BMgErz81S3mEkAfFAet+Fg== X-CSE-MsgGUID: pFQx3lOURqeqv+a+yKiAjQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,208,1774335600"; d="scan'208";a="251666738" Received: from abityuts-desk.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.244.134]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2026 04:38:07 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, Adrian Ng Ho Yin , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] i3c: master: Use unsigned int for dev_nack_retry_count consistently Date: Tue, 16 Jun 2026 14:37:52 +0300 Message-ID: <20260616113752.196140-4-adrian.hunter@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260616113752.196140-1-adrian.hunter@intel.com> References: <20260616113752.196140-1-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit Use unsigned int for dev_nack_retry_count across the core and controller drivers to match the type of master->dev_nack_retry_count. Update the sysfs store path to use kstrtouint() and adjust the ->set_dev_nack_retry() callback prototype and callers accordingly. Signed-off-by: Adrian Hunter --- drivers/i3c/master.c | 4 ++-- drivers/i3c/master/dw-i3c-master.c | 4 ++-- include/linux/i3c/master.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 903ac01ab413..58d20624ed05 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -760,10 +760,10 @@ static ssize_t dev_nack_retry_count_store(struct device *dev, { struct i3c_bus *i3cbus = dev_to_i3cbus(dev); struct i3c_master_controller *master = dev_to_i3cmaster(dev); - unsigned long val; + unsigned int val; int ret; - ret = kstrtoul(buf, 0, &val); + ret = kstrtouint(buf, 0, &val); if (ret) return ret; diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index c7030d0cd8a6..e4f6d6f29ed5 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1481,7 +1481,7 @@ static irqreturn_t dw_i3c_master_irq_handler(int irq, void *dev_id) } static int dw_i3c_master_set_dev_nack_retry(struct i3c_master_controller *m, - unsigned long dev_nack_retry_cnt) + unsigned int dev_nack_retry_cnt) { struct dw_i3c_master *master = to_dw_i3c_master(m); u32 reg; @@ -1489,7 +1489,7 @@ static int dw_i3c_master_set_dev_nack_retry(struct i3c_master_controller *m, if (dev_nack_retry_cnt > DW_I3C_DEV_NACK_RETRY_CNT_MAX) { dev_err(&master->base.dev, - "Value %ld exceeds maximum %d\n", + "Value %u exceeds maximum %d\n", dev_nack_retry_cnt, DW_I3C_DEV_NACK_RETRY_CNT_MAX); return -ERANGE; } diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h index f73cede87d36..6f0379bdbb6d 100644 --- a/include/linux/i3c/master.h +++ b/include/linux/i3c/master.h @@ -494,7 +494,7 @@ struct i3c_master_controller_ops { int (*disable_hotjoin)(struct i3c_master_controller *master); int (*set_speed)(struct i3c_master_controller *master, enum i3c_open_drain_speed speed); int (*set_dev_nack_retry)(struct i3c_master_controller *master, - unsigned long dev_nack_retry_cnt); + unsigned int dev_nack_retry_cnt); }; /** -- 2.51.0