From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1894F47AF43; Tue, 16 Jun 2026 18:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781634360; cv=none; b=pfGVpGMdZWvt2YZ8yqD5WLzd+45AQDZ71itYY8JZuUVDIC1IfRQfq5xFhdsu5EMM+FuN3ImH7V+K1Bd1zhpsWWCI4CHTanJRsK7ej4F06QpTuCt+8tKv55b60MayIrzndCGAm5NlLJPudHXBTiFD5xomSz/88Nc7se0QBf92zqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781634360; c=relaxed/simple; bh=T/Mu13zdV4DjS2WdIhdeC9UY++R8kmGc0o41kLv5qME=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tw5JW+mhyHZ1J59OLIyWs/CWhY2wk43NubiyPGYTX6rFkvh7pIC4AZJ09qfxMKWR6u/r7tSAhl4S1ZZGN8dIH8fGByXAPa8b+kv6oMrhoTxon9hu+/1xTZEkh6l5S4XRZguCxTClOSEkKPYnlVsfyShawqGigR2LG27DqDhf868= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nhJ6ULYc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nhJ6ULYc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 021D31F000E9; Tue, 16 Jun 2026 18:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781634358; bh=ja6HFfIID+G9AN89mM0NtD+HNlbq940B7f7OpakyXKA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nhJ6ULYcztHpngFj/KsIfKBRueEr8tcv0ODR6rdK4RzaTxHUdguCZkRgwzU75Y6Xy P0gSYm165X3pRViUk07SZZQkEuqgLZoDq+7Z9zLiRN4bvk4y11nC6pVJTR7B+3fmgp OUX6sItXR0izNMH3m8Zb9nhxW+4u1MNsW60cdN/yO2lU1F3uD1kPz1Ysfip3i44ba1 3P25ZhKdTPfgkjNKFEE24A1lNos0SiDOMw6nOYQhrL6uDprwUud57CqIM3ldEOihyk 10qoeVcULrHaMfxZf9H5WJKXBK5P4e7GP4H1Zn2Xhc4OLJu30Q9fAWny40pJx0iZq2 Do7GyVHNcw5Fw== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Aaron Tomlin , Claude Subject: [PATCH 2/2] perf trace: Guard __probe_ip suppression with evsel__is_probe() Date: Tue, 16 Jun 2026 15:25:46 -0300 Message-ID: <20260616182546.8892-3-acme@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616182546.8892-1-acme@kernel.org> References: <20260616182546.8892-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo trace__fprintf_tp_fields() compares every field name against "__probe_ip" for all tracepoint events, but this field is only implicitly added by the Ftrace subsystem to bare dynamic probes. Add an evsel__is_probe() check before the strcmp so the string comparison is skipped entirely for non-probe events. Reviewed-by: Aaron Tomlin Assisted-by: Claude Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index a8492da23a9cc178..57f3f14c5d435805 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -3267,7 +3267,7 @@ static size_t trace__fprintf_tp_fields(struct trace *trace, struct perf_sample * * If verbose mode is enabled, ensure it is formatted as a * hexadecimal memory address rather than a signed integer. */ - if (!strcmp(field->name, "__probe_ip")) { + if (evsel__is_probe(evsel) && !strcmp(field->name, "__probe_ip")) { if (!verbose) continue; -- 2.54.0