From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA2348BD4E for ; Tue, 16 Jun 2026 23:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781653982; cv=none; b=WdLXIBFcbT9HU9VW3S3HrgMgvyyB5neTSrlNXvVdVfagKDrIhR1icumCxOhMS2N8/XwPwoJchDszaKVtNMczEvQior5cFC7nsvAuoctVpG30/CHaRXNlhGzzWsQ8kY/hg8u3pCi9B43ky62C95T7w1oR+GcGHU2RGx/8Mi2jsVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781653982; c=relaxed/simple; bh=+2ZAsq+xEDTtQWxNiEgUsg8vHStQmbMMnyhTm0Hh1R8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=s3I4WVpUCdDNt572iKER+p9v4RbdLB4Nh0PreKJ6bUUIJxX8cZYV+zdxTpopX9ouLBhmMCcMRRLii0WUi7kqvokJ6v6V9sRQBfSXLgWgofmTHuDCT8Tg3Cs1A3JT68W2TSNl0kUNNc+XNeZFDzVc9CFi+VJJRqtgXsry0tUGMr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kRjoxY5k; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kRjoxY5k" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-13721dfd471so5715961c88.1 for ; Tue, 16 Jun 2026 16:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781653981; x=1782258781; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3aMuC1VCOyhVkCqSO+h6+ZxFuqfGmZeukjOGA+GlgDo=; b=kRjoxY5knFBKuOuTfrKPApwmRD6e8a0X7R8BCbTd2puL+RI2Vokd4rGbafMCz28lKh pCINycVphGDVmbxm2/h7Y4f5QtNnGss6ZqUs0NlAVnwaoKABlUWU5kfUAQpRarsiRGOV uD+FA2rWzyECj3EzD8NtmVAKtL0O2lVKcwhoXtyHpdl/5h6MpuXOfAnfIT0A0VMsTjMP pMmR7uBsrEoP1yuXcoKCSYJ3YQL7jI8Dqo2OQkvteBqvjFqn68Q2tjpAdrz5fPwg8qt6 BvgkJ5AdaJzU3B8xWZTbamBzV2B7hjyLS4XTchlDVBsy2dy4BxtDFpfSk2qtrNy/Y+N/ 546Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781653981; x=1782258781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3aMuC1VCOyhVkCqSO+h6+ZxFuqfGmZeukjOGA+GlgDo=; b=bdEW5TtnRCgKIXwC3G3/qi9TrRjPT5Ej9MhUGXX2YF3P/dEqSzG+x2nTco+0bIRYwy /10gG3VJroLu3GOwQWV00No37r/+B4UT6P2DKXWyfw2TxSg+6jPHwr362d5aX25Glg5t T+w0Mf7r6JfUai3Ui3GRdRlMVfkcsS0o6/hvPAl7X0Sy9+1M2DXSC7DeDzIQ8FxR4YrT fLUqtSdcOaKIk+Y8pecoigOn/atn0PHM0+sbvFZfH+TePSvReJBD/WZ3p05X1mpdsF2x N1PS7wz4BTaG4yEkoLXiT68jnzDxvi0M3EgvDNRrc5aHioTcFiEjwE+/Ai/bxtizKaEN O3sg== X-Forwarded-Encrypted: i=1; AFNElJ/Fj5i9KVAuftyztpfX+xJ/KNdYNorUKwebrTByI3No9XofeDsAqiKCfG5mJbWdmLPWFoejhbwhTLghk8w=@vger.kernel.org X-Gm-Message-State: AOJu0YxXP+DCWcRVPREw1AMXLTtIONgRpkQtRmk3YfGj5QoKqwQKgihj pzYecx0obKKt+ZS6ERexvmt6GCrdv4YTbAKaYj6eAKeuSpIe/bwyrZNC X-Gm-Gg: AfdE7clG7i21D0J18IX3FhUWdVYB1J2Erld3GFHUevNpFdTKsPViBn/IxUabDLMSS1l 5IJFZRUg2mHoqIct2CACz7t/6SROam1p464zDxUsseNeys0Kc6cKaXyM3ChDbW5gtbBpQSpK/7L Q7wwv+b4BT3/966EPv9irimjCvyKJDEB0zyU3evWUpGOcy5WY+prUytC2ZyP/yjbiy0aMR9fRJ0 h+b1LhgTAgvueElX6DRXukFrObTfxzRYOb9qfOmMHsAtusXHYQHapwAIJUczkvCfSukEarU4g/q fuwNwGZlB8MYl4zw8Ls3Gvjd2B95qg3wJyktmxIzQwsTkUouFRy/8+07LhXZs7yR1KMCJnosSzx ccno2sZOIlFYVsIgss7Xfu+jDR32iAEMKafcyIe/OYFWSW24NbdGyn82Gg0ECEl0+/LRVWW2GkN WG9cHf5Xr6tFfNmagCZSCDrjpErlbIzUbmJYY3ufc9HGXg/2YQNrasXAY9DJZKTtaUiw== X-Received: by 2002:a05:7301:7c0e:b0:304:9b48:53d8 with SMTP id 5a478bee46e88-30bc9df7446mr796485eec.10.1781653980896; Tue, 16 Jun 2026 16:53:00 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5d3f20sm20208153eec.9.2026.06.16.16.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:53:00 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v3 3/4] staging: rtl8723bs: convert update_attrib_sec_info to return errno Date: Tue, 16 Jun 2026 23:52:40 +0000 Message-Id: <20260616235241.99076-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260616235241.99076-1-dennylin0707@gmail.com> References: <20260616235241.99076-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert update_attrib_sec_info() to return 0 on success and a negative errno on failure. No functional change intended. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 69b6d3a2554a..066f6e974e4e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -505,7 +505,7 @@ static void update_attrib_phy_info(struct adapter *padapter, struct pkt_attrib * pattrib->retry_ctrl = false; } -static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *pattrib, struct sta_info *psta) +static int update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *pattrib, struct sta_info *psta) { struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct security_priv *psecuritypriv = &padapter->securitypriv; @@ -519,7 +519,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p pattrib->encrypt = 0; if ((pattrib->ether_type != 0x888e) && !check_fwstate(pmlmepriv, WIFI_MP_STATE)) - return _FAIL; + return -EINVAL; } else { GET_ENCRY_ALGO(psecuritypriv, psta, pattrib->encrypt, bmcast); @@ -558,7 +558,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p pattrib->icv_len = 4; if (psecuritypriv->busetkipkey == _FAIL) - return _FAIL; + return -EINVAL; if (bmcast) TKIP_IV(pattrib->iv, psta->dot11txpn, pattrib->key_idx); @@ -596,7 +596,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p else pattrib->bswenc = false; - return _SUCCESS; + return 0; } u8 qos_acm(u8 acm_mask, u8 priority) @@ -755,7 +755,8 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p return _FAIL; spin_lock_bh(&psta->lock); - if (update_attrib_sec_info(padapter, pattrib, psta) == _FAIL) { + ret = update_attrib_sec_info(padapter, pattrib, psta); + if (ret) { spin_unlock_bh(&psta->lock); return _FAIL; } -- 2.34.1