From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E02E33E351;
	Wed, 17 Jun 2026 05:45:07 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1781675109; cv=none; b=f4+AHaaAQLb3o9BYmg3h/2aq4Lcg+/BIc3sQ1MhAltEpw2xaEZweMcYXH7I7Zp6QM0/p7T+eoEp+Z93pKDzT/atSAHN9UO9kd58NfJDjDcEtdUH6gS5vWbilfARazJZBbW7u66fgwaOSurSnPf/phJgMPThsaesmOX699qkow+s=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1781675109; c=relaxed/simple;
	bh=ItZc8XWqX890nlY47RSC4Plq76j3f4jdB22w3KvoZec=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=ucFA1V8FdFliyNIH7V416piKKNvprdvq4apfI0o+5+eGtf7VO1TZPVkQL1tar2MnWO9XA2/FjkuOPXi7/RVLzlJ/4evuAfoOc6A2IzBK8YEM0+lJiE5vVnUsOiyFml+z1rpZj/EHm0TltwO1efLht2z37HReFtcEnV4xdUH0Wl4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 212A968C4E; Wed, 17 Jun 2026 07:44:56 +0200 (CEST)
Date: Wed, 17 Jun 2026 07:44:56 +0200
From: Christoph Hellwig <hch@lst.de>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Borislav Petkov <bp@alien8.de>, Eric Biggers <ebiggers@kernel.org>,
	Richard Weinberger <richard@nod.at>, x86@kernel.org,
	Christoph Hellwig <hch@lst.de>, linux-crypto@vger.kernel.org,
	David Laight <david.laight.linux@gmail.com>,
	linux-raid@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-um@lists.infradead.org
Subject: Re: [PATCH v3] lib/raid/xor: x86: Add AVX-512 optimized xor_gen()
Message-ID: <20260617054456.GA19125@lst.de>
References: <20260615190338.26581-1-ebiggers@kernel.org> <20260615201050.GB1764@quark> <255CAE3E-7FD3-4DC2-B3DE-46BE67EF22A8@alien8.de> <20260615212922.GA28589@quark> <20260615235318.GBajCQbuy9dBgKH8L_@fat_crate.local> <a832eee3-55ec-4cf4-907f-346ff98870ca@intel.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a832eee3-55ec-4cf4-907f-346ff98870ca@intel.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Mon, Jun 15, 2026 at 05:29:58PM -0700, Dave Hansen wrote:
> On 6/15/26 16:53, Borislav Petkov wrote:
> > 
> >> In any case, I'd like these to go away:
> >>
> >>     $ git grep cpu_has_xfeatures | wc -l
> >>     31
> > Yeah, all in crypto. I can certainly see why.
> > 
> > @dhansen, any other thoughts?
> 
> If we can get rid of cpu_has_xfeatures(), I'm all for it. I'm not quite
> sure how the code would look so I'm reserving judgement until I see the
> patches. But it's worth a try.

I think the most important part is to be consistent.  Either use it
everywhere or not at all.