From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F0B24418F0 for ; Wed, 17 Jun 2026 10:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781692876; cv=none; b=TTze2IRODBspH/p0NcgXJgSSE49M+Xm6pNN/DXBfUrLe6K44TixFYFjDZe7GTQdxlaUrUD9XP03WmVK/wRQDrluyM76fcJ75VgxJ9ea+gEOQthj+MddwSqd1TTYFBXwLsFyu484kwSviIZjvhdaSe+V5nPfa31JOxSGlxsC5Kg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781692876; c=relaxed/simple; bh=dLcsmhfPTMCw3dE9DumePoMRCtlHGUVY/pwVPWnU2Xo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MRyrnZp5zrH+YYU4jcIYlwOuyl0BEoaqNZreJCb8RqL34ZQ/ydiGH7n5kMUiBKhPEtwbcw1xO2/SOu4gkD8Ep8Y1q3m/VSxHZvyQbmOeXqSrrARlXNzAiZeQOX3vXUGNv9cyBBPYq4KeRSAPtSZ4Ww4YQK72laol0EaNyfW6TkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d05YM2Pp; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d05YM2Pp" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-30bdb3eb5f0so152988eec.0 for ; Wed, 17 Jun 2026 03:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781692873; x=1782297673; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BwjSo2YB1qAt2HYPfLpM06SwzNXlHUGTMn3Wr6swOeo=; b=d05YM2PpKa7q0wU9lGIO+Uy25CTmS14NTUA5XMm30/g6pyFLiLRIf2xggZSrXn+FGT 1IeG9PPj9qkM4zvtiJ2pDGcfY8PBki8SnRS/ft3Dxefmv8qIG8Poi1ic9osCFRWqAFC7 z80SnjqiZ+k2PArYtZZeehvOg7uk8xTCbhuNW6AayGj111dOkefwyOnlRWuwo7u0Ytrz 4wPBmow86HTEeDFNnR47txEuE8jK0LdOUoCK5CHm53iTYX63ygSdnTU8YD0fnloCv9Ns lRbz+FwpFJxWjtxacAWNKYVIYHMHanWCZpnA3QTJ1Vws7EjsdyfoQUB8v+U5jpq/qtpd BgZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781692873; x=1782297673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BwjSo2YB1qAt2HYPfLpM06SwzNXlHUGTMn3Wr6swOeo=; b=Q01QBbHEod8Alw3+TPClMxVL/swviEaAcqbzt0WOQmIK5TfQpXU5LoNTfbo9OZA7J8 nD7AC1gZt0lH4A4Yr0sSRiWmR/cx2Jzu9REe3bN+ostatvvKPPFBZO6Or776/xcyvyiL MwWP82z72Rzp8Vh+eEXwBdBpNy2NnUgBvHs7wEE/vCK2ZsV2hg8SnyUnuch1+6oTZaQg h/ENIYENM7bhGsVFkiDwFI3mJadciniokSWCYXAS/17z6ZjaZDgLiDrcLSrGi8bqF7VB 0ODHKKdKGgtdfyHZl0K8Ii+6c/TWvMfu1uBYu6wDp2mdv0pd2OgHs0ZvsAE5/wGi+wvr s8tQ== X-Forwarded-Encrypted: i=1; AFNElJ+QPcZJLFPJ2UoUqPEH7fqupVccbe2wxu3Y8NEyykGL9O65tLi5SIepBDqQBtCJ/ReCyq0icl3AGQHlj7M=@vger.kernel.org X-Gm-Message-State: AOJu0YyLK0XhlC7dLWkUcU0Y+ZepUN1IyqlC0zZGaL/iKLILBMMvLlbn c0bBWKewillvixpY9Kob84Vv4qYOfZT6oXjDLnxfWaRIXyzBLp9yG/5s X-Gm-Gg: AfdE7cn0EoOrH6X25u/IyWhY2fxQsj4tXxvSmLdud5v13OGN2iXOuuWzcG82nFZoQZq DMILYkshfnvCamjfxw2qWZch/8/r2H4xkP4lXKd0u3QPmK3Xjy4M8FF640o7JRd5iynNAg5w+gh kCWF7NUPq54eRkxZUm4XUQ9szaLvbsqAFOrqaDxIwvXF/OtuZOYdATCcWMTImVCp8FovJpPLOZT FLNMJXJm+qChcRRUltdNfdZPilu8BOA1IdlC+ZpNYcAE88xPkXUbSP8Z6DDrpcUowo8XG/APlnf WI8IOvQiTegAED0c6OipAUQwddXX9BbdvPhRal7ImnhMul8gxKFlU2l9snoytyMryk6VrJ8CRKN +EKdEW8QIu9wB/R/6oisvcjtzG3bwtI0Jdvff6/zrt0PHzHydApmj30HbRNjjU9C17UagxKCzLE lTx//0rNOdXebeQPjvDfQ82ZDTVgYpJVJ8fZpxBzXkny3vK2Q= X-Received: by 2002:a05:7301:60d:b0:304:ddc3:2c35 with SMTP id 5a478bee46e88-30bcf6002c1mr1306991eec.10.1781692873410; Wed, 17 Jun 2026 03:41:13 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5d0828sm24616275eec.10.2026.06.17.03.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 03:41:13 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Cheng-Yi Chiang , Tzung-Bi Shih , Guenter Roeck , Benson Leung , David Rhodes , Richard Fitzgerald , povik+lin@cutebit.org, Charles Keepax , Support Opensource , Nick Li , Herve Codina , Srinivas Kandagatla , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Oder Chiou , Lars-Peter Clausen , nuno.sa@analog.com, Steven Eckhoff , patches@opensource.cirrus.com, chrome-platform@lists.linux.dev, asahi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bui duc phuc Subject: [PATCH 53/78] ASoC: codecs: sta350: Use guard() for mutex locks Date: Wed, 17 Jun 2026 17:32:10 +0700 Message-ID: <20260617103235.449609-54-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260617103235.449609-1-phucduc.bui@gmail.com> References: <20260617103235.449609-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/sta350.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/sta350.c b/sound/soc/codecs/sta350.c index 99c7f7ac807b..b1e2f346c647 100644 --- a/sound/soc/codecs/sta350.c +++ b/sound/soc/codecs/sta350.c @@ -306,9 +306,9 @@ static int sta350_coefficient_get(struct snd_kcontrol *kcontrol, int numcoef = kcontrol->private_value >> 16; int index = kcontrol->private_value & 0xffff; unsigned int cfud, val; - int i, ret = 0; + int i; - mutex_lock(&sta350->coeff_lock); + guard(mutex)(&sta350->coeff_lock); /* preserve reserved bits in STA350_CFUD */ regmap_read(sta350->regmap, STA350_CFUD, &cfud); @@ -325,8 +325,7 @@ static int sta350_coefficient_get(struct snd_kcontrol *kcontrol, } else if (numcoef == 5) { regmap_write(sta350->regmap, STA350_CFUD, cfud | 0x08); } else { - ret = -EINVAL; - goto exit_unlock; + return -EINVAL; } for (i = 0; i < 3 * numcoef; i++) { @@ -334,10 +333,7 @@ static int sta350_coefficient_get(struct snd_kcontrol *kcontrol, ucontrol->value.bytes.data[i] = val; } -exit_unlock: - mutex_unlock(&sta350->coeff_lock); - - return ret; + return 0; } static int sta350_coefficient_put(struct snd_kcontrol *kcontrol, -- 2.43.0