From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CA913859FA; Wed, 17 Jun 2026 21:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781730858; cv=none; b=sLAf1rBBZpV41PU56oCl3N/n40BGb4tJyGWCEttBhV5wnTxMehvUn498BnfWqLNbpADzq+fy6nwnOZrIcrTGuI3yCnhRdCb9xBsBCF1lopvkyEagNlKpVahFL2nIV1SLv6qaW4XxiWyPsSOehsvH5lWn5Ic1gjM5u/IHYKF8NiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781730858; c=relaxed/simple; bh=DP4XsqgSCqRl4Z3knsvmPriVGaogb8fGF/TxZQznECs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dAn1DbWUyUi6tM6ZWOqCoiGnrGyFbfaCSyqb480mdpDkOqbp4brgsrVF+CRpoxXQ0SvKMD7olr26rxzGWHmOsnmHQltc708or6790bvavN0rdPyD2o00X4L1mhME9eDdcNh/sn0H7VGC3odpg/oF2/aJKKai6TkQ2e82fKQ/IE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HGpRBolR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HGpRBolR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93B651F000E9; Wed, 17 Jun 2026 21:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781730857; bh=9nVBTi+PRr2qdNEg9BODiXO+ryEvvJq9cFm953MyMuY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=HGpRBolR1hIidUMLs6HJIMDGR48bg5rasBGjyVRxZtUkyqGgAnDSgbu6u9Z7ti8t8 Ccrdt5DuDZ3abmdLP75VJCwHjGTkbCcmOkkrk+izygBDOMw2nsaCfdj+9kg6rze7WG zZFxl5JFCTJHZ+UPhHOgZJ/awRwmf6sV8njiv5I01j2740kKhdqk8dtRfKKIJMVZ3v zA5B/+eeiiNblWKlK95Sltg5BLm2wOSQvMHibDVhtaPnhF9utD4hgs/O0V3Weooy4G jPPi3oBLdythI/vDhOP8KnJwPy8E54uJcw2PyYvgi/MAWxQhmYN1bXnBi0hLzZoorJ kXCPJlbubnBCQ== Date: Wed, 17 Jun 2026 14:14:15 -0700 From: Jakub Kicinski To: Sabrina Dubroca Cc: syzbot , davem@davemloft.net, edumazet@google.com, horms@kernel.org, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] WARNING in tls_err_abort Message-ID: <20260617141415.0f479688@kernel.org> In-Reply-To: References: <6a315d48.b0403584.28d0ff.0002.GAE@google.com> <20260616082816.4dd0f035@kernel.org> <20260616142359.43300727@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 17 Jun 2026 12:00:31 +0200 Sabrina Dubroca wrote: > 2026-06-16, 23:46:28 +0200, Sabrina Dubroca wrote: > > 2026-06-16, 14:23:59 -0700, Jakub Kicinski wrote: > > > In which case the question is whether we should try to remove > > > the sock_error() instead? (stating the obvious I guess) > > > > That would make sense, but we can't prevent sock_error() being called > > from some helper. > > Actually, getsockopt(SO_ERROR) will also clear sk_err. If we want to > prevent further state transitions, we'll have to use something else > (probably a flag in tls_context set by tls_err_abort()). > > So I'd go with 2 separate patches. The 2nd one will be a change in > userspace-visible behavior, but hopefully not one they'd be upset > about. Seems reasonable, FWIW