From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: David Howells <dhowells@redhat.com>,
Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Li RongQing <lirongqing@baidu.com>,
Oleg Nesterov <oleg@redhat.com>
Subject: [PATCH v2 06/17] afs: Remove erroneous seq |= 1 in volume lookup loop
Date: Thu, 18 Jun 2026 08:48:49 +0100 [thread overview]
Message-ID: <20260618074903.2374756-7-dhowells@redhat.com> (raw)
In-Reply-To: <20260618074903.2374756-1-dhowells@redhat.com>
From: Li RongQing <lirongqing@baidu.com>
The `seq |= 1` operation in the volume lookup loop is incorrect because:
seq is already incremented at start, making it odd in next iteration
which triggers lock, but The `|= 1` operation causes seq to be even
and unintended lockless operation
Remove this erroneous operation to maintain proper lock sequencing.
Fixes: 32222f09782f ("afs: Apply server breaks to mmap'd files in the call processor")
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
---
fs/afs/callback.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/afs/callback.c b/fs/afs/callback.c
index 894d2bad6b6c..833ac3178ddc 100644
--- a/fs/afs/callback.c
+++ b/fs/afs/callback.c
@@ -140,7 +140,6 @@ static struct afs_volume *afs_lookup_volume_rcu(struct afs_cell *cell,
break;
if (!need_seqretry(&cell->volume_lock, seq))
break;
- seq |= 1; /* Want a lock next time */
}
done_seqretry(&cell->volume_lock, seq);
next prev parent reply other threads:[~2026-06-18 7:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 7:48 [PATCH v2 00/17] afs: Miscellaneous fixes David Howells
2026-06-18 7:48 ` [PATCH v2 01/17] afs: handle CB.InitCallBackState3 requests without a server record David Howells
2026-06-18 7:48 ` [PATCH v2 02/17] afs: Fix error code in afs_extract_vl_addrs() David Howells
2026-06-18 7:48 ` [PATCH v2 03/17] afs: fix NULL pointer dereference in afs_get_tree() David Howells
2026-06-18 7:48 ` [PATCH v2 04/17] afs: Remove setting of AS_RELEASE_ALWAYS for symlinks and mountpoints David Howells
2026-06-18 7:48 ` [PATCH v2 05/17] afs: use kvfree() to free memory allocated by kvcalloc() David Howells
2026-06-18 7:48 ` David Howells [this message]
2026-06-18 7:48 ` [PATCH v2 07/17] afs: check for duplicate servers in VL server list David Howells
2026-06-18 7:48 ` [PATCH v2 08/17] afs: Fix bulk lookup malfunction due to change in dir_emit() API David Howells
2026-06-18 7:48 ` [PATCH v2 09/17] afs: Fix misplaced inc of net->cells_outstanding David Howells
2026-06-18 7:48 ` [PATCH v2 10/17] afs: Fix reinitialisation of the inode, in particular ->lock_work David Howells
2026-06-18 7:48 ` [PATCH v2 11/17] afs: Fix callback service message parsers to pass through -EAGAIN David Howells
2026-06-18 7:48 ` [PATCH v2 12/17] afs: Fix double netfs initialisation in afs_root_iget() David Howells
2026-06-18 7:48 ` [PATCH v2 13/17] afs: Don't use AS_RELEASE_ALWAYS for dir/symlinks part 2 David Howells
2026-06-18 7:48 ` [PATCH v2 14/17] afs: Remove erroneous seq |= 1 in volume lookup loop David Howells
2026-06-18 8:25 ` Oleg Nesterov
2026-06-18 11:59 ` David Howells
2026-06-18 13:53 ` David Howells
2026-06-18 15:08 ` Oleg Nesterov
2026-06-18 8:43 ` 答复: [????] " Li,Rongqing
2026-06-18 7:48 ` [PATCH v2 15/17] afs: Fix leak of ungot volume David Howells
2026-06-18 7:48 ` [PATCH v2 16/17] afs: Fix missing NULL pointer check in afs_break_some_callbacks() David Howells
2026-06-18 7:49 ` [PATCH v2 17/17] afs: Fix vllist leak David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618074903.2374756-7-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=christian@brauner.io \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=marc.dionne@auristor.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox