From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BB7E2E1C4E for ; Thu, 18 Jun 2026 20:01:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781812879; cv=none; b=dIGQCEkcEPcZWCPlS07/65C/e2BpBDSd56wn6GFAoh3OOyqDECj4LvLQi5VrYVejd3reM+l3Xupiovik+j8C47CoualJbrxn1RpAHOGddOgfnhYBOYSL0/Dwjim+QFgFEV/+CSYjF9pzdi2keUWEEbPpz0nvLbZx3bewxwU42QQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781812879; c=relaxed/simple; bh=rJywt2XzZTxgO2/fXTFq0yjtSid6O3lw2zJIp3zL/1E=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Uxh6nBeGSdwBEz3+nTGtY1g99ixt237k4Q/Bt7iNzpRVs8vwMhTt4xNUSosWSCbDCav2bUwjWPS0pKSMuMHTrV1xKnr0S1aGoKyIpxYs2OXvLHLrIRj4XjRWez0/enPqsFFxOA8DsL+gZoTDBRpauR9Oj9KWB1/Ja3KFh3Jr6UA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gvDuVzwZ; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gvDuVzwZ" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2c40397e3caso14523925ad.2 for ; Thu, 18 Jun 2026 13:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781812878; x=1782417678; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/KjNn7oIPOk5S1KhGdV+Qc8EkkjlRGU4my6m/nNkSF4=; b=gvDuVzwZB4u+7YoO3bFT6WtwJNrNGrxDVWd1NjALAj1L+4KSSs1iehVzGEQD+AqRRp 5f9ARj4cIZeQbUNqlSBYsREuszj1ftgZv6rtFAjeqP7Apq/r2CE7ZTHDYfiE/pe27XSq mtUrkOJmc+4VecNLkRnOJhnUTLbDwo2nF0ny3npjcDXnTzejhNV+a6lafFscvwm2i+qz oe0ER6+HgCkJaGvmSaHpFp4FyrcoDxkrzlywE0g2eintddZuGOjOcVZjR7gVlnYlHq6c QYioxQorGAPb3crg3lc77vCBVnz+pOjww4GJpilj+fS4lI0eb6Va8lMfloxQZCwRVXG5 Jr8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781812878; x=1782417678; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/KjNn7oIPOk5S1KhGdV+Qc8EkkjlRGU4my6m/nNkSF4=; b=jkoxbAOZzAeEyUlbECbxzoTxsp/Pg1LQYjLFpsXJZROlU2pM9CMOk3NwmtTQSogs66 K0GRjXaRL/vkZtlp2ERtH/5uqK5fMvPWWuSwpfFYOGkhQAk648WU1SjCe3FYt2T4nHLC r3lFSIvlkRGd5OEgPUFO0EIrdC2UpgFOEVJC1pHK6b1WgsxGeOrj9vjOwCspRFPdQb51 hYwqrDR4HzhFueDcRsl/WaiNJkqE5u9yphlW+KcM/h9JnWH+v/UwnlzEsV5vDyVTcNsf 9aWGhMv54PO8utq81Xh/1HYA+sHi2xrsErZk0YYcEVYQsvo8iILNpMt9KIgvaJuMyLTY 1+pQ== X-Forwarded-Encrypted: i=1; AFNElJ9f4emn1Of9Zw95mYCsOI8eaXJutspax4xVA7NNgeRkShYd+m+MfC/8+oFA8eUM1AeyxpdLKUzv4i4x+2Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwKqRd4X8yBQvfQcLLjPU0b+yzrmoD5Opa7DKCO2hQh4COmy3/i Zk2Bb3A4ieZO0kfu28Xrk74+iSxi53pTbQdUBYAE7sfptQT4OauuxV6B X-Gm-Gg: AfdE7cmCv/K9a7g1JH8CxT/dGMkL32D5SsYNI9i3XCVpqJxd+emHYkTXSqPCnxue3GL RT26oPl048R+x0vOH2ux8KyZOFgFSBbWikZb7Dt3DTOe5lXhIYde+pgMZJeOb97TAbTpBB6UOfk qWwDlJ/Wmkq8Ih6dKpjCoHv+AStPTheoVoG6zOGhOhC6WOO2b1EUE7uRQ0Z8wb3vZjBpRkj4nQ4 g9TLhqee3Du+8nm1et2OCgrbugtAmx1YEta9FmrQX+J+7reSwNByI3wy6IU44c5pTjQ51ULc6NA mIhnYoKA4IYA6hRM35SlqyygVY1THvNkvF3TPWCS3tqf1YGmbEcjoMynpL1E9qyhsUdgeNU6ISV 2iZ2q1FQqPPXHHFVAg+mZejBMDoIzbuKUnnZVi9b5oYuoI1OnYLdMj1GqCYPVRct7+3YAbs9agP gsLZeMjQ9i2tAM4ME8eBqOydpg4GUobM3zPg== X-Received: by 2002:a17:902:dac5:b0:2c6:cf81:74a8 with SMTP id d9443c01a7336-2c71900ff22mr6485405ad.30.1781812877821; Thu, 18 Jun 2026 13:01:17 -0700 (PDT) Received: from LAPTOP-TMVMP5FD.localdomain ([106.222.251.180]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c4327ac72asm225736595ad.38.2026.06.18.13.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 13:01:17 -0700 (PDT) From: Keshav Verma To: jaegeuk@kernel.org, chao@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, iganschel@gmail.com Subject: [PATCH] f2fs: fix listxattr handling of corrupted xattr entries Date: Fri, 19 Jun 2026 01:31:05 +0530 Message-Id: <20260618200105.3551-1-iganschel@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Validate the xattr entry before reading its fields in f2fs_listxattr(). Return -EFSCORRUPTED when the entry is outside the valid xattr storage area instead of returning a successful partial result. Signed-off-by: Keshav Verma --- fs/f2fs/xattr.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index 610d5810074d..18f495db20d2 100644 --- a/fs/f2fs/xattr.c +++ b/fs/f2fs/xattr.c @@ -581,8 +581,6 @@ ssize_t f2fs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size) size_t prefix_len; size_t size; - prefix = f2fs_xattr_prefix(entry->e_name_index, dentry); - if ((void *)(entry) + sizeof(__u32) > last_base_addr || (void *)XATTR_NEXT_ENTRY(entry) > last_base_addr) { f2fs_err(F2FS_I_SB(inode), "list inode (%llu) has corrupted xattr", @@ -590,9 +588,12 @@ ssize_t f2fs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size) set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_FSCK); f2fs_handle_error(F2FS_I_SB(inode), ERROR_CORRUPTED_XATTR); - break; + error = -EFSCORRUPTED; + goto cleanup; } + prefix = f2fs_xattr_prefix(entry->e_name_index, dentry); + if (!prefix) continue; -- 2.39.5