From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FEBD258EDA for ; Thu, 18 Jun 2026 20:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781814683; cv=none; b=BnXu4g2BYV+kMSDyCcP+6xILNzDLbiMbkc6nnbkMoXp0cJCoowDdGSqBC5OLutasmUx4IztnLsbPKXCyUMygw3NuUVn9NApaGIBlbLHM/XrlObk3fmVkzZmZi1ZY9iVOWiB+jRUnfrGpeO6vzgU3qSk6MC6D6okoK30p7HwYGLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781814683; c=relaxed/simple; bh=/LPHXZT7LD771IVECNquueWpuQAnVIKcTNUWyjKTOHM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=FC36AtUBxfuNvujT2bucW5U5aBFZ3h9o3kZ+WEcY/Hw1ReE58E2Ushh51Q4H1Jip9OE1N0aZD8coXzwtNz4UbzlPO2ERoTwyL6kLa1bpvDrhhEn+1VcoFfbNsA+aMkbfXiSHs2fsD1iPYbstj64wn0QRIou3YI6Tidx2wlJCk0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eSEtq4CS; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eSEtq4CS" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-37cab825ec9so1218183a91.1 for ; Thu, 18 Jun 2026 13:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781814681; x=1782419481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hY833qL63LecSXXf24b+TIT9KgU6CCDE0sbpVpUWuMI=; b=eSEtq4CSsT6JKcYk9i1QI6lR7Aupgp4Wn2dD8yLjW9sRKoirMwOGXczLslllss6fnJ AFziRRp2IbRTV/DQrD39KSGeG9kjhCb2v3dmT3ZMbtNof6hILPv/tYjOvZ8gsjnrDUF+ 4SHe4OJhScU/sC6h40nToOMprRU12MsTxXV3JDPH0HochCRBGXEzMZ5jIJN35owkavlc m8s6Yox6LsQOySElTeqlLtxxV0ZYYjS/C979Dkkfe3aASWIL2r5YkphErxOhrSO9eOHv SzBWdJapznb3pYs8SIxTDRHuLqfXagivzEE5SNDPDeRB0plqOaNlbMDt0VofgzoDIG0K RGqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781814681; x=1782419481; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hY833qL63LecSXXf24b+TIT9KgU6CCDE0sbpVpUWuMI=; b=EINR3EJUMNdz0P2z7yJpy63M1KVr1V16eJrMHNFBrk/q1RmIHZCySDwy1MqenOG40X 8fAArD0dO/TeSbicuiwgzIJ5d3uxxO6GOR9ImCCOnW0UqzvWm8Rk1eyfO3Ld51d9nP4V rNB7A9ZwuGdGHfd93WSezJ4G3IuCeJP4ee8m3H92Z4/BwyPUdwYuz9BPAyQKNYy+eWp/ 4u9w2KU9OSgOE0dmyD2xvVDbR3oXjoKCuxYu8I5f797pEFajeu76uJLVkZQCzWKFjGCV WLM7gwB11oV8mjOAVXbrICDX2DKwPWXQI+Yt3DGjDkprmyBRFqgZjhLAFUmHHnVlAcTC X+HQ== X-Forwarded-Encrypted: i=1; AFNElJ8+118zzCxsdvG6ujUWetIDCBugrHbSNLqL4Sfkd8buoK30gDYSIqdoKiRzhENZtzprGU78UHzzcB2uFa4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5HkoxKCeE/CdNWI8NY82dM4iDPRgaahuOFB7WHrlwIOcNt93X JR5MzXxya+w3TAiAiqv0yVrMA+inmtAyGh5EFN/K3yKlytlWHpt0FKGE X-Gm-Gg: AfdE7cniqn8oxk28GWLsnn1cAFO0iP7iKuCl7gU2C8buCnLH78+Wp9gIkftPvOmtWX8 QaEzD60s2DzXvTZbjCk5baFiDq6uq9HxnlDH4KKb0ojXqMN15A5nyBTvv/CVYxcY7xElsqmUiOC iUcY1KSTnoswNenNi+4MYhGGF2RYWGhii7njyDDHIwdq5zllnDtTOdWgoRIoLKmK2jdlJMZxpiV XRvtOwwtOWFOJtmT8YMUVK/xf53nsQI8MO6QBP2rA71fLLQUVFEjXYG9TuhxRf7no86LRvgUA1F 7Yhcs9MDkUz57RXg6VvyOVC5Q3MXiXfwyKowMWuz+02eLPFcDUhhCAuKeMzybrrSs9qPSN6f3yR 4Z8bdArEm6MAkTz6YEJhLvUzYfdL421pCNM3HDsxRLmlxrcCMXSamdazsj2HRIh7sFcF2XWDwrc 46IX1FmDbTV4kaWX1EKV/eloOc9sFt+1IxQA== X-Received: by 2002:a17:90b:2709:b0:37c:ad9b:680b with SMTP id 98e67ed59e1d1-37d15e90058mr1278525a91.20.1781814681485; Thu, 18 Jun 2026 13:31:21 -0700 (PDT) Received: from LAPTOP-TMVMP5FD.localdomain ([106.222.251.180]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d15de5d3dsm544009a91.10.2026.06.18.13.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 13:31:21 -0700 (PDT) From: Keshav Verma To: gregkh@linuxfoundation.org Cc: johan@kernel.org, kees@kernel.org, o.bock@fh-wolfenbuettel.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Keshav Verma Subject: [PATCH] usb: misc: cypress_cy7c63: check control transfer status Date: Fri, 19 Jun 2026 02:00:53 +0530 Message-Id: <20260618203053.4725-1-iganschel@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit read_port() currently ignores errors from vendor_command() and always returns the cached port value. This can report stale data when the USB control transfer fails or returns a short response. Return the underlying error for failed transfers and report -EIO if the device returns fewer bytes than required. Fixes: 9189bfc2df0f ("[PATCH] USB: rename Cypress CY7C63xxx driver to proper name and fix up some tiny things") Signed-off-by: Keshav Verma --- drivers/usb/misc/cypress_cy7c63.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/misc/cypress_cy7c63.c b/drivers/usb/misc/cypress_cy7c63.c index 4a7f955ba85b..8601ee0a1ea3 100644 --- a/drivers/usb/misc/cypress_cy7c63.c +++ b/drivers/usb/misc/cypress_cy7c63.c @@ -177,6 +177,10 @@ static ssize_t read_port(struct device *dev, struct device_attribute *attr, result = vendor_command(cyp, CYPRESS_READ_PORT, read_id, 0); dev_dbg(&cyp->udev->dev, "Result of vendor_command: %d\n\n", result); + if (result < 0) + return result; + if (result < 2) + return -EIO; return sprintf(buf, "%d", cyp->port[port_num]); } -- 2.39.5