From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1714240D564 for ; Fri, 19 Jun 2026 00:10:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781827825; cv=none; b=KW5l5v5tdpdWfyvfS1L5/mxVKCKYKVzqLENSkZ19jw/cOEZSChVg6cML+gVjzHW1TXe9XvnIrJC2XLF1oHXFQ758WXotreYsyNupwM9a0tMefFS0yFsFEIoDQ1dGPOiOpmyJbfYEYV6EnzJhPHUOFxOBVWuBfe0ZbhKor9RfcbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781827825; c=relaxed/simple; bh=l26oMg6Y+q5R9kQFpZUCnFIgmUwihRtv59Nw4YRlc78=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pR0knij/orfzlrn6RH4xUuc+lWzo1OM4VhDkY3naXCMaTNGz3dtbu9j2mz8yIm7uNd4rJFjg/DNuPfH/DdbFpnfLKe2ASA/r1NfTw//du+el4iQp7w7DqFgN30ZhhgGMKHc6uiflgytzy+1+b6pFOxKEr/WAAIFopYj98p4ruVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wr+2uFbG; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wr+2uFbG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 561791F000E9; Fri, 19 Jun 2026 00:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781827823; bh=H4FbbuGK/OgsiogMEl+IcPPeV4umJ2OIQeFHkFCYa5Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Wr+2uFbGxWXOg/AYQVEaZzGNq9vi5/qaoWXS+u6Gd0X7LlnTsusgHnrVuwqUSRPek Y5Gzc/2CqrjWHJ09h2LguuY9ODTJIJIoO85QLHnTtzraqiYXwF6Gu5bbvakzcNpArI 3c+hYOW/h7CRSCzdZgn+mcbqeCPCDqEsvJ50MpKvg9Rsyxz8h9djiDjjRcYYpHoweD Mhdlp2D84ByFw2c1q3EPIBKak7qBaeuT6THzUxTVkCxuc/PRbZtU9tfcruv3YkkIJh KcHSKe0+NBUGsk/4//G6ZFNoRWp1WA1cnJW9Jl5d/AiLQal7f7AMsxfOIu7HAfyGSx JtxoGrpstrVRQ== From: SeongJae Park To: Ben Dooks Cc: SeongJae Park , Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: don't build vm_numa_stat_key if CONFIG_NUMA=n Date: Thu, 18 Jun 2026 17:10:11 -0700 Message-ID: <20260619001012.8221-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260618100614.1321950-1-ben.dooks@codethink.co.uk> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 18 Jun 2026 11:06:14 +0100 Ben Dooks wrote: > The vm_numa_stat_key is only exported if CONFIG_NUMA is set, > so avoid the following warning by guarding it in an #ifdef > on CONFIG_NUMA: Makes sense. > > mm/page_alloc.c:165:1: warning: symbol 'vm_numa_stat_key' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Reviewed-by: SeongJae Park Thanks, SJ [...]