From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB38B846F for ; Fri, 19 Jun 2026 06:24:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781850260; cv=none; b=jrFfK6nK1gV9I+0rUZGLyx7QOaBLU8xPh9sM9RZDgmXofonjZyzYsjwvMr4J43DfGvXoTrKxvqPBG4OWbDIdaOo6rk1FY5Yi8KFl0kSxei+LJ5HAuC0nbaP4yK6KN95+BooRM1uJF6BLuSag8ZEApHiJJ7VSHwxO8ZXu5eYd2hA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781850260; c=relaxed/simple; bh=lsXvP8pl5PqLcD4r6IIbZevbJXsiPYu6GHnGFkbjl1Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bRmQfYVRjqXqIwt4qWnZwo2EdaxONkAYxpM+WKybNWCDMQ7SMz+wL6g5NPBrc3KzsArrbNHPSv0HYPHRYR68ZL8FEiFa0Fqa3iuuqmX/oOiQUiTsgbddLX4U0GOSj1htFyK0RjHHwgdYw5ou0m/jMufkMH/ecqLMzUEj/fm7KX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=iKEUORVO; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="iKEUORVO" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description; bh=qXTF3E+HgaYjd3XnQ351L22o4q4lpEMDwJP01SjL4fk=; t=1781850258; x=1783059858; b=iKEUORVOub6k9DaxlWBz6ilR1mwPUlzJ6n1Mo99eKHHMpc2PkX/mzadRF90KBQsoHxYWSjQPQe4 Z39v2l8RUxFkMPfxyuvf6Q6/B7EH2jCpBfgwTFZrIpQGRewVXz6hruVHYwB5blHQRQGKtw98jdZ4L 1uW5AT5i0TbUzob0bhYcV1phG+eQCJtPb1rK05Z++twv9rUlJOmQy/0rkCj1cuQOOpka+rQNxO4Ri UTgjuo/TFHnsKZCJj3SY66hFZ0qTlX99XDGidm4quXgE9YjjnbUGwZmSGfimvgjFObkUvL474hHAf uqtMtqV+gnHggfgKyj2JIXsi0GHZMVluelXQ==; Date: Fri, 19 Jun 2026 08:23:50 +0200 From: Andreas Kemnade To: Tomi Valkeinen Cc: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson Subject: Re: [PATCH v3 05/13] drm/bridge: tc358762: Drop SPICMR write Message-ID: <20260619082350.2ebc0cf7@kemnade.info> In-Reply-To: <20260513-tc358762-fixes-v3-5-6698b55008b9@ideasonboard.com> References: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> <20260513-tc358762-fixes-v3-5-6698b55008b9@ideasonboard.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 13 May 2026 16:10:14 +0300 Tomi Valkeinen wrote: > Drop write to SPICMR. It's unclear why the write is there, as SPI is not > supported in the driver, and it's mostly just writing zeroes to already > zero fields (reset defaults). None of the zero bits written disable > anything wrt. SPI. > > Signed-off-by: Tomi Valkeinen Comparing it with something out of tree where SPI is apparently working. It does not touch SPIMR, so this can clearly be dropped. So: Reviewed-by: Andreas Kemnade