From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D635A330666 for ; Fri, 19 Jun 2026 09:02:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781859770; cv=none; b=VhpNVe+quFEe+vGwHS8FeialRIHi87FWzeyEUCbp0O/GaGtghRsREeH6oEyWZPxbzxmGg4YwEqgQGR2k3KT1ltMBu1+gGIgutu+SkEhw+4AnnfvAdLFcbo+DDTjLOoAvnr0Fyxf1/EEcn6T71s4YJG9JX5+6/yyunlDuNmrnZ4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781859770; c=relaxed/simple; bh=WAEPHQ+jRtmNu7PXoTQbXWLS45pXclGNj35e6zmZ/fs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gkcDfY5Lu124twttcUjZ8kajEfwSV0SafEpt13H5H4z2BxkdAEf9nMcgFjfo0TzStyFOswmm60oHSXx8hm/PPvZSBrYFqNItTbcKFzRMMFX7AcfYCXOR+M2SGjbH+VNk2M/OfQF6Glouedp9kEphuDUx+/Trhh7Kto+1NfqIRwc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TTC+e2pV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TTC+e2pV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCE581F000E9; Fri, 19 Jun 2026 09:02:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781859769; bh=L/UWX2DkS/ddJGjbUZG7+7ErPCUjgISgjfYwtTtT4I8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=TTC+e2pVzgDlLdtyBBANkMIe8BveySYxCQCo2OYHVZJBwOufXeW60Ahnjj+loP30H /zKw2q2Rb+Zyp11OZLcMRbDx3biDHzz/IzYwKmgO6N2VsvE4u0DPBk7g0UcX/UESdA UeHgbd1pEVN2cFlCZFJPQqG4G0/esyJ9r9evjozj48M6W5i2offILFa0CThTuqgEnQ Ky5xQ7O+NgK/sOgUNYa3vmTR1wOkdYsh7iKEMWk3PWYFUap0VauQKRazdtZcrrWtJF kh/T6CJv6ZRk2k6a3EoU3rCEZgmmt0MNqm//vskF+XY3IxtFmhy1YpK28ROrZFx4h7 OmPfdE44NNaNQ== Date: Fri, 19 Jun 2026 10:02:46 +0100 From: Lee Jones To: Dmitry Torokhov Cc: Matti Vaittinen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: rohm: Factor out power button registration Message-ID: <20260619090246.GC2108533@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, 18 Jun 2026, Dmitry Torokhov wrote: > Factor out the power button registration logic using software nodes > from rohm-bd718x7 and rohm-bd71828 drivers into a shared module > rohm-pwrbutton. > > This reduces duplication and makes it easier to support other ROHM > PMICs with similar power button configurations. > > Suggested-by: Lee Jones > Assisted-by: Antigravity:gemini-3.5-flash > Signed-off-by: Dmitry Torokhov Quick drive-by nit: Drop the term 'mfd' from function names please. > --- > MAINTAINERS | 2 + > drivers/mfd/Kconfig | 6 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/rohm-bd71828.c | 84 ++------------------------ > drivers/mfd/rohm-bd718x7.c | 84 ++------------------------ > drivers/mfd/rohm-pwrbutton.c | 112 +++++++++++++++++++++++++++++++++++ > drivers/mfd/rohm-pwrbutton.h | 12 ++++ > 7 files changed, 141 insertions(+), 160 deletions(-) -- Lee Jones