From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C92B3BF69D for ; Fri, 19 Jun 2026 15:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781884489; cv=none; b=CIsWUGJiKMp4zfZVRRTqnclQ4vzZK0832ml7EFcSJJsq2HT9msXpWRJ9pErN4eeqdkU7EnoRvVxgIE2Gla25Uqf4AwqBBi5IDN+KUuIahDbB9DYRSmNLK0dbGuUrakSPZ5Qp/cgW7spvdeOgr6C2HDDemIvdUuT37OUnTP2s0R4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781884489; c=relaxed/simple; bh=jqdml72ES8Q33YJIgLdrIjKZqFWsiMnpb2lTPgX/P/Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=URh2SEv9EnCL3UC5uFN14be/lpkqzEv3PovOiHMwE4404vnYq83GydfFmZbV03w+JnG+yxKbnvrE3G3SmA99HfaF1YunLIaLhn2CZ+E9y5g1B12jAXbHvyW8tEmnouOl5e+k483fnU6VolWPTR68BL8L0daFEIit6k2tb8qsevw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf09.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8D7D7166999; Fri, 19 Jun 2026 15:54:34 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf09.hostedemail.com (Postfix) with ESMTPA id 130322002E; Fri, 19 Jun 2026 15:54:29 +0000 (UTC) Date: Fri, 19 Jun 2026 11:54:27 -0400 From: Steven Rostedt To: Linus Torvalds Cc: Yury Norov , LKML , Masami Hiramatsu , Mathieu Desnoyers , Ao Sun , David Carlier , Karl Mehltretter , Martin Kaiser , Pengpeng Hou , Qian-Yu Lin , Rik van Riel , Rosen Penev , Shuvam Pandey , Vineeth Pillai , Yash Suthar , Yu Peng Subject: Re: [GIT PULL] tracing: Updates for 7.2 Message-ID: <20260619115427.3f68a1e8@fedora> In-Reply-To: References: <20260616180122.57a3b426@fedora> <20260619081513.3e4a1fb0@fedora> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: x38mpb56sqdg4x9imfojkqj8kjox8icu X-Rspamd-Server: rspamout06 X-Rspamd-Queue-Id: 130322002E X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19cCCa4J4EmzKxcAJyNa2wZJqO5TrO/Jsc= X-HE-Tag: 1781884469-760078 X-HE-Meta: U2FsdGVkX18NStm+SXBoXVDLNTD6qt8RsNoK/OdzV6t739MVJC+s4wwO57EAxLL1mQOLMCunE78XAEGPF66FhucsnRlRhmZXCCGIbKadJ53Q0/22CKaiKsdGvMEcC08E5dleT21wYkL5Cd1lD7cv4dxWF6g7rpKJYYVUWkExZp6sU8LSaOqtFey+CDYynivHq/KwhrquBEz9i89Xee1vqv8i/ucOnywc15MeKTQVrheNEgrs3jUn29BcGp4pLXMzOd6lN5LZpd9tJu6XUmZrcWq/hnGPaDYrrdTOS+eq4LyiMWGu8mRAy9iwv948bSVpf5ttYLZOLEa01z2NsC3LWS9rC98CaHrvYFQnPdJb2t/uStgkjC2aczBwCrVaFzrD On Fri, 19 Jun 2026 07:35:15 -0700 Linus Torvalds wrote: > > Now, if the same was true for printk(), I'd happily split that into > some other header too. > > But it isn't. > > Because we live in reality. I'm talking about using it for debugging and not to print info. In fact, I try hard to *prevent* people keeping trace_printk() *in* the kernel code. If you add it, it triggers that nasty banner. The point of having it in kernel.h is for debugging purposes. That's probably why printk.h is also there too. Many others use the "shotgun" approach where they add trace_printk()s all over the place to track down a bug. Your patch now requires developers from remembering to add a #include in every file the touch. Or they may have to touch kernel.h triggering a full build as well. It moves burden from people who build the kernel and have to wait a little longer to developers that now need to remember to add includes that they didn't need to before! trace_printk() hardly ever changes, so it should not trigger these builds on changing kernels. The only reason it was changed this time was because the compilers now have more warnings about printk formats that required annotation to trace_printk(). As well as a clean up to remove a variable from a macro. When I said people use trace_printk() over printk() I meant I know several (including myself) the seldom ever use printk for debugging the kernel. If I need to see what's happening, I use trace_printk(). Because it can be used in any context without worrying about slowing down the system, and less likely to cause heissenbugs. -- Steve