From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910D1C2FF for ; Sun, 21 Jun 2026 05:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782020006; cv=none; b=DI7wjSwjZd1EvQQcNFNgUqbOQ2IjGmhFjC8v4U4F+iZVK1VFvNdD+7yER1dwGZ8k+J55d+4fjvQu8sc3ytGLIkOh6vhD1UrOKlBiy3t8ThpT51MOr1BR4mAt6lo/8pQzFpgmytKoziAUj5ftyBe06AY6fscYVwS2nH2VqUt9roI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782020006; c=relaxed/simple; bh=7IXgE6bKdUBoyITIytNaAB4oVQtOuc5MoAabCRbQPA8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uC76YS7mV+bMXl06dbYy5uN0Z2mHrkMFaxaYFoSkLmccZcfK4h3W3G05tsK1A5Fu4Q2WpLnCWklrKFtpCIPiaqMDNbBiRjWpAbOCzFVZImuaLMMQAUlNwgBLt/zp3dvoYwjE/R2hJ1M+F6WMS0+hx4BGy2NvsMe7loyogeWPuvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Lk0mQMbR; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FOGxVqlr; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lk0mQMbR"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FOGxVqlr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782020002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z3KhV9nn6ENAoii49nltbnc+k1VDXTF1dIVeYs6uUbM=; b=Lk0mQMbRoBvkTpa8SG1WpQt5lawBBFI3XtS/plzpsAgStT4SJCxcuZl1knmH8GfajzHFut d+9Mw1XzClqYrQg4zrx3t3tsmK2M9USWUQMNIGh0LMBj7gOjt6X+ih2MGTYqfAxVOx8Ogx GbdFoMVR2Tg5kwieXvzLKkHzPEwLHlE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-5668Nj8fNx-mA7Yy5-HLnA-1; Sun, 21 Jun 2026 01:33:21 -0400 X-MC-Unique: 5668Nj8fNx-mA7Yy5-HLnA-1 X-Mimecast-MFC-AGG-ID: 5668Nj8fNx-mA7Yy5-HLnA_1782020000 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-45efa2f7009so1714427f8f.3 for ; Sat, 20 Jun 2026 22:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782020000; x=1782624800; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z3KhV9nn6ENAoii49nltbnc+k1VDXTF1dIVeYs6uUbM=; b=FOGxVqlrSnbUh0sPCa3VXcjYnVxPEVstwJGgM1pdacQw2mPe5JDZuZCqpXGQJUuQYU JyzTJzuUefhW6xgm6svleK4bCApSUDgFlOF9WjszvyzaDBB6ER4lqrYHa0IWMaIP8v0F DQYKoRQLNvWSCEU2lfh/Hd4W48bUI1MKK/sfm1m00xiKXcZ7L5UVdXfxer1PFhymiQYw 7H2ZcTqC5ZyxX8yR0DzFqhqfjSpjaowjmPnFwdMdl7VpfcXyjDTczn0WW7Q+x01SZOrE /nVuBcf1q54tLEpDZa1Etl7ZAiDa04GzoMlalqeNazenByF02dsWYdNmwekk9RN4nIC7 a46w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782020000; x=1782624800; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z3KhV9nn6ENAoii49nltbnc+k1VDXTF1dIVeYs6uUbM=; b=YkahBZ0rFCUl1uPU0UyS3JF4L+3+rdmpXskoKWaguHyVdtuhKmgJ/l8g2Jv7rvRvNr xGcdnywyrJUYo7vsXnRGTKHhB2Uqt/eLzd21jAtd0LHiW/W7eCsphwDmI02UJ7pQAl9n MJjR9g1zJWwxNeuuY9GZEd4ti/Z2XEFV6K8Jm43fsAs9NRS9E1lG1Aa0oeIY98rRm0O/ QRyT+WVor8KcO6db3C77+OTZpSm8iLtfTHq1jbxI4y9GTMDF3q6UfK9CM3v4Ch0sGZ8X tjXqbDQt5nOFBMHmMhI3vu5DzmRHT4AEuyBJT5EF2Sl405nnH1esJ43vxyaYSnz+dgG9 0VqQ== X-Forwarded-Encrypted: i=1; AHgh+Rq4wS/NQW4DV4cr1tGIPU31mFabTg3LbpJTtUiVfOYw/iFFHbBFzKS1shsKF66ooCbFq8crpMqkWCl8aIE=@vger.kernel.org X-Gm-Message-State: AOJu0YzhQP11/jehBXKUbjdq7hpe14tLeFul7op/aPwPSxjlyzcs9Xqa GPuUlal11cg+AK7zfB/xfIWucc+kZfN4WejGGezaHENwuiqyuRE9IITvoyOH9ILUlvWry43gsCU YjeANisYnN+Q+sLU4966+3sxR5DL16CkErZ+bFGLYj66LxdFkuZru8vwPsHF9oJIOdQ== X-Gm-Gg: AfdE7clNHBM8JpSxvGj9zR40KgIMjbzhv7fYLkFHH1GmhOZPwbRT+XRw+CfCxptijUm 37KBx7oi+nLxVuRhtOsDxkT9kuR5lm3AxcHveVIJCxLLtibB0nolRgLEDFNGJCGE5wMTUKJ/g87 sN6NRi2pu5i8+1Oe+28kvG0wRJhk0NEcHPA7rO3pG6sRi3SHPk0b2fheRVej/lkG/v/bPw5kZ+s efg2bpRxa+218DA824ABoxnPkmx9eT3x+MjDMpswvF1UGVswpoE2zXhsfV6i0AhglYikzGzpkxT 9SueMCgXYO2GbDQcQyVAHMuVZsV6qkLUuMZodt5p3pqG+JShb2QC2ktzAAUpxJNEZHCOQgpQgYx OKdpxa+E7OJITuak8HflNYwt3XAa7aCHLb52ASrUOhg== X-Received: by 2002:a05:6000:1844:b0:460:25f3:b25a with SMTP id ffacd0b85a97d-46503176022mr16556269f8f.34.1782019999828; Sat, 20 Jun 2026 22:33:19 -0700 (PDT) X-Received: by 2002:a05:6000:1844:b0:460:25f3:b25a with SMTP id ffacd0b85a97d-46503176022mr16556229f8f.34.1782019999322; Sat, 20 Jun 2026 22:33:19 -0700 (PDT) Received: from redhat.com (bzq-79-177-155-162.red.bezeqint.net. [79.177.155.162]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4666678828dsm13793325f8f.19.2026.06.20.22.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2026 22:33:18 -0700 (PDT) Date: Sun, 21 Jun 2026 01:33:16 -0400 From: "Michael S. Tsirkin" To: hexlabsecurity@proton.me Cc: Herbert Xu , Jason Wang , Gonglei , virtualization@lists.linux.dev, Xuan Zhuo , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Eugenio =?iso-8859-1?Q?P=E9rez?= , "David S. Miller" Subject: Re: [PATCH] crypto: virtio - bound the device-reported akcipher result Message-ID: <20260621013215-mutt-send-email-mst@kernel.org> References: <20260620-b4-disp-27caeeac-v1-1-956e8f9c4f01@proton.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260620-b4-disp-27caeeac-v1-1-956e8f9c4f01@proton.me> On Sat, Jun 20, 2026 at 09:44:21PM -0500, Bryam Vargas via B4 Relay wrote: > From: Bryam Vargas > > length some kind of corruption here. > virtio_crypto_dataq_akcipher_callback() sets the result length from the > device-reported response length without bounding it to the destination > buffer, which was allocated for the original request length. > sg_copy_from_buffer() then reads that many bytes from the destination > buffer; a backend reporting a larger length over-reads adjacent kernel > heap into the caller's scatterlist (an out-of-bounds read). > > Clamp the reported length to the originally requested destination length. > A conforming device reports no more than that, so valid results are > unaffected. > > Fixes: a36bd0ad9fbf ("virtio-crypto: adjust dst_len at ops callback") > Cc: stable@vger.kernel.org > Signed-off-by: Bryam Vargas > --- > drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c > index d8d452cac391..64ea141f018c 100644 > --- a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c > +++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c > @@ -88,7 +88,8 @@ static void virtio_crypto_dataq_akcipher_callback(struct virtio_crypto_request * > } > > /* actual length may be less than dst buffer */ > - akcipher_req->dst_len = len - sizeof(vc_req->status); > + akcipher_req->dst_len = min_t(unsigned int, len - sizeof(vc_req->status), > + akcipher_req->dst_len); > sg_copy_from_buffer(akcipher_req->dst, sg_nents(akcipher_req->dst), > vc_akcipher_req->dst_buf, akcipher_req->dst_len); > virtio_crypto_akcipher_finalize_req(vc_akcipher_req, akcipher_req, error); > > --- > base-commit: 1a3746ccbb0a97bed3c06ccde6b880013b1dddc1 > change-id: 20260620-b4-disp-27caeeac-5b8b67962fdd > > Best regards, > -- > Bryam Vargas >