From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10347156661 for ; Sun, 21 Jun 2026 06:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782024265; cv=none; b=R7ZK/sBin3UYyKznjyUx2jmXAUC+CDL57pOhsAqV/85n1le3OSQPn/DoNXm5QBnmb9u4SgHjhBt4BSFkHlcWZVunVrmpHG3c2cR0ZRJR+ZvTC0R/NJn1kcsh0giP7DgGxNO+KABMkKSBU6ZoWTOFLSMJgpTSIeJduahQkOlIw2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782024265; c=relaxed/simple; bh=rHBzzHx9xYwSeRoS8evHF6O+1pvIG+XHptdpEg1NxKI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CRLr/I+4gg2uX0lEEua4oDtDPdPFNeqs2pbO8IPywo/70UE6vsWGZBLn2kFIFx8lcI04cE/kH/UYdp30fxNY+BsINpb1JTLzJv9OqLwGYKqzArkF3jXPrnbHH54m7ehBnyvca4WriHHHwSYReePP0/YKML27MIv5seDKhXIgRI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=FLaw2LHx; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="FLaw2LHx" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description; bh=6oECE9jL+0Of0IIsqRqun3AZRD0LlUULJUalfVIaTmI=; t=1782024264; x=1783233864; b=FLaw2LHxQZtpktLemX10mBc7WUyrP3kjlApekAdpzmXLXlOFvCMfsnhCFqBhbt5vTotcKVobvRI 8fGEQH4Bl4qYU3SYXGDjUF25T+d5t7NxFq28WPWBVt8Yu17mOkWUTjusrEgoWix7E1RmdUZK6IPEn LwLY4TT4nwf/U4kgGAnVbSWV4GvipzjqmeyE+EbLcWCgs/y5kPQ7Yff5Udh60/4eauqdpotGqolNW hlXf8WEbiEOh7mtCMeZh4R/rkzdn0Esla/zMF1V83Pk7DMr+e/PqpKON1oomLnwkhTIEBLrA4O7X/ /4wemZtmWuztXmzdYh1Iz1pSKwnbU6mLeqSA==; Date: Sun, 21 Jun 2026 08:41:50 +0200 From: Andreas Kemnade To: Tomi Valkeinen Cc: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson Subject: Re: [PATCH v3 05/13] drm/bridge: tc358762: Drop SPICMR write Message-ID: <20260621084150.6ea494ff@kemnade.info> In-Reply-To: <20260619082350.2ebc0cf7@kemnade.info> References: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> <20260513-tc358762-fixes-v3-5-6698b55008b9@ideasonboard.com> <20260619082350.2ebc0cf7@kemnade.info> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 19 Jun 2026 08:23:50 +0200 Andreas Kemnade wrote: > On Wed, 13 May 2026 16:10:14 +0300 > Tomi Valkeinen wrote: > > > Drop write to SPICMR. It's unclear why the write is there, as SPI is not > > supported in the driver, and it's mostly just writing zeroes to already > > zero fields (reset defaults). None of the zero bits written disable > > anything wrt. SPI. > > > > Signed-off-by: Tomi Valkeinen > > Comparing it with something out of tree where SPI is apparently working. > It does not touch SPIMR, > ok, looking what that code really does, it sets bit 1 called SPI_SEL_CS0, apparently in that register. But that belongs into an spi_init function. > so this can clearly be dropped. > So: > > Reviewed-by: Andreas Kemnade Regards, Andreas