From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0BBA29DB6C; Sun, 21 Jun 2026 15:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782057451; cv=none; b=u9UOKSkCoiy1dIZTgWdffJA9AcZsELWXrw5puGuxCdczjLIwUqS0JNAOldBjw93QhN1dg+ftIaTfoOkQ/R54O6i3Ct8wzF/9sqH+3wy1G9KyRXPFNUJjP9zkQB2tEPh2B/+ILV9fsMfQRtiaXFwSWos/KaIieXYgoT3sm4ajcTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782057451; c=relaxed/simple; bh=mWRBMPOj+A0Dbda9NUclV6Q5dHluzqrgiIFyccaZV5k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dt4qvmgSJeHCxGtkw2m/2wHUD5Yrbg95zF8UvR9lh2p7RfBgpg1WwVkOh60HcD2WsSo3AOwMltXKlpESOdUQccHUenZiJ5mWy5QEQv/c69Jec48pNEkbVwHVLzKV/T2o0y0yeKmZu6yt0Jnpg+VIOzswCl67MTs2peZN/yc5gbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q3daSta9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q3daSta9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB2361F00A3A; Sun, 21 Jun 2026 15:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782057450; bh=S9E1resee4yOjiPcdC+iBIVYYZYyLgqakgCWxq9ujB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Q3daSta9Gvsqg27Bg7drqaNWnxtu9fvMQ/DYJOrnkXVtYoikBNcljPpv7qHFQxuqA D052+zoys0obym5LqyxqvwV83D5IluzUqI3yNNWF9JAKEajQufPCe0mVebhgSF3fFw KM9iD6IQ7mAAbJDWE1FpKSNtckZ9uC/Uh6X7PX240b0PTEaUx0xwSh/YFjgF+SnGqO YKMUhQwBr28s7U3MbKtVqxckQ5nGk4BenJoIFQpTKXqSYxFpY8VmoOPJGjQ48X4oZy KPvmL3cmzXM5l3UoD04SYkKMSxB5eLatCw2xYGrEsdN4riHuSvcVD/beW76Expkw7D 6NMBwRF6oc2Bg== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v1.2 04/17] mm/damon/core: use damon_nr_accesses_mvsum() in __damos_valid_target() Date: Sun, 21 Jun 2026 08:57:00 -0700 Message-ID: <20260621155715.87932-5-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260621155715.87932-1-sj@kernel.org> References: <20260621155715.87932-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damon_nr_accesses_mvsum() returns a value same to nr_accesses_bp. Also the function is more simple and therefore more tolerant to errors. Execution of the function would be more expensive than the simple read of the field, but because the function is quite simple, the overhead should be negligible. Use it in __damos_valid_target() instead of the nr_accesses_bp. Signed-off-by: SeongJae Park --- mm/damon/core.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 191533685cf2f..8f845bf698b2d 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2125,10 +2125,11 @@ static noinline_for_stack void kdamond_tune_intervals(struct damon_ctx *c) damon_set_attrs(c, &new_attrs); } -static bool __damos_valid_target(struct damon_region *r, struct damos *s) +static bool __damos_valid_target(struct damon_region *r, struct damos *s, + struct damon_ctx *c) { unsigned long sz; - unsigned int nr_accesses = r->nr_accesses_bp / 10000; + unsigned int nr_accesses = damon_nr_accesses_mvsum(r, c); sz = damon_sz_region(r); return s->pattern.min_sz_region <= sz && @@ -2154,7 +2155,7 @@ static bool damos_quota_is_set(struct damos_quota *quota) static bool damos_valid_target(struct damon_ctx *c, struct damon_region *r, struct damos *s) { - bool ret = __damos_valid_target(r, s); + bool ret = __damos_valid_target(r, s, c); if (!ret || !damos_quota_is_set(&s->quota) || !c->ops.get_scheme_score) return ret; @@ -2740,7 +2741,7 @@ static phys_addr_t damos_calc_eligible_bytes(struct damon_ctx *c, damon_for_each_region(r, t) { phys_addr_t addr, end_addr; - if (!__damos_valid_target(r, s)) + if (!__damos_valid_target(r, s, c)) continue; /* Convert from core address units to physical bytes */ @@ -3029,7 +3030,7 @@ static void damos_adjust_quota(struct damon_ctx *c, struct damos *s) (DAMOS_MAX_SCORE + 1)); damon_for_each_target(t, c) { damon_for_each_region(r, t) { - if (!__damos_valid_target(r, s)) + if (!__damos_valid_target(r, s, c)) continue; if (damos_core_filter_out(c, t, r, s)) continue; -- 2.47.3