From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E42F3A48D5 for ; Mon, 22 Jun 2026 09:55:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782122159; cv=none; b=B1qqLxwJOLxm5Oy/JtCc9hIDl+IfW6N6iLcVnJee4FygSPtuZoAoFSVQV4pZcZjG1CyKypB/fRTeg9IsK5bb2gHICCmGKAnqdFXHd3ZeKIYdX3rsVTpe9PrXRW4vuKnOPtzyBsns9U6B5FPIf30XcsZYrvFqIsvworMB85hPLD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782122159; c=relaxed/simple; bh=8BETki/jQ5baBxbQcFwkgeSsOIXzQof1N3Fqfu96PVI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JLkPWXKXhs1CN5BtleuRlTg033PZO2x7HNruy7RqWPdazR8p8GYtw3ipHtBg3mxGBRsA8P3hjOGFycV7Q/x6f2FEXeCGo+4kOem7BR9GlZkZu7Wl7Bfr2S1b6B3jBTNzSj+HPxUGDIGykSo9cb6s9lMNV59Q0/2hJzYLbFJrzvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zuu8hF4n; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zuu8hF4n" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-462bb734793so2531097f8f.1 for ; Mon, 22 Jun 2026 02:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782122154; x=1782726954; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=P0E0JBlSRaUIEWVL2hII2Z9BSAc+EUsy9g19G1CKGLw=; b=Zuu8hF4nPp9nD2umAtReOwK9izswYY0MJIN6LZNNZcT+zXe49MtUUcNNAMHOPvP0Ty nUQmZqKS3LFIZei0V0G1Xcp4JIVuyZjmRBTEfnVK/CHOwhDIFld3qqrKzOegiaxqgapj SA5xFEPzXSqFV1vROPsqm+SgD6aD9l96DDFoR03lZoL9I9wtZGCEO4ekl8EuonHVv6ne So4+RsqLDKtX3dzJQou6Ayam5IxxNJA5FljormrbPKjxeOEP14QtQnq/lI8+rL/PXsAb Y1qRHjPKc/h5YSrBo+3XJmbASLDyBuijtulJ3zeEcKk+yUPSo2flaK+e5C9VxgUKWJdp iJtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782122154; x=1782726954; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=P0E0JBlSRaUIEWVL2hII2Z9BSAc+EUsy9g19G1CKGLw=; b=dKmROBsZYlP7yb9yapvCO0GQ2YOLs+d3nfGL79uykg5D/X27ivmc47u8/zRpBiuIYK qE5N0rEXj3Y1Yq9ONZhBSA05Y5OwCFAp/Lt3tZ8pykKDtM/KaxxCyNc9eWgVReQ26HaO KG3bFpY7rk8jQeDKaTRCnuqIh02Cx0MES76Uneq9HHT8/Q7979WAgH50xUdI1+4JkWS1 jU+nJo2nWJFbqoG5E2+8rAd6GNXtWyTIeKF5x9r915Chmq0RWCOccbHYlzIRfYf8qCfh PffT65o6zsHbUHoX0rhY+rL5p/HIlqhjwJKWhA4PQRTD4uROnp5UoLwDIv8wjWuWHC7b 5gZg== X-Forwarded-Encrypted: i=1; AFNElJ9qKmgj1vpo1rG/hDpZgotH4lOWI7f+Fp9iwgwFpCtd3GO/htDtxL2lYPxJqlcPqUCAfnCciIe/eOnuS2s=@vger.kernel.org X-Gm-Message-State: AOJu0YyWlTm3pBcgHvGtiGj11wDhk/9433PHWjw3Ktr5qM1pEZ/LR+dO ckoTOnFOxnygEiZnH6vKt9VvakXKxTdisZbksWw70rC7XAfyGeGXG0Hv X-Gm-Gg: AfdE7ckm8NHVPYbMf4fL+AMDs+xf0aqgyV+6d/Eoz/y2X2hkm5o8FbryoykFWIH4r2i y0MZ6trNb82Vq9+vXBUJMrenMmhUhK4zfdUDTD6B/tBGRAjmRrIwtUxrVX5bTpm9wv5wzBeAQES B2HhyLYrKw9PciFKKMceeZWwDKu+ngjIG13nTdnQyFui5D8yH3h4iv5ZS5drcgeJF8KluI+iaSB JSW+gs0k++vHDMGSAIBx2S+n7skX7u10mNKOLSS5nhK7bhvxg+gu2BRGxsGiNzv9Ssvsxfbv44V 7D69yZX9m/lsCDaHDq0T0vPc/wrhE0WYcG4sWe44mny2De+g58luvjBb+cLfipf/Q1yHU6J+7sZ mDX22KlT7EQ1d6tTqkC7SNhq6j2czcs+9lyZXBtF239mXUYOEYNhN+AgM1dWqGlBBAcm5Lmcl3E /Nf3US+LppBgiRSr7ZhWxbKZJHhDyLWRdGROKfcJA8lw6LU4Fu3duf8ezrQVnGZnFhwJvEegj3t EFxM5HgKNSAGo3WMp0NVSFZvhniSGcf6EuBnclB6uU06sYCFEMBLPQnEJJCDB+xTF4uRuQJtfzH O1MKIg40pQGh4/DD5mTRGVBFAIU76N2SN1BKgG2l57gOjASzguZALQU= X-Received: by 2002:a05:600c:6288:b0:490:e18f:d108 with SMTP id 5b1f17b1804b1-492490a7778mr137140915e9.19.1782122154243; Mon, 22 Jun 2026 02:55:54 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923fd15535sm313817465e9.3.2026.06.22.02.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 02:55:53 -0700 (PDT) Date: Mon, 22 Jun 2026 11:55:54 +0200 From: Joshua Crofts To: Petar Stepanovic Cc: Akhila Kavi , Prasad Bolisetty , Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Harshit Shah , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] iio: adc: add Axiado SARADC driver Message-ID: <20260622115554.000036a9@gmail.com> In-Reply-To: <20260622-axiado-ax3000-ax3005-saradc-v3-2-e57c7c7ae675@axiado.com> References: <20260622-axiado-ax3000-ax3005-saradc-v3-0-e57c7c7ae675@axiado.com> <20260622-axiado-ax3000-ax3005-saradc-v3-2-e57c7c7ae675@axiado.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 22 Jun 2026 00:47:28 -0700 Petar Stepanovic wrote: > Add support for the SARADC controller found on Axiado AX3000 and > AX3005 SoCs. > > The driver supports single-shot voltage reads through the IIO > subsystem. The number of available input channels is selected from > the SoC match data, allowing AX3000 and AX3005 variants to use the > same driver. > > Signed-off-by: Petar Stepanovic > --- > + info->clk_rate = clk_get_rate(info->clk); > + if (!info->clk_rate) > + return dev_err_probe(dev, -EINVAL, "invalid clock rate\n"); > + > + ret = devm_regulator_get_enable_read_voltage(dev, "vref"); > + if (ret < 0) > + return dev_err_probe(dev, info->vref_uV, > + "failed to get vref voltage\n"); Sashiko raised an issue that I've missed on previous reads - why are you using info->vref_uV in dev_err_probe()? The info struct is not zeroed out on initialization, which means that dev_err_probe will return a different value each time when read_voltage() fails. It was designed to accept the retval from whatever function we're checking. -- Kind regards CJD