From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v1.3 18/18] mm/damon: remove damon_region->nr_accesses_bp
Date: Mon, 22 Jun 2026 07:21:38 -0700 [thread overview]
Message-ID: <20260622142139.30269-19-sj@kernel.org> (raw)
In-Reply-To: <20260622142139.30269-1-sj@kernel.org>
No code touches damon_region->nr_accesses_bp field. Remove it.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/linux/damon.h | 10 ----------
mm/damon/core.c | 3 +--
2 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/include/linux/damon.h b/include/linux/damon.h
index a09ee8a09b5af..fc3d467dc2e34 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -47,8 +47,6 @@ struct damon_size_range {
* @ar: The address range of the region.
* @sampling_addr: Address of the sample for the next access check.
* @nr_accesses: Access frequency of this region.
- * @nr_accesses_bp: @nr_accesses in basis point (0.01%) that updated for
- * each sampling interval.
* @probe_hits: Number of probe-positive region samples.
* @list: List head for siblings.
* @age: Age of this region.
@@ -61,13 +59,6 @@ struct damon_size_range {
* not be done with direct access but with the helper function,
* damon_update_region_access_rate().
*
- * @nr_accesses_bp is another representation of @nr_accesses in basis point
- * (1 in 10,000) that updated for every &damon_attrs->sample_interval in a
- * manner similar to moving sum. By the algorithm, this value becomes
- * @nr_accesses * 10000 for every &struct damon_attrs->aggr_interval. This can
- * be used when the aggregation interval is too huge and therefore cannot wait
- * for it before getting the access monitoring results.
- *
* @age is initially zero, increased for each aggregation interval, and reset
* to zero again if the access frequency is significantly changed. If two
* regions are merged into a new region, both @nr_accesses and @age of the new
@@ -77,7 +68,6 @@ struct damon_region {
struct damon_addr_range ar;
unsigned long sampling_addr;
unsigned int nr_accesses;
- unsigned int nr_accesses_bp;
unsigned char probe_hits[DAMON_MAX_PROBES];
struct list_head list;
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 5b5375b035149..4f7954b383d18 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -3587,8 +3587,7 @@ static int kdamond_fn(void *data)
* aggregation, and make aggregation
* information reset for all regions. Then,
* following kdamond_reset_aggregated() call
- * will make the region information invalid,
- * particularly for ->nr_accesses_bp.
+ * will make the region information invalid.
*
* Reset ->next_aggregation_sis to avoid that.
* It will anyway correctly updated after this
--
2.47.3
prev parent reply other threads:[~2026-06-22 14:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 14:21 [RFC PATCH v1.3 00/18] mm/damon: optimize out nr_accesses_bp SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 01/18] mm/damon: introduce damon_nr_accesses_mvsum() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 02/18] mm/damon/tests/core-kunit: test damon_mvsum() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 03/18] mm/damon/core: always update ->last_nr_accesses for intervals change SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 04/18] mm/damon/core: handle unreset nr_accesses in damon_nr_accesses_mvsum() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 05/18] mm/damon/core: use damon_nr_accesses_mvsum() in __damos_valid_target() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 06/18] mm/damon/core: use damon_nr_accesses_mvsum() for damos region tracing SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 07/18] mm/damon/sysfs-schemes: use damon_nr_accesses_mvsum() for damo regions SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 08/18] mm/damon/core: remove damon_warn_fix_nr_accesses_corruption() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 09/18] mm/damon/core: remove damon_verify_reset_aggregated() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 10/18] mm/damon/core: remove damon_verify_merge_regions_of() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 11/18] mm/damon/tests/core-kunit: remove nr_accesses_bp setup and tests SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 12/18] selftests/damon/drgn_dump_damon_status: do not dump nr_accesses_bp SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 13/18] mm/damon/core: remove nr_accesses_bp setups and updates SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 14/18] mm/damon/core: remove attrs param from damon_update_region_access_rate() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 15/18] mm/damonn/paddr: remove attrs param from __damon_pa_check_access() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 16/18] mm/damon/vaddr: remove attrs param from __damon_va_check_access() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 17/18] mm/damon/core: remove damon_moving_sum() and its unit test SeongJae Park
2026-06-22 14:21 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622142139.30269-19-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox