From: Jakub Kicinski <kuba@kernel.org>
To: Shitalkumar Gandhi <shital.gandhi45@gmail.com>
Cc: Wells Lu <wellslutw@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Shitalkumar Gandhi <shitalkumar.gandhi@cambiumnetworks.com>
Subject: Re: [PATCH net v2 2/2] net: ethernet: sunplus: spl2sw: fix multiple of_node refcount leaks in probe
Date: Mon, 22 Jun 2026 15:36:22 -0700 [thread overview]
Message-ID: <20260622153622.6f9d4891@kernel.org> (raw)
In-Reply-To: <fe9cbe90adf4bb6fe5f2f7b7f267075e603d84cb.1781552725.git.shitalkumar.gandhi@cambiumnetworks.com>
On Tue, 16 Jun 2026 01:20:32 +0530 Shitalkumar Gandhi wrote:
> + struct device_node *eth_ports_np __free(device_node) = NULL;
Please don't use __free() in networking code
--
pw-bot: cr
next prev parent reply other threads:[~2026-06-22 22:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 19:50 [PATCH net v2 0/2] net: ethernet: sunplus: spl2sw: fix of_node refcount leaks Shitalkumar Gandhi
2026-06-15 19:50 ` [PATCH net v2 1/2] net: ethernet: sunplus: spl2sw: fix phy_node refcount leak in remove Shitalkumar Gandhi
2026-06-15 19:50 ` [PATCH net v2 2/2] net: ethernet: sunplus: spl2sw: fix multiple of_node refcount leaks in probe Shitalkumar Gandhi
2026-06-22 22:36 ` Jakub Kicinski [this message]
2026-06-19 0:56 ` [PATCH net v2 0/2] net: ethernet: sunplus: spl2sw: fix of_node refcount leaks Jakub Kicinski
2026-06-21 4:38 ` 呂芳騰
2026-06-21 20:22 ` Jakub Kicinski
2026-06-22 16:45 ` 呂芳騰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622153622.6f9d4891@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shital.gandhi45@gmail.com \
--cc=shitalkumar.gandhi@cambiumnetworks.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox