From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC08C175A85 for ; Mon, 22 Jun 2026 17:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782149645; cv=none; b=Gb4UORbonL3XvjY7iXO39BKyaTCu8MRqpRAv/GQXNY9BYCE+u0p9rbMj10rMSFOpRsjy5g3aVVenD2WOuq44EbZL6mZtK8dExNRZtfP3TQAcoVc+bJd8uGkhHbIBG1lN6GXDnbAT4OMxiElV+amKwVeD8BoWBD30WrwpYLSoB9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782149645; c=relaxed/simple; bh=UGtdfUu+IvCc/FTRQGqWK5e4uHvzgKdZIdr7QuD80uo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kDkWHpXEkF+jpeK/ikp72T+MY9s6GfM8H3CAt+CZ7JapRCGKACPFNicmTb21MsVqbsh1ucC48SYkLyTKujsQHlGP0qN8EDK+TXkF/GeJtBJVMx4Ijl4rk4JbWvbvhsQE8Rtt6GeoIWLdKO76UOjKsFM5J8pxoTqZo+lRlwjovm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o5rzdukn; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o5rzdukn" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8453bcf7276so2607280b3a.2 for ; Mon, 22 Jun 2026 10:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782149643; x=1782754443; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PjCDSDX5rdJBNz6pw3IrU3j4G9qavxrdCNiYTuZgJ2I=; b=o5rzduknYrxsB5iY7NM/RUSN54M0jmQWq6293sF8XCbKX6hy7xZ+8QOPFPIAoKoYCg e3UAjN93W9u+9XixCiTm/q3g4cSkl5kIZ5VtmUKORcDXnNMgg0j9NM0vGtPq3Fi8Knoe fBuKg82RIQqpCDnAs3XzhIxrMb2KKR//CgJP58Gb23BtdWGg6yCJhsiE/d1FgCAyb/uy 8GdZeS0OsgH/YiQDuYjyDL6A50qR4ejjxQFlGDuPRtQYNGzfhCLLIvkbyKas1UfjU0kO LvKkIbDcLs5zZ5+ymZSRghA7r61hP6I9VRc/xJZ+dIP4wgqDbfwliD/lpUvnJDvfQf+E ky2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782149643; x=1782754443; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PjCDSDX5rdJBNz6pw3IrU3j4G9qavxrdCNiYTuZgJ2I=; b=jv8zzOc8sSvqnGveqYrTGwgAUn4hWn74H8hhVh1cU7WFTr1wzWHP9LVmFg88fh06cn SXUIexq6kLwXQBLW8ADJ0WF/bJj8iTuky0EFXauHLjhMFMewMoBY34TQexjqxdY9yce/ 2X1ykFFWIaIqgbKRoiaQIbfLF//M36p3EVujeQHbcTz/8Oj2FqPAq2FFq3fzTboLs54H 3JFTO9QkCWdqEwsK8jVcI8LtazI0EQRW+iAtDhf2whcWVc/R3eOO+LQuJw2RctFF/7DI vwle8PAxvZiNH7cpRf+iYWEQnGx4heun+gIJlBW0KQvixFNGkzEJw9ZlDvHmZqddU0YI yyZQ== X-Forwarded-Encrypted: i=1; AFNElJ9ayaY1auCGRecVp6JrL0SFNCGwPTuS9ujAk10awYI8sKuDrhbdUVf3277o4JjApwbRUAr1nSUmpaGIGTg=@vger.kernel.org X-Gm-Message-State: AOJu0YyPgW9GG7fOT3Fwx+d0+wxOKveh1awhELilfjN+hezLn/kZetKW qvm2+YiE8msU9TlC0rmwf0+VL1azrj5G0MZOpYtid8TjoJBcRIYpu7c2 X-Gm-Gg: AfdE7cnCxmWqWqOD2O1mq4zvxu4YTmFBLugkr/jcmgU7smYsDOLfDAElHg18hAj+j2p PfrNpaq5xw0oaaCxjp3PdFmCBtv/n8bY3s6tjivHFWX5y4dE6S3Dc0G9EaYOTAwsUm+dfwxnbTR fBrgYbsfph/icvZDm3UHtYimofAjG5kti40RMSqGiNEr1K/lM9tA++VlogoTKwd3P5ehC6qjMQF 9CJIOFXWDf1ohC9Bt6PmEtuyv4JGhSYomhIpLswhfo7DsION8MUXoc90ylwJNGoDzapENeW0dHR EeZZvMRhJdLR+ezkm3xH+ygE4vHKQPwj/U44sOP9dxtx1AXAVMTIJ8ybJYMwWFDaBWon4YEDlgN TgJ6KKXlMLlc5lyiowY80cQfHQWGmor6hmO+VUnXAbxBiTTeyjsswtIJr7phZL6GjrZuO4AzcJn 3kklDaytwvTJEzldGt+AwLwmUdKXDtjGVY1RBdOvBaaQ== X-Received: by 2002:a05:6a00:2d8b:b0:845:44c7:2fdd with SMTP id d2e1a72fcca58-845508bb8camr17065797b3a.34.1782149642920; Mon, 22 Jun 2026 10:34:02 -0700 (PDT) Received: from localhost.localdomain ([49.207.234.96]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564ebd123sm7670753b3a.47.2026.06.22.10.33.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 22 Jun 2026 10:34:02 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org Cc: jacopo.mondi@ideasonboard.com, laurent.pinchart@ideasonboard.com, kieran.bingham+renesas@ideasonboard.com, mchehab@kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Geert Uytterhoeven , Magnus Damm Subject: [PATCH v3 3/4] media: renesas: rcar-core: Add missing media_entity_cleanup() Date: Mon, 22 Jun 2026 23:03:38 +0530 Message-ID: <20260622173334.60491-9-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260622173334.60491-6-birenpandya@gmail.com> References: <20260622173334.60491-6-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The probe error path and remove function are missing calls to media_entity_cleanup(). Add a dedicated err_entity label so the cleanup is only invoked when media_entity_pads_init() has actually succeeded. This ensures that the teardown logic properly mirrors initialization. Signed-off-by: Biren Pandya --- drivers/media/platform/renesas/rcar-vin/rcar-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c index c8d564aa1eba..5bae8eb0ee19 100644 --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c @@ -1211,7 +1211,7 @@ static int rcar_vin_probe(struct platform_device *pdev) ret = rvin_create_controls(vin); if (ret < 0) - goto err_id; + goto err_entity; switch (vin->info->model) { case RCAR_GEN3: @@ -1246,6 +1246,8 @@ static int rcar_vin_probe(struct platform_device *pdev) err_ctrl: rvin_free_controls(vin); +err_entity: + media_entity_cleanup(&vin->vdev.entity); err_id: rvin_id_put(vin); err_dma: @@ -1270,6 +1272,7 @@ static void rcar_vin_remove(struct platform_device *pdev) rvin_group_put(vin); rvin_free_controls(vin); + media_entity_cleanup(&vin->vdev.entity); rvin_id_put(vin); -- 2.50.1 (Apple Git-155)