From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7E4E2C181 for ; Tue, 23 Jun 2026 09:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782206999; cv=none; b=qBMoHd/0Lhr3SjpGrIzZdIUUpNBFfrC7j0G6/lVKVK8c2+2SrMpmimmp6bbU6PVURQWlY4XZNKw1NcUUpVxo7CTHG7KO8U8T1w5iRTpDixTXLTEGZQTonMjKI/Sjtu3fbxT4rhdf+Ar5eO66/smAA3gAh6BouKJUHtLR/asC5Jg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782206999; c=relaxed/simple; bh=6kIH1ANk3srlp8dDNIH1duVV9MTpe+sd+seqU3mPp5A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kfTOVMX+vYtx+IyIanFUAmdX/MkCjteJk4n9zp4dzQfzeXQcrXZ6tZXtO7YJP896ZEAS8cBoNHvAicVNPMVIEEaOGNHVr7cxXTuG5q0cABMDFYjtHrCNMsoV/y4DYKjhL/EZGPOxw7yfg6rujWtPYWfGXdrmUFT23ej0DUguvQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y9YazmGV; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y9YazmGV" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4631679f204so388224f8f.0 for ; Tue, 23 Jun 2026 02:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782206996; x=1782811796; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OAhVKTcglJuremrfImjaywPyVqu4aubOLdy7WaNPAJg=; b=Y9YazmGVEeLykjxhAkWcKLh/UnR7+AJyOVHELYjY7Kp4Lnl/GlA8ievUF57F0UjvW2 FcVcyc3X4n6nFUcfNNflcBUJ6FXQEIUjIBwGEMRgcM9mCvLrYcjfwhpQVK1R50pya/Nw zl2iTT4TjFA/SDv39iCdAh4kUvo7JuqERKiRsbEsnETvDmG126gjpjQbFB54d2YO5g8i JkOrgHK8OuODCq+/cWB/t66Z1AeQz4uy1Fonlbc/VsMLkE2mTUmczBjLv78dR13wcZpU iSFBBNfIFD+4ZGNz+zqLIeaZj0AgXqpTa5LMTZGaUv/JutcEe6hAnwe1Q3w/iIDH/Mzb cjYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782206996; x=1782811796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OAhVKTcglJuremrfImjaywPyVqu4aubOLdy7WaNPAJg=; b=Ozv5bDz8IemMBTnYpuxC2Uh/BC+dFId6aVDRxFegVBKoprYccfyM026aItfL/fUjCi RCWFzPAJdNoOmXayKJq49+oSKRjNTQTeg0TP6wRKK1KOFSbMd4iEbP+dxk2VQ7Tfwo74 AG8/WTxpNjqxt33eMhf1P3Y0P5D3zPElHHqoh64EIgjzkQX2Ik24XR6oZSa9j+t6jgn9 PGoBMnLh2jlP6/TjKDpUY86gYPzIhrHQYV0tS9aoy1YahHCQbfCKwcXUFL/qcc76VsSI RxPoBdoB9wyKFyKFoZxpan6HHp6FAzHPOawgmjIw3C6ceyWP0iXMBFIIntsWJ89nj55n mu6w== X-Forwarded-Encrypted: i=1; AHgh+RqusrYDMBRoWsWxRWRBxjo7gvGijm/PzvrAZYqF3UQ87ZrYTVrkENaUV3y5tl/KfBTXvjgDwEj60lrIdIs=@vger.kernel.org X-Gm-Message-State: AOJu0YyLUwKcFCXCldfgPgvfF9cT8QUWzn/g23KFA7dwHxaqG0umM8Vz /DH5/mCqy3r357ipIoN4N2PV8gZPXQqv14X/479m5j9JNugTsbYX/u2z X-Gm-Gg: AfdE7ckEpgAWbjPGrClpSpnzWlDYe4hHaFAOkVIFk5sjgjtP4nUt5gTOTvr5421UE7P SYomMA09xGU4FJ1yCk4tif1fK1ws4oPtWgDByzk2UzqA/JNzxVxEV8pbQ/ZSbU7a/FblLm9Jc4g ut6gCBraE7dcQRyGswTSrqt3aBgzVse0T7aGy7754PdGkuyfSgCDJVO1ERTDtO+pPkHg+UCdHZu IssdCuhEchMy12CpzysQJIihtW/8XAGKHW+u7d+0X8BS+GLB+IGVcpcHTo5zkT6XtNRg0rA9apj PYvbDsLLT4yfvOrFdj/d6sV95PdHGq7wgA2YfyPeYI6E/mDNYQIJSm9MksBfFRAxxFRqQuUSSxg K3n7K+pqT3eSHQlOjH47drdmhYd14T8HBM/UlbDL/KPPUwb+jWFUpv4i6WaNq0U3veUTM/luFQI v469ZhopGY1MX6iN+8dYmP6YtH7gjlFSFJ30HHuT3T66tPPf9HvWOaCIGGjLWJuI7gd2iIdJ8rQ cu4cLO4zpQ2sPLTFo738vmlzqTBqvLTe8dsZpu/20pE2RAUSjxv4IF7ZKVp6zJLxDoXhbbA6Z77 72F5r/ggd2l4cPQ96K814FMbxR1DATqa/XReEsR/g9WDHjPNjsRnQIY= X-Received: by 2002:a05:6000:2489:b0:461:a15a:4160 with SMTP id ffacd0b85a97d-46a7fd24e47mr4547391f8f.13.1782206996068; Tue, 23 Jun 2026 02:29:56 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46666c57a0esm31850073f8f.27.2026.06.23.02.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 02:29:55 -0700 (PDT) Date: Tue, 23 Jun 2026 11:29:53 +0200 From: Joshua Crofts To: Andy Shevchenko Cc: Jakub Szczudlo , linux-iio@vger.kernel.org, andy@kernel.org, antoniu.miclaus@analog.com, conor+dt@kernel.org, devicetree@vger.kernel.org, dlechner@baylibre.com, duje@dujemihanovic.xyz, jic23@kernel.org, jishnu.prakash@oss.qualcomm.com, jorge.marques@analog.com, krzk+dt@kernel.org, linusw@kernel.org, linux-kernel@vger.kernel.org, marcelo.schmitt@analog.com, mazziesaccount@gmail.com, mike.looijmans@topic.nl, nuno.sa@analog.com, robh@kernel.org, sakari.ailus@linux.intel.com, wens@kernel.org Subject: Re: [PATCH v4 1/3] iio: adc: Fix incorrect reading when datarate changed in single mode Message-ID: <20260623112953.000066cc@gmail.com> In-Reply-To: References: <20260622221550.374235-1-jakubszczudlo40@gmail.com> <20260622221550.374235-2-jakubszczudlo40@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 23 Jun 2026 12:16:39 +0300 Andy Shevchenko wrote: > > + return read_poll_timeout(ads1100_new_data_not_ready, data_ready, > > + !data_ready, wait_time, I'd actually be all for using `data_ready != 0`, to make the condition more readable. ... > > + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(&data->client->dev, pm); > > > + > > This blank line is not needed as they are coupled, but I don't know if we have > an agreed style in IIO for this. I'd be surprised if there was an agreed style, as there aren't any IIO drivers that use this specific macro (not in mainline at least). Additionally, might I suggest using `PM_RUNTIME_ACQUIRE_IF_ENABLED_AUTOSUSPEND` as it is more generic? -- Kind regards CJD