From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54B733D3480 for ; Tue, 23 Jun 2026 11:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782212415; cv=none; b=aLahizSV78f05+v7JhWK5axfCt3WeHzN+ngfcpCaN7dGdKxdAjGaIWQtiQgVTFllwDraRfaqtAvTjTgkqeXrecjOLcFJW9rE1dR78aQWa3/HpbQ6t4XMmHOcoZ1ZTL77/bDxy5i2Gp0v5BvEBCrRbElZ4S3a+kDFgIAA+gm+qkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782212415; c=relaxed/simple; bh=JtBRj9jn2+17pDsCSBhda0YXUBmEIAodCkZOMofrRlU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Txa12avBOzrb1AxGm9KxM8M4xraoWz1ighMhKjKZmixty8rLoL4U4F04JIzWQCBXXjeeiDQONY8wMTxOZrE/7kcmetRjpPEBQri2N/H9vaL6UoRBUGyLzJk45kJuE1ZSdAHs0zzUN3f+Z7T/ylvwwRKhFmdvwWKyejm8JwWGehw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=lNCk4oxP; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="lNCk4oxP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1782212412; bh=JtBRj9jn2+17pDsCSBhda0YXUBmEIAodCkZOMofrRlU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lNCk4oxPku+YLBYyPTi+JMg8hUJ+4mfPL7DG0MntH92NiMLEB1nfCPgdEJBuY+yUo pBLkYchqFNzRAfSUDzOkH/vxe0lfBmyUCbIjG7Z+dtihcI15nFK5Ptie2+yzH1Q1VM E3sz38+VfAicsWhtUCDzXey1yQ0UNAtVxSy4QMnhbWx1IaxeEPR0bzbrURvPtzWVq3 ZOafNjhaRAegBNwNtcJMRhn0gfwMUZO1SE3GqtRLWWFdnNauYkMKABk2HYZb23xGAJ fTyZpQOQjxUmYJ7xmhtekVklnzsvEEKVJOjIuJN5CSwLQHKmxhI2rCofRkauk3siQC 7nkYTF8vNuSww== Received: from fedora-2.home (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2540817E0853; Tue, 23 Jun 2026 13:00:12 +0200 (CEST) Date: Tue, 23 Jun 2026 13:00:05 +0200 From: Boris Brezillon To: Ben Dooks Cc: Rob Herring , Steven Price , =?UTF-8?B?QWRyacOhbg==?= Larumbe , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage Message-ID: <20260623130005.77a3d669@fedora-2.home> In-Reply-To: <20260623104617.768289-1-ben.dooks@codethink.co.uk> References: <20260623104617.768289-1-ben.dooks@codethink.co.uk> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 23 Jun 2026 11:46:17 +0100 Ben Dooks wrote: > The panfrost_transparent_hugepage variable is declared in panfrost_drv.h > but the panfrost_drv.c does not incldue this header. Fix the following > sparse warning by including panfrost_drv.h : > > drivers/gpu/drm/panfrost/panfrost_drv.c:958:6: warning: symbol 'panfrost_transparent_hugepage' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 784e36d72c2b..36cc2e67a308 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -21,6 +21,7 @@ > #include > > #include "panfrost_device.h" > +#include "panfrost_drv.h" > #include "panfrost_gem.h" > #include "panfrost_mmu.h" > #include "panfrost_job.h"