From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 938F53A16BD for ; Wed, 24 Jun 2026 10:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782295916; cv=none; b=nYXsSkDvQVTdMIJBSyTfnebf+C75iIg+Yf5fdeSpBs15Oo2MTNmzJsGJxJjvxTPvUW3nzv5QDl+1u/lUm1z5McG5+giThJsi7nG1YtHCNLNDlGGY9CCnQDvPqn44l4avSmIM4qVarBBFTfQth/hpqudqG/yPYV63EyZ1QTpGO2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782295916; c=relaxed/simple; bh=RjAh6wiNsClEbI71kFEJdR7kYGUmF9EpaxPPYzMb8XQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=u3tKVb5tldS2RVWXVndWlDxBsm6drzVunN8vaek6s8QNPinh4ge9A/ocBF6oYjlYNd2CI2zqaYEZo5Oj2/6eKaudiD8IDTjU8w4vsNdQwyu/Xlqoj0eMVycmctwIY5fqxb3Tl8PNVMmRVageKA/MBjFhZl93lhTWdbJH15oefJ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FajTkBPs; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FajTkBPs" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-492329c5514so3366805e9.1 for ; Wed, 24 Jun 2026 03:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782295914; x=1782900714; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YC2QMtKOaQEwM4fJDcgBWK5+8cNMR3gbSQC9QJtusS4=; b=FajTkBPsl+7xTwi4M7rHVC+8ZU5MOt8p5LpPtC1r9wnR2wGk7ka65VjIiFbotDCZvH us5nO4ki9fpdKRp7Y8nRC2w5F4G0jjBMA8jANu6MdCpdQRzNcIt+6r0hO9BqHP/SW3bp L2gXA5ghbQfDTA5oz+XnvdMlim1NhZee+ZCebbP8mrNxtAjLeGTrSNql/WHaO+1a98Zv 4dmUyX7SH5J8ce5ak6Cedm3rR3VyTGxq8P5bx/Cbnxbc+fTOjz8mkt5ztNT4L4ZE/zSK uvmWlY6HGCF5mqAsegpPsl1N+L602oacAVPIEgFtNDobdHRTcBG+gmPogn1kq3ZELvfs 9orw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782295914; x=1782900714; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YC2QMtKOaQEwM4fJDcgBWK5+8cNMR3gbSQC9QJtusS4=; b=sPaqNSFNjOuLjld0DI2QX7dxVzLgvp4sijDBlj/y3LU7AXvMQrbF/yA7XuwpfR0BLu R6YSnZtjSl305dTIkSULppd6c5UiX3xEwWSoVaJG9mqDd7EUjoXtPWlKlKE/NlPkfD9u DGvkcuhGDLsh1EoYsSaGJmyuIj+AUHFJ+kAsr2VjJdqGUeObgH1nOLxTnKcB0ufLy9OC 1pRB/AdMmZCZmeTo7dEYjYlHdC12t8BP5dvSdv8QfirL8W46pYgZOpmRQu+MC+F+AoLG vfovQc99XchQmmXS5OrIAcWjDnarIc6qyeqFYVMLAIaKFzeT05jthw0C/6Vp5zQQo+0R 6QXA== X-Gm-Message-State: AOJu0Yxyf39K5fLKYaMLYNeRbE59TAQTx09VNW6Soy1XmEJGHvzMVSli Q+NlQpFnzSssoRQU90o9u3xW++ZUhc+VzGfyZBLo43c2IQiIR5olD8C8 X-Gm-Gg: AfdE7ck5tSkHqOoZhC/Mx2wVWIILanRQGyItPaPVRk9+KzGRR3x0j1X3LyIdsfAyxrJ 1/1vT2qHF4uNaO+PMRxDpLIuPUC2Ij/htW/agjlA4qHiW4MPYeZI1oBxUHhpmDTAXd7KXQziuYc K3zh97N267E6ULVAlpmBClSxGhoY9QsDg1+PsLAwGhmRv7YB0aWspm8+iX5gubNwGeruNLPF9H5 HI0nb6lFu8aasuddT8N6v9Zm15vlkC/4Jvs/EFHqwLrMaXpj4QFjKi2lxGOIIrZ7cj1P9+0qmmq LLp1oD48gemm4T5P2YOoPb7a/N4T4LwmJtqpP37cCzFBlOwrKD4yUlfOr32eZYV0pwiuXlHwdlj b56/JLGIOTMhaebpuwAW9D59nAXvk3OOpyBjQNhosDu2K+SEY1srkQnDBniBNTfNYifR0xAAnPn ZGC4DZOhLOCqLTS2jr9mrOdG9uN/HiJ4i7qFf4k4JBMdAPZ96tAA== X-Received: by 2002:a05:600c:4443:b0:490:b4a8:e031 with SMTP id 5b1f17b1804b1-4925a09d65emr103410135e9.4.1782295913770; Wed, 24 Jun 2026 03:11:53 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49260915286sm105571575e9.1.2026.06.24.03.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 03:11:53 -0700 (PDT) Date: Wed, 24 Jun 2026 11:11:52 +0100 From: David Laight To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Linus Torvalds , Sebastian Andrzej Siewior , John Ogness , Thomas Gleixner , Peter Zijlstra , Julia Lawall , Yury Norov Subject: Re: [PATCH v3 2/2] tracing: Remove trace_printk.h from kernel.h Message-ID: <20260624111152.75476a46@pumpkin> In-Reply-To: <20260624081948.301578807@kernel.org> References: <20260624081806.120105649@kernel.org> <20260624081948.301578807@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Jun 2026 04:18:08 -0400 Steven Rostedt wrote: > From: Steven Rostedt > > There have been complaints about trace_printk.h causing more build time > for being in kernel.h. Move it out of kernel.h and place it in the headers > and C files that use it. > > Link: https://lore.kernel.org/all/CAHk-=wikCBeVFjVXiY4o-oepdbjAoir5+TcAgtL12c4u1TpZLQ@mail.gmail.com/ That is all about changes to the file causing everything to be rebuilt, not the contents of the file slowing down builds. The two are different. The part you are moving out of normal builds is just a few #defines. They won't have a significant effect on build times either. So there is no point splitting out trace_controls.h. David