The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
	kernel test robot <lkp@intel.com>,
	jpoimboe@kernel.org, llvm@lists.linux.dev,
	oe-kbuild-all@lists.linux.dev,
	Alex Deucher <alexander.deucher@amd.com>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: [linux-next:master 14191/14955] vmlinux.o: error: objtool: amdgpu_vm_handle_fault+0x186: sibling call from callable instruction with modified stack frame
Date: Wed, 24 Jun 2026 13:21:43 +0200	[thread overview]
Message-ID: <20260624112143.GG49529@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260624111611.GC48970@noisy.programming.kicks-ass.net>

On Wed, Jun 24, 2026 at 01:16:11PM +0200, Peter Zijlstra wrote:

> @@ -121,7 +110,8 @@ _label:									 \
>   * guaranteed that no GEM object is locked.
>   */
>  #define drm_exec_until_all_locked(exec)					\
> -	__drm_exec_until_all_locked(exec, __UNIQUE_ID(drm_exec))
> +	__drm_exec_retry: __maybe_unused;				\
> +	for (bool __drm_exec_loop __maybe_unused = true; drm_exec_cleanup(exec);)

An alternative would be something like:

	while (drm_exec_cleanup()) 				\
		if (0) {					\
		__drm_exec_retry: __maybe_unused;		\
			continue;				\
		} else

But that still breaks the multi case.

  reply	other threads:[~2026-06-24 11:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <202606232356.gwHMAJAW-lkp@intel.com>
2026-06-23 20:57 ` [linux-next:master 14191/14955] vmlinux.o: error: objtool: amdgpu_vm_handle_fault+0x186: sibling call from callable instruction with modified stack frame Mikhail Gavrilov
2026-06-24  9:28   ` Peter Zijlstra
2026-06-24  9:48     ` Christian König
2026-06-24 10:56       ` Peter Zijlstra
2026-06-24 11:04         ` Christian König
2026-06-24 11:16           ` Peter Zijlstra
2026-06-24 11:21             ` Peter Zijlstra [this message]
2026-06-24 12:36     ` Mikhail Gavrilov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260624112143.GG49529@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=alexander.deucher@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox