From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 903CF299A84 for ; Wed, 24 Jun 2026 12:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782303671; cv=none; b=nFV8KxKnjsOD0p1aJiLlq64/GGxOBeqG7Ii3Y6Li9MEgstb0c/eJqwxydAo2Az83Jt1gnugg8Sp0wh0BOmrawrm/cG2llgx4cd3OG/0xklxKH0jcgTsha51H9+PJ+XVNu3nLSm4Lkho+7C1kFI7qo5zZ9PPf/2Q6oTfke7m7q2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782303671; c=relaxed/simple; bh=djQ28RzLK2l1RcmBiz08DUVR2AZOLmOYQYIpeShLReQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=FkuZwPK6GZvXd9Vu98o89rs7CXtaFwfPxo9u1sdB/tiuWJVwmJ3GHF+R55n4Z9jccFS6lQgkmtD4nRKqvlXL8D42RXJrMJGz9C8Nf19SCuLhWFIx9+5+4eJAnSNfxOUR7DVVypBAu62IoCZUlkVBcyEiSkFXbzdxrdMyv5jSWKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PVcIAfNR; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PVcIAfNR" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-30bf8b2bd20so1986772eec.0 for ; Wed, 24 Jun 2026 05:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782303668; x=1782908468; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=PCCEK7VuVuV2gzTBEjxPJcsskC3ffOiRqHktjmux9bU=; b=PVcIAfNRB8BU9OduglBzWKMSjrdg0XhXT8lp6OnRB8ZJ9CN4jJdCH5zzbxOPkmvRGt /3GmQF7iQOyvTJ0ikG5xd5t/Lm0Gciwng1lqDBXswxZoV71L36KvjBSR3PIbSPUYFmi3 B/4DLgXVcIsAxrbhFTeKeL6VAmfYLtVYItaZKJEBEcruQt5DBBAloByCYeDNYKB/CoI/ AZes5yg9JMcbrkNdKXAOD6gNvSFycpqILbsUPpvEskXtFJn+f0D0xVCwfGVkc5qzVyw0 Dq8VKwM260pnu3iqEpm8xl06SbA/CTTk/Ps0I5lTyJ5d70uuVw9lgnJbYpzhztI59Uq+ aoVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782303668; x=1782908468; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PCCEK7VuVuV2gzTBEjxPJcsskC3ffOiRqHktjmux9bU=; b=Adso0MJVN1Zrpc3/0GTmyy1FCqvDUohYO+f4rySb2lY7r1KFTYsan+2DUwAWGMPnyg ngiHUEsChB++BAL/P4dFdhgzAQPZ3KaS9PHCxqpbuckfGEjU6b1HKi1NAVxwN0FRmY9/ 3jYW/NPxDPlHqvjA1LooPJMVmt4aeKRkNXUHd/Wt9tAMa90ohL0aMK4otCUyhEHvPf9+ xW1VQWQkR6irN4iPEcweqp39/J3YNSwYtwvPm7KuqDS9t1iDR3SCA0egt4UnQTkXs2Yx QyBcubmSa64GCgQCdZzhZyXfMwzEVVltHXbW7T4sKHMWy+4pD/3S4T/m8KDwrIOgR7Eh TgFA== X-Forwarded-Encrypted: i=1; AHgh+Ro5ZI0r3iQ0w0Mon9fhOLokSzPSix1AJp4D5QETJbzs3pTyGQBBp5IolwUh7A4t/XJcOoq2Raj15e7DxbM=@vger.kernel.org X-Gm-Message-State: AOJu0YxJGV2NYsxuzxuZ1QLxMjABSu+W1mOmVzEb8SbMGs5Sko0Ne0rE P60AZxuE4nOJ/mcBEMfkEd7kitrWtZAjTKluS4Efa6idVhs2Zuj4RPodL4tjh4l9 X-Gm-Gg: AfdE7clX4st0kCP0G2OIC/4wHy4hUzK2kmhjo4bft8sMV05sduqNSL1+M7Y1Kfz+8EZ C4ZunvthVC6W6I2JNtH0i4YFbi/lysaq6CjLVhC+QxIpe2QiR4srGQCARoAC+mFbU9eRe+Xw4Ke h4NIbvKmYaf3LoSQ+TyG7314OSfhyWoiBNSf2Zg1f0eaw29xzsxa1PeVu1DsjXHUWQWuBcjC8HP zimeWT2hBEM0KJ4p2lH1Kw7YGzts1MX0+JcWB4ze6pXku1AaC0900ruO9XfX8QpHLiHL9DwGrIQ bIPVchZ6cFj46HfPzWMosYPNy0Ze85JcGROR+pQQh2MphjYi+bmKLb8pg3NgqTicLkAUh54510X OBR2AvcOHtt/Nn2OlXk8IoRRtN2Wv9zCHY2zi2sm04WcrGCS0VzC98KXwy7EDF5dQAMuicYPcFY TlQr5ZW8Cc4A91xg== X-Received: by 2002:a05:7300:8ca2:b0:306:f474:7389 with SMTP id 5a478bee46e88-30c1dc28410mr13736349eec.25.1782303667499; Wed, 24 Jun 2026 05:21:07 -0700 (PDT) Received: from syednwaris ([2401:4900:1c89:6a0a:fb66:1536:7959:1b49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c44ec51b9sm15770583eec.29.2026.06.24.05.21.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 05:21:07 -0700 (PDT) Date: Wed, 24 Jun 2026 17:50:49 +0530 From: Syed Nayyar Waris To: wbg@kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, syednwaris@gmail.com Subject: [PATCH] isa: refactor code to remove nested blocks Message-ID: <20260624121027.GA79357@syednwaris> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Remove nested blocks in isa_bus_init() Suggested-by: William Breathitt Gray Signed-off-by: Syed Nayyar Waris --- drivers/base/isa.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/base/isa.c b/drivers/base/isa.c index 5887e4211f80..4e9f68080f39 100644 --- a/drivers/base/isa.c +++ b/drivers/base/isa.c @@ -166,14 +166,16 @@ static int __init isa_bus_init(void) int error; error = bus_register(&isa_bus_type); - if (!error) { - isa_bus = root_device_register("isa"); - if (IS_ERR(isa_bus)) { - error = PTR_ERR(isa_bus); - bus_unregister(&isa_bus_type); - } + if (error) + return error; + + isa_bus = root_device_register("isa"); + if (IS_ERR(isa_bus)) { + bus_unregister(&isa_bus_type); + return PTR_ERR(isa_bus); } - return error; + + return 0; } postcore_initcall(isa_bus_init); -- 2.25.1