From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f52.google.com (mail-yx1-f52.google.com [74.125.224.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 897D834040A for ; Wed, 24 Jun 2026 17:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782322551; cv=none; b=LaU15fWV8LPSDj2XCX0lid9TfXgfFx2QzLupLUtL03B2TWVFd/pbOtJ928nEOCd74lPR61LsGzgTVOsuVfyooVUSqDLmD9EcTQxEgjpswemUcdmN41FoEaiEoTRqelVLdpxOmwj70QO/8EPUP0iq0Pn12TC2WGmuH71U10C+7WQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782322551; c=relaxed/simple; bh=lShDo6KmHrMLmRbvhlrW3dXo03Fa+3MWRnnO5oQMOx0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D4Nb8tlK1E5Ll50qV1LDt/UhGzMcPLuKpQL40NntI0LFno+DCfn6VzgrHhxJnrg3scDU45uM+q3FzZRk0cIWE+Juf/eDTeh5RlIKqQTU3Af0B1zHWrdJA8nsRyBlqarhCxyeDkUZU+ShvrrJSlSbxTCV3EOwXh43WsvNoJWbtaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oQmdhnF8; arc=none smtp.client-ip=74.125.224.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oQmdhnF8" Received: by mail-yx1-f52.google.com with SMTP id 956f58d0204a3-662ccb916c5so1351154d50.1 for ; Wed, 24 Jun 2026 10:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782322549; x=1782927349; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zFT6JvsM9jjpX2DgE4I/pL9eGOn2zNfUrvWd9peQRMo=; b=oQmdhnF82F303bnro82jbNv9y1sV3zN8+amh55saXNHqWfxvusQtOYan2LNsUi5Czh 9CNgpVUkNcuTcrStWpvtjM/wbeeUmQHDAjstmSSagZqnLPejA7NWCQvPlA2dsf4Ui6zD KkG6btT6PxIuaLrSvRfjo8KRm0CrIthjFBhRyo/YxCOwwA7KBKZTT5NQWrIhwt0sA9P0 OvPn2deBGF3p0yorDxl74pK7Hxg4GwP1D5sV50VczsoNL2WYUWEEavvXso29SMinZkI1 ETh3xxL5pON1M8Gu0Eg53Gsb0rVl2wFvAqgctyPMAn0hQcnqA8ufyINHR58ddksAU3SY u9ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782322549; x=1782927349; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zFT6JvsM9jjpX2DgE4I/pL9eGOn2zNfUrvWd9peQRMo=; b=RBrncuN9TfB4Kn7kW6wQdIeeS03H6oQ6YpNVpfbOpQ01MZqdZjVOIxbR/EuzUorBYt qylPbo7/LprmOERSGYFrb4AfTV7H4fTngsgJbPq2h0krav4Vh2r61NhiYaA72z/NeNtY iTV/L8/oGNOZBL+Dy7vAFVnQD/GjeyI/A7CfLDwRFIzK31PHbolzUI2wfNqlyPV9R4NC H/XLkXKzzNeDwmngJxVBuVMYvqLxsm8NoMMR9M3gkHhX4M/nZVDivhZeAZu8mo+7boVa zYa1rB8KGojo1NvPvLQcSbN/WzZGqNIUZCM803LBUcxdFCH6TfjDPIHfh3tH+Nim1CMn 2Aqg== X-Forwarded-Encrypted: i=1; AHgh+RpzjPNwLe7o7wozFbBderS5XbWdqoFFn/cDGIBhps7tWssQqZ10TonLl9ulcgJMJlBvhtNf3XU/XtfEzxY=@vger.kernel.org X-Gm-Message-State: AOJu0YyENcyul8nlG9Bov/qRd4c5e7CUXr3/0M76hwE8Pnzu8qALjQGC 0JQfPTr1S6WmC8Qthk4MOvZd2fmaUnzx+IKmOkC8IUplj5yUTBkM/w70 X-Gm-Gg: AfdE7clLHiRyTDkxQl3C5/3jIsiNUo08JuZ1q/RpnYZXNPuRTnvYj+wAahD1owCtLbc 0O50AUIMRTezrXwGvvJx7iYr8fBpVOZRu15TWJqMTqY9xO4yMUnhjUv5+VXk2J1UYqfneYM15NI 82QA62yFU/T+h311RZ5Z7Ay1OVGCsKtQbuMFju9dIJEzJA8TQ5Hp4Eih/VQj3JABDQya1y9hwuf AJSOi5OW4SGiAhcIzhSYOjWgPX0Zp8LD3mTq0cxjvpB72EVAv8v0SfD7igj3SUGtoVTVl8q314d FHfbtMB1VB9xiiJpK1YAdJj/VCUQbvym38gVFdHmt3XQs7Fiy2wY2gtwh2/RpbLto6MjrsiWi/v oKfJka5ENXHFX3kSpDHWshZAAM5YLIzblVX7z9yh96EgXdypWIGQowt7YmbxTxhh5nxdk8QU3/b CHBDa3121jXxbT4jIdqU5rkI3Fnw== X-Received: by 2002:a05:690e:14c4:b0:660:9420:56c8 with SMTP id 956f58d0204a3-6636e446a7cmr3507957d50.17.1782322549507; Wed, 24 Jun 2026 10:35:49 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6647f3e8abfsm230159d50.0.2026.06.24.10.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 10:35:49 -0700 (PDT) From: Yousef Alhouseen To: Alexander Graf Cc: The AWS Nitro Enclaves Team , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Yousef Alhouseen Subject: [PATCH] virtio: nsm: fix raw ioctl copy error path Date: Wed, 24 Jun 2026 19:35:01 +0200 Message-ID: <20260624173501.4094-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit nsm_dev_ioctl() uses a common exit path which unlocks nsm->lock. A failed copy_from_user() reaches that path before the mutex is locked. Return -EFAULT directly for that pre-lock failure. Signed-off-by: Yousef Alhouseen --- drivers/misc/nsm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/nsm.c b/drivers/misc/nsm.c index ef7b32742..e39ff0071 100644 --- a/drivers/misc/nsm.c +++ b/drivers/misc/nsm.c @@ -365,9 +365,8 @@ static long nsm_dev_ioctl(struct file *file, unsigned int cmd, return -EINVAL; /* Copy user argument struct to kernel argument struct */ - r = -EFAULT; if (copy_from_user(&raw, argp, _IOC_SIZE(cmd))) - goto out; + return -EFAULT; mutex_lock(&nsm->lock); -- 2.54.0