From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E5803A838A; Thu, 25 Jun 2026 02:10:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782353442; cv=none; b=WyMzA1kb3h6lTCSNMvtylX513rY8LYsigC3T3R2wFEZjVNXenGczeNNiJW3+zuPNxdyZV4OyHh/VpauxEbJlJyRbXklhEYlQcH0ppa5QqJxYse2hQUf0acZYQVHRx1etvtJ+61Fo7cSF1p42AniCugY0qa81jTPmLEgvX0VJcMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782353442; c=relaxed/simple; bh=uxAqeyPjQ0tfnxnBVbhZaOPqYgpmeYZ9cUe4DB/rbt0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BAwrfZZLAtQDB2cuvE7JKp9dtP5VRJQpJQRoQCZ7zG0X3VDXkRsxnjylEgfs5eRGdSMOTPrusWUvy6NzObeLbcP4w8fYS/j/vZxanfvJLkua6vMWoSGFS9T5g/NByQyAR5rU0nxomNu2kznscc+oCCE4HlQ2fWwRwwIRytYr9Os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VVh6sl1Q; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VVh6sl1Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E4A11F000E9; Thu, 25 Jun 2026 02:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782353441; bh=44WIcoDZw9y50a9k0zd/sE64+MgyRy7AHjMamNR0HuI=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=VVh6sl1QaGYaFDNOh04tWgvdFWR2RbJOfmFMZSRtR6feKUeL3APwdhQEoej0Pra6C xwQ/wTKEe8H1O/H5tSOBuu1RqARx7GqD6/R5yFns/B/LNxxwZxKF8Zh+5gvBUaDUPv xJmOu+f+tnOa1mj0U4MCZF3CdD5KG4M53BncDAPKl0XOL7belMvLYvJuZzp0T5Iy+F r/2d87mAeDJAEEdU9fCV9XrOD77EPT7PI/8noe8R3fLqN180grOv7p0iGZ4VJIFzf9 P9G+TpQriYlCujsj0OPKLE2of2wVURspmD4xcC7PltG7V5iLNFy1/jlQJR5vBHKCRg 3nlnQWI6zr3hQ== Date: Wed, 24 Jun 2026 19:10:39 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , , Paolo Abeni , Alexei Lazar , Carolina Jubran , Leon Romanovsky , , , Mark Bloch , Saeed Mahameed , Gal Pressman Subject: Re: [PATCH net 2/3] net/mlx5e: Validate bandwidth for non-ETS traffic classes Message-ID: <20260624191039.4724950c@kernel.org> In-Reply-To: <20260622112925.624795-3-tariqt@nvidia.com> References: <20260622112925.624795-1-tariqt@nvidia.com> <20260622112925.624795-3-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 22 Jun 2026 14:29:24 +0300 Tariq Toukan wrote: > From: Alexei Lazar > > The IEEE 802.1Qaz standard defines that bandwidth allocation percentages > only apply to ETS traffic classes. > > Reject ETS configurations that specify non-zero bandwidth for traffic > classes. > > Fixes: 08fb1dacdd76 ("net/mlx5e: Support DCBNL IEEE ETS") > Signed-off-by: Alexei Lazar > Reviewed-by: Carolina Jubran > Signed-off-by: Tariq Toukan > --- > drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c b/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c > index 762f0a46c120..e4161603cdc0 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c > @@ -324,6 +324,17 @@ static int mlx5e_dbcnl_validate_ets(struct net_device *netdev, > } > } > > + /* Validate Non ETS BW */ > + for (i = 0; i < IEEE_8021QAZ_MAX_TCS; i++) { > + if (ets->tc_tsa[i] != IEEE_8021QAZ_TSA_ETS && > + ets->tc_tx_bw[i]) { > + netdev_err(netdev, > + "Failed to validate ETS: tc=%d BW is not 0 for non-ETS TC (tsa=%u, bw=%u)\n", > + i, ets->tc_tsa[i], ets->tc_tx_bw[i]); > + return -EINVAL; > + } > + } Can we pull this check out into the shared dcbnl handling? There seems to be zero mlx5 specific logic in this patch, and the motivation. > /* Validate Bandwidth Sum */ > for (i = 0; i < IEEE_8021QAZ_MAX_TCS; i++) { > if (ets->tc_tsa[i] == IEEE_8021QAZ_TSA_ETS) {