From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEDAF19C54E; Thu, 25 Jun 2026 02:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782354127; cv=none; b=Ww2vG61Jcja/1CEXIqUrnuSKlu8hAEw1YHEkR5FEQhHkyGywekGIZ+tAFuzKsYAoW4Va/sbV9+f0y+VV5dSrG9TdVFKWqF4+bdnAj3dFn7xJoFOSH/n+N0Dt0/7fsrq+fZxHxc17giW/b3ZcViPO7H3AmiBJ1+6Bt6ABg0dkznY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782354127; c=relaxed/simple; bh=mrCD9REILvQ7ytkuNxk1sAWwsznOhzIhvtqZMRthRkA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KcZSS94YN3GCNclWDVrWr3a/9zceOhFvkRi+6L6MV/d15TbM1vhM7/CQ0jd37XWOXRSuGpZD1jf6B5QTMwTHBCWSemSyxLuny6BixUz1oU1lu8/S8XmQl+1HlompDGGM4Kl+UnkzsOhyjZsME7DlZiG0exifZrh6xRkb76eYHBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HiOavYNd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HiOavYNd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE40A1F000E9; Thu, 25 Jun 2026 02:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782354126; bh=UlrC4XUDtorWQW364JN0VeT9+sVnJidBJZvQBFd/jWU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=HiOavYNdbdkx11uI3Z7iAu3Qr+Vw+lNFKBH5kxQwAHLtGi8sTYQFSblscjPerahV8 3SXc/H+XSsYx1QjjkBQHPtR0TOS/H7pdRKXl9va4pzL60yYe9X6oDu8VIpy5VzmIhl oeG8ZSGjblxHCO6ixyCLeGbenNyIKRcA4sFj04cqHth2B6vUcuW5ozkPtax89wo0W9 J69L2VeRA5/9TcOwUMS+Qbff5CiZKPWH6Ip8JydeUXavGLwDx7Bqf5f3FUWJzIafrG vpA6AE+Zz65Bj+JmhZWhZHRRlOAfN1JbjPPcsI8uUs74hlPbVJCJF0l1qTQ70hwkRc 2sx0qwAn3VAfg== Date: Wed, 24 Jun 2026 19:22:05 -0700 From: Jakub Kicinski To: Maxime Chevallier Cc: Ben Dooks , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: fix missed le32_to_cpu() Message-ID: <20260624192205.4485cd61@kernel.org> In-Reply-To: References: <20260622143707.497198-1-ben.dooks@codethink.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 22 Jun 2026 19:51:39 +0200 Maxime Chevallier wrote: > Hi Ben, >=20 > On 6/22/26 16:37, Ben Dooks wrote: > > The print in ndesc_display_ring() sends the des2 and des3 > > to the pr_info() without passing them through the relevant > > conversion to cpu order. > >=20 > > Fix the (prototype) sparse warnings by using le32_to_cpu(): > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17: warning: incorr= ect type in argument 6 (different base types) > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17: expected uns= igned int > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17: got restrict= ed __le32 [usertype] des2 > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17: warning: incorr= ect type in argument 7 (different base types) > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17: expected uns= igned int > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17: got restrict= ed __le32 [usertype] des3 > >=20 > > Signed-off-by: Ben Dooks =20 >=20 > I agree on the principle, but this isn't a fix so this'll have to wait > until net-next re-opens :) Humpf, why are we not seeing this on x86 allmodconfig ? =F0=9F=A4=94=EF=B8= =8F $ make C=3D1 W=3D1 drivers/net/ethernet/stmicro/stmmac/norm_desc.o=20 DESCEND objtool CC [M] drivers/net/ethernet/stmicro/stmmac/norm_desc.o CHECK drivers/net/ethernet/stmicro/stmmac/norm_desc.c $