The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Guopeng Zhang <guopeng.zhang@linux.dev>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Guopeng Zhang" <zhangguopeng@kylinos.cn>,
	"Tao Cui" <cui.tao@linux.dev>
Subject: Re: [PATCH] cgroup: Use READ_ONCE() for task->flags in task_css_set_check()
Date: Wed, 24 Jun 2026 10:26:44 -1000	[thread overview]
Message-ID: <20260624202644.877fae40488c@kernel.org> (raw)
In-Reply-To: <20260623022946.525885-1-guopeng.zhang@linux.dev>

On Tue, Jun 23, 2026 at 10:29:46AM +0800, Guopeng Zhang wrote:
> -		((task)->flags & PF_EXITING) || (__c))
> +		(READ_ONCE((task)->flags) & PF_EXITING) || (__c))

This only feeds the CONFIG_PROVE_RCU lockdep predicate, so it's a
diagnostic-only read. tools/memory-model/Documentation/access-marking.txt
recommends data_race() over READ_ONCE() for those:

	(data_race((task)->flags) & PF_EXITING) || (__c))

Please update the changelog to match.

Thanks.

      parent reply	other threads:[~2026-06-24 20:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23  2:29 [PATCH] cgroup: Use READ_ONCE() for task->flags in task_css_set_check() Guopeng Zhang
2026-06-23  5:58 ` Tao Cui
2026-06-24 20:26 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260624202644.877fae40488c@kernel.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=cui.tao@linux.dev \
    --cc=guopeng.zhang@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=zhangguopeng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox