From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10C783BF680 for ; Thu, 25 Jun 2026 07:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782373192; cv=none; b=okCMP+Qw0pAOtmduOTvUIU5gyJDxZSU/xvRqPj4LtTlwCemBVCAomOzolcJHJGaB0dqacn6ySQm0Pp4yen2P1ZhT1+8Y0sc3AHA92TGf64KEMAPyjrzlqToej5/PLGml3l3OaGD7WBng5MaPpbkMw0ICaCO3vg6Cftxpj8MkTcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782373192; c=relaxed/simple; bh=HVWfHSv6sWWrNi0GJ9+rRIz33ipIkv0aKeIjjCwKQ54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OTmUw4PVeyA43WvX6/0RiWgdx7NabSqhFHcxk0pzVE2Z71544PTInEfoTNXaKPMrVpeS3u7nMryKy0mVbmnz2s1M6YyHdBeNzuWXqLD3HTWZ4/QaFxWh7StOIAl4VIUOEHxTxbmMr2zUHgje+DLJwgSHvXKOUKTRDhuvRywgEU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ftIouGIb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ftIouGIb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A99C51F00A3A; Thu, 25 Jun 2026 07:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782373190; bh=s+nN8YPY6FvgX/MyAFKnpv3UfsMso7OqDwdTVU5IpME=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ftIouGIbjylri8Kvfke8oEPPfNhoHjEMCy1g0bISWEG95ICf/t2wZYfadI4Vn9gAm 5JcSDQpIvloVh9UoBjK+2vKo5jZSo+HOUc1qtgOL37dKIFzo5fNEy7IBw+VsKTfxVH l6Wc8vfUY0cr8XxjqYvUxdbg3D5gpQuEK/OVOk0hEiVAJ4bs1/4ykdtgjAnHwgsYYW e9v6Gv5EmZGsZI/Ne0ahYegl8UcojPMQ7fwgbF0WWEzeDnqdgoIaM9T87b/K/Yc/O2 0Y+GHaYEZrhHQHXzsWbwvUJSoAtDW13+NDNiMpjcIZahgK7Er5iOfQyFtHcwix3Zu6 xfXlbau9hhrGw== From: Mike Rapoport To: linux-mm@kvack.org Cc: Andrew Morton , David Hildenbrand , Mike Rapoport , Taku Izumi , Wei Yang , Yuan Liu , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] mm/mm_init: don't overlap NORMAL and MOVABLE zones with kernelcore=mirror Date: Thu, 25 Jun 2026 10:39:39 +0300 Message-ID: <20260625073941.145014-2-rppt@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260625073941.145014-1-rppt@kernel.org> References: <20260625073941.145014-1-rppt@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Mike Rapoport (Microsoft)" When kernelcore or movablecore kernel parameters define size of the NORMAL and MOVABLE zones as percents of the total memory or by absolute value, ZONE_NORMAL is clamped at the beginning of ZONE_MOVABLE. However, when kernelcore=mirror the ZONE_NORMAL span is not changed but rather pages from ZONE_MOVABLE counted as absent in ZONE_NORMAL. Make the behaviour of kernelcore= parameter uniform and treat mirror just as another way to size the zones. Co-developed-by: Wei Yang Signed-off-by: Wei Yang Signed-off-by: Mike Rapoport (Microsoft) --- mm/mm_init.c | 36 +++--------------------------------- 1 file changed, 3 insertions(+), 33 deletions(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index f9f8e1af921c..dce9dc9f2302 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -1159,9 +1159,8 @@ static void __init adjust_zone_range_for_zone_movable(int nid, arch_zone_highest_possible_pfn[movable_zone]); /* Adjust for ZONE_MOVABLE starting within this range */ - } else if (!mirrored_kernelcore && - *zone_start_pfn < zone_movable_pfn[nid] && - *zone_end_pfn > zone_movable_pfn[nid]) { + } else if (*zone_start_pfn < zone_movable_pfn[nid] && + *zone_end_pfn > zone_movable_pfn[nid]) { *zone_end_pfn = zone_movable_pfn[nid]; /* Check if this whole range is within ZONE_MOVABLE */ @@ -1209,40 +1208,11 @@ static unsigned long __init zone_absent_pages_in_node(int nid, unsigned long zone_start_pfn, unsigned long zone_end_pfn) { - unsigned long nr_absent; - /* zone is empty, we don't have any absent pages */ if (zone_start_pfn == zone_end_pfn) return 0; - nr_absent = __absent_pages_in_range(nid, zone_start_pfn, zone_end_pfn); - - /* - * ZONE_MOVABLE handling. - * Treat pages to be ZONE_MOVABLE in ZONE_NORMAL as absent pages - * and vice versa. - */ - if (mirrored_kernelcore && zone_movable_pfn[nid]) { - unsigned long start_pfn, end_pfn; - struct memblock_region *r; - - for_each_mem_region(r) { - start_pfn = clamp(memblock_region_memory_base_pfn(r), - zone_start_pfn, zone_end_pfn); - end_pfn = clamp(memblock_region_memory_end_pfn(r), - zone_start_pfn, zone_end_pfn); - - if (zone_type == ZONE_MOVABLE && - memblock_is_mirror(r)) - nr_absent += end_pfn - start_pfn; - - if (zone_type == ZONE_NORMAL && - !memblock_is_mirror(r)) - nr_absent += end_pfn - start_pfn; - } - } - - return nr_absent; + return __absent_pages_in_range(nid, zone_start_pfn, zone_end_pfn); } /* -- 2.53.0