From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93FCC26F2BE;
	Thu, 25 Jun 2026 15:50:53 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1782402654; cv=none; b=QpDjDT876kiCnJRxCwG8nEMt2Y8Ijoe74t9q5PHPLbRvQQq7YGXz2Q1R9mALbu5I9EHwJoIgZRJevFQd4wBaJtUEI66uI+CZhFo8Y6noRpC3k02R8DN7XmTVKGKh3GfV0ROAiIGEXcelauTxW/2v/ZE5Kxe+x0LxAInqy/9X4pE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1782402654; c=relaxed/simple;
	bh=Xua+NYnaSH1l9Ao5um1gafGnnKxCsTFB/0paNbk8NsM=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=LHj7aSFGuuFz/s0NQdaNIQK2Z91S4fchQOlwOo0ATezf+90v7W684PgGc7VdP+2yX35w8OAA1ewpTxUgJygMO8usCCOmx63GbXBUEQ07KLhoE1Kc2h66/bCvsJGkQ6rImAK4QlEqswrBjv5q6k8KS6XW4xY6Q5RLcbDTiscspno=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cxirriyr; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cxirriyr"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAE541F000E9;
	Thu, 25 Jun 2026 15:50:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1782402653;
	bh=Xua+NYnaSH1l9Ao5um1gafGnnKxCsTFB/0paNbk8NsM=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References;
	b=Cxirriyrvfzx7E0buS5oxIjptsE0CR/KpFW4dqc8gyNNYUdg262XC2BJhKNKLihRI
	 OGd19d79+HUy10js8yZh/gNBHplpX61lAQVr6d5XX6G+F+nobcS8ILfzr3a+ySNK2Z
	 GFrTcshoDAzn1er3KdptdzgUCf6AhqhGDCh1FaasDOwxlYUiqLOS5nWKgVbRnA0AK2
	 DBPq6WXiHntmjC76Ej90fakYfUN8PtHl24C25eeNd5iDllr7HET2ilyrBrlzgFI6Nq
	 TixuiATHMDzL7vp5QcPX+pb2uUOPO4hzSD2KzGobmjOvYgcL+7ENGZxzIx1i+vkVjg
	 vrRexTv+avy7w==
Date: Thu, 25 Jun 2026 08:50:52 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Haoxiang Li <haoxiang_li2024@163.com>
Cc: sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
 hkelam@marvell.com, sbhatta@marvell.com, andrew+netdev@lunn.ch,
 davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
 horms@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 <nshettyj@marvell.com>, <rkannoth@marvell.com>
Subject: Re: [PATCH] octeontx2-af: Free BPID bitmap on setup failure
Message-ID: <20260625085052.031371ae@kernel.org>
In-Reply-To: <20260623114316.2182271-1-haoxiang_li2024@163.com>
References: <20260623114316.2182271-1-haoxiang_li2024@163.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 23 Jun 2026 19:43:16 +0800 Haoxiang Li wrote:
> nix_setup_bpids() allocates bp->bpids with rvu_alloc_bitmap(), which uses
> a plain kcalloc(). If any of the following devm_kcalloc() allocations for
> the BPID mapping arrays fails, the function returns without freeing the
> bitmap. Free the BPID bitmap before returning from those error paths.

Marvell, you are actively working on this driver but review none of the
patches posted by others. This is your last warning, please, you have to
start reviewing the fixes.