From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82F9C3DFC94 for ; Thu, 25 Jun 2026 12:02:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782388940; cv=none; b=WiKkunHUWjQCYcMZCPZxuORP+lpXJmdHPly2xNcBVj9yoFJtwKp05Oypm1T4qrepDhdxrRDP9TKTrgS1ku/AwCe6OngSdj6jgbUi9enqBNWccr8uUVqszG1c3Mbuzmg1WDjkW9Aro1pT/oWZpcnmi+AIAr2xdj3pnuewxD5k0h4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782388940; c=relaxed/simple; bh=Q05YsIhVeGmm89QKP7QA6bQksyHxTT6lpOk5ndyiSTY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rqNVvtRlWsB2wbwCwa6pZ4euMJoWBM5RuHaJVAZRj94L8/fMZX/SKzBWeuVbC24Vr6CgRay2upxDEV5BHbNIUB8zxzgGzKwXGgC/fN0Fejuvv5zqDHoP6VJdcaw7uyg2ZLkKWksNPslqePdCflxWpocJE11oBrZq0VFPc6E9eL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RfxJxfGc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RfxJxfGc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 189F91F00A3A; Thu, 25 Jun 2026 12:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782388938; bh=K8q43MUbMciGYSCM6pecJXC9Q62aTtfjPzj3NVC1XiM=; h=From:To:Cc:Subject:Date; b=RfxJxfGc8Dr2YTuyv8e03Wa5JGYpaDXNnIqEDOT4Y6eQ8ridWy1NO8KMa+OTX+QdX 4PFj5g890cc+9EiFg6yGgNKJ8IYFVZJQL5T07RVt+Qum1Q1jbW5RGGzq3b5jJ/RE+n dvF5i4rgfKaa8Q9PFo62A8UO7YQhCX+PUk+rDoPpaK0nI9WGDkP5GJPBp1ochskNJP EPlpGwYwzE8Q1/R2SP1wPnWeOLCJ4NSRnw9hmBUift71dTb+kLqZ/MltSxqEmdvLU0 /srxhRbgrCvBFF48BOZLYM1VK5OE6nQa2XUZrRvZcr4s3mu76JBT+hqgDjmEzWHpBm Oi4KWWIgCLwmw== From: Philipp Stanner To: Matthew Brost , Danilo Krummrich , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/sched: Remove useless BUG_ON() Date: Thu, 25 Jun 2026 14:01:52 +0200 Message-ID: <20260625120151.1757146-2-phasta@kernel.org> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit BUG_ON() should not be used anymore since it crashes the entire kernel. Its remaining usage is in drm_sched_job_arm() to check the entity pointer. If that pointer is NULL, however, the problem will become visible through a respective NULL pointer exception anyways. There is no advantage in crashing the kernel as a whole. Remove the BUG_ON(). Signed-off-by: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index d2ca01b31ee4..4e1b6e79ae19 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -637,7 +637,6 @@ void drm_sched_job_arm(struct drm_sched_job *job) struct drm_gpu_scheduler *sched; struct drm_sched_entity *entity = job->entity; - BUG_ON(!entity); drm_sched_entity_select_rq(entity); sched = container_of(entity->rq, typeof(*sched), rq); -- 2.54.0