From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31E6923909F for ; Thu, 25 Jun 2026 12:43:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782391415; cv=none; b=baAHDOz+BeVWqC1pU/oji6XIta5042vH/fPdklT/MD/aqGSwUBEWQFazy/4WDs75Drtx2x6IKAbUoPi9Ckoad/xSbhyxpyOBOmUjfFLE4D4NGdeQk1k4l5YtE/FGoQeCOfKR7i5Zl9mpMwXdsZbtLvU6ZcFrkDMGqP+/OIC3Zm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782391415; c=relaxed/simple; bh=jdpmD6iVy3FAIMitjzPlLAWE1W7zO//hEsmY+/wCHto=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=duIaRjAAKzPrPftYW73mRms/7ZYpqOCDoxxIdr01sz6QAB/qCmKnMaDddSUQt1eqo9q7WqLhBJCNgvRTi98lHmg03llF3s1Af9QvRfJCgWqCfgwQnRySexiMZYU4DkmqoCCoCNSZIriRFDb6R7d3zZ1BhOfHHiOUDv3ppDg94jA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hxrFOPME; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hxrFOPME" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-46dcb6e55c6so638996f8f.2 for ; Thu, 25 Jun 2026 05:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782391413; x=1782996213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=a66eo69NOE+n4s902wAJueSdPmo/jdek0/gyrvoE+0k=; b=hxrFOPMEdBnXaEvXcXlNAxMjnD/2oe+/Z42cyy6WdtoC2B1k+K3KgOpgIHPBPlp8W/ uOQFMJCRiGfCGykNsa8yEnBu3jBY6CNvafEG3JPksrAdgQFnyu2ZdGd+e4ogLuyhtDsh B2uL2WT9C25YPxd0r43Piy7dTIPCGsdVA3D+KRi1xJdo/CH0mjv9dmGlcQIwH8Q/et5R /iT8leUoQsvgl75T3vRnMrwcy4yMiarLwI1cwWZMCtGP6nEeHPyQMOl6wjpSsGsBMjjb ybTUI+Zoh9wLodNhz6Pb2CznDdydrgkbGPGvBJK+Wach+D1DhTKqu77zq+4zn/6rT9IT rR4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782391413; x=1782996213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=a66eo69NOE+n4s902wAJueSdPmo/jdek0/gyrvoE+0k=; b=Io/a8GXFHzzZNSJKp8RJWm9z1bPavKVyilEjYlxVCUljFbrquNPx51Z1t0+/K/AtRE iD1iOLEfIDCzvPgnzBvVHcwWgAIhfafFsgKf8GjFvIzdObVurbqdQVrSa47weHoq+TMS QV3I0e+7SbER1lxWf6CwFux8E7yzX7fAMZIU8O7gCU655Wh+45Jz1TFrOERbF2jh8d2r 9+9d/RLnr5EjEmQdE/0drwvPlotwKjnbHS+tc17mSV1KYSL8taIeig0+lOwUs/TSxw5t qd3NEFUn5Tii7hIVBfyDILFQXo0Pg5pzeoNrGOEPBDcRPE/9n1uEzrbZ0d8JB7PvGuns LoNg== X-Forwarded-Encrypted: i=1; AHgh+RoAj5W40csKa/gXVTbIr8n88BXdWXv1YaPDIKz24aZIXGp6MjZQj3xZN1jTT/fyE4qO3LVqhEhcOwchHCQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1xw2utH04PNytHNrmvh9uhOFlBOcdD9W4YRFGfePgvUdMFheU wgZpLOX3VWOE5GybEVyEl647y/IEMiUJ7EF9g8vdg7N8B/ZRfvjX2T26 X-Gm-Gg: AfdE7ckZIOfZbeO+YRzvXGjCNsWaN/GaU8RSQsl9xt/MNVk1rl4DplVN4aVgIowABP3 sVwnEeBSaIVOzi/NqCF2kca3ZXyl5+F8i78GrkD8nXxhcKjiPKg5+sX/Fjmd3eNWxtlEvOn//nJ Q29+O7B1lZ6GnTirkMgoXG+MLPZ5UIDQ05ZkLOT1fyCMvMFDHZPX1zI7VX7mpjjTrElQ3E2D4aB u/+aU/j5GBspA8hz78zLQEwOQClC9w0uhV2u6UrD/WnCL/ntvlggVwl/hK9cV0fswtnJJJQkJ51 jjPZ8DmvSkU9ytyhC8I0QgXX1Lw/zMokgY1p+Lr9ontI5yXnebZhGQQFfNjI8+hmC1J5KqUyItX ss8DcOHYi2K+Ggnw2cX+NwBKCk+xOqXjSK2dKV6HwuDf1qrWYOMVzmDjrohuCpt1lCeOHVMfHOJ qv2mpCuwwebMSa+JxYCnTzp7gPUiFyYo8F5Frb50uD325FCG3Q6SQ1jvE798+pLg3hCET3Dr4Bg ogATPLnLUZNn084fmPR5gXzWPGv7RaTousctpR11ZNkS7QdHG8xgLDJwIBMP5uyJJFs4wAYrqx5 BCggb42g1tjO9Oa2TH6hKe5Q6gQX26fSY/FKq6ievkOkqJz3Qg1jKktojo/hOktLvQ== X-Received: by 2002:a5d:5e8e:0:b0:46e:1225:1e0a with SMTP id ffacd0b85a97d-46e12251e76mr2637554f8f.37.1782391412492; Thu, 25 Jun 2026 05:43:32 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46c1ee01d46sm14905648f8f.13.2026.06.25.05.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 05:43:32 -0700 (PDT) Date: Thu, 25 Jun 2026 14:43:30 +0200 From: Joshua Crofts To: Batu Ada Tutkun Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: frequency: ad9834: use guard() for mutex locking Message-ID: <20260625144330.00005231@gmail.com> In-Reply-To: <20260625120456.1267-1-batuadatutkun@gmail.com> References: <20260625120456.1267-1-batuadatutkun@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 25 Jun 2026 15:04:55 +0300 Batu Ada Tutkun wrote: > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include You're definitely developing against an old tree - this won't apply cleanly :( Please update your branch. > #include > @@ -152,7 +153,7 @@ static ssize_t ad9834_write(struct device *dev, > if (ret) > return ret; > > - mutex_lock(&st->lock); > + guard(mutex)(&st->lock); Blank line here. > switch ((u32)this_attr->address) { -- Kind regards CJD