From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E51BB2BEC34 for ; Thu, 25 Jun 2026 20:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782419398; cv=none; b=rngQw+OuBPyJVRfxdcmPTUchUrzYwGHmd5ZjRmIKX97+bHYonne64haHq0G5SZltAuwOIyRaGfkd8W/j9lh7fOKDOuPnYwtImNJs/qjzBZkI78toMoG5IRJBHvNv3uhWCUKCF6a13qOdm8g26++QRPxXSf2Z+FMVSzWySzNyifo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782419398; c=relaxed/simple; bh=5+nKdvkG+WmsXwu5G3vmgjHovCBbUwkkl1WPmTxRkEE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Ihxp6M9Rsmj9o3XaR94d8636177ZsyOsUjZzSpRENXGYGAhGj9LWEP29sL0shdXSaTrsZ4V33trIHN1FUPY7dia5iNvS6M44++BTCHhNIi6DKuxX9+4so/wgXd0Ku1Wzu1w5FhDheGwLic54XEyrMaV2gugEXp/Ah/Qc0BbZ6O4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Iaf/1CJZ; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Iaf/1CJZ" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-139d5c9a495so775165c88.0 for ; Thu, 25 Jun 2026 13:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782419396; x=1783024196; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UjaiIZ+XjuswCFzZsqBDs1nnY06nMhFFVLNeQuNdOdA=; b=Iaf/1CJZOL6AqKvdANhOfkYuxsA2FQAf+UsRQ3t4/V0qEebprlQyIvZhhM0scQeyl7 iXRI5QOX/LiWuUHEhAQGYaBSXYNQ8PCDB/GRREinKSxKutGrxtDHS5DHZy2UHB2VoYqc 6xP+s9FZN6ORRKviQp/7W9ZImVyr4ShSadXT3NzNfwBBhM5nEkQZw8J7w4xKwI6ew9P3 ojXU9+ngHZrsD1d+S93vI4I5oX0LvtspievisqAe6oHsrDQpAk2aG3nHB0RbNk5u0YNo 7AgUlM0ah0+aKmbAOOEU/XT6RDqKmyODNnHUyjxIePdpii+o2Sr3z+5UcS24F7kMTqug uv0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782419396; x=1783024196; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UjaiIZ+XjuswCFzZsqBDs1nnY06nMhFFVLNeQuNdOdA=; b=GS0DY0SyixAcZ2WKwiJEzJ1r4pbGM/cjM7SXGWjVcFX7+L5fvk1IBE0IzjdbvCqHrQ TGMiuJed8CbMS/pKVdyPQqMvpwSe9dxLXqqJJnReB8rxwnWUJ38UR0Yn7nDKa2ZZm90w yFABt3+a1olgYM+TNEH4dhx9HrLUMmAlU4mnUgJVBj81PC6w0X796yS3C/46uzsHXoZR Svh4Xvy3la28t01P/PB9DxNm5J8pI+nCYaBVX0lX1EI6Gtq5m5PdtQRgH09kELs+MOeR AshRfSRLzW1VdGRZRZqHu7ixTqoDqrDu4F2k7cWw33S58AvNnNvvigBD1whfGX+N6+jE he+Q== X-Forwarded-Encrypted: i=1; AFNElJ+egRfOV88XA/eA/lQhYBcXUZisXjCphO7+Hxj2me+4w+4bj3OFfywOTHbg7m18iuhBDj2T4TsmCAyyi9I=@vger.kernel.org X-Gm-Message-State: AOJu0YwsU2LaRThMj+6mrVKixSe3Q1QgTaw9fRSyfWC3bH+SW1y9afE5 D0E59aI6rIaj2VJ8vl6VmClGXEnm1afLL3bKGwPsf6urRF1iaAaSJWJ5 X-Gm-Gg: AfdE7ck60zXhv1Pj/jXhoTHvBkkKEyio0O8ya43UWTEFFqLbA5aAvP0fpvnRbsvGgwv 3mldzZzlen7qWjXl/gJhgkgrhKXfIq0NUwaHzREi3q16gUFm9EXyIKOjJkDqnyH/iePfomBU3Ew 2bBgJz2glZlOhX+n4t3MGUWGH60rSKyagKgACdayn/UU0GTFxWGIVw8CmjeI5KEfLGuJgkidmot 6AbWSBSd7pYraOf+N+S1ylFHLweUgW0sfGiOvo9xZ1xPUhc3+CbLsiHukemqfFVQCY8aT4JaFSb 5c+t4sHhQI5IRVLjucNgVAg1m5b6JXJWJS/1QcZuuplZCUN5ejbTbgv3pDpsSb44nUFQS7FiQ3X bbO3WW7GP7HWGnFqtqXjWQNQDN51FWk0DCkvOMxfGdThR3tjJb9svxbspJLt+48g4Sa+Zyp591N QYhfUSwCj27ZfopkNDuhM8QTtM9XYWAi7KkD5EnCl8uE1iFXQFbCkYGTzZWIag/KA= X-Received: by 2002:a05:701b:2404:b0:139:beb9:fcd0 with SMTP id a92af1059eb24-139dbb4955bmr2198183c88.27.1782419395889; Thu, 25 Jun 2026 13:29:55 -0700 (PDT) Received: from moksh-Nitro-ANV15-51.. ([36.255.89.42]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-139d8f5fc82sm10528991c88.5.2026.06.25.13.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 13:29:55 -0700 (PDT) From: Moksh Panicker To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, skhan@linuxfoundation.org, Moksh Panicker Subject: [PATCH] staging: rtl8723bs: fix OOB reads in rtw_get_wps_ie() Date: Thu, 25 Jun 2026 20:29:11 +0000 Message-Id: <20260625202911.26782-1-mokshpanicker.7@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rtw_get_wps_ie() iterates over IE data from network frames without validating that the IE header and payload fit within the remaining buffer before reading them. Specifically: - in_ie[cnt + 1] is read without checking cnt + 1 < in_len - memcmp(&in_ie[cnt + 2], ...) accesses cnt + 2 without bounds check - in_ie[cnt + 1] is used as length without verifying payload fits Add bounds checks at the top of the loop body to break early if fewer than 2 bytes remain for the IE header, or if the declared payload extends past the end of the buffer. Also require at least 4 bytes of payload before comparing the WPS OUI. Fixes: 554c0a3abf21 ("staging: rtl8723bs: add r8723bs driver") Cc: stable@vger.kernel.org Signed-off-by: Moksh Panicker --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index d0bbe1bb979c..82dc0ad27e79 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -660,7 +660,14 @@ u8 *rtw_get_wps_ie(u8 *in_ie, uint in_len, u8 *wps_ie, uint *wps_ielen) while (cnt < in_len) { eid = in_ie[cnt]; - if ((eid == WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&in_ie[cnt + 2], wps_oui, 4))) { + if (cnt + 2 > in_len) + break; + + if (in_ie[cnt + 1] + 2 > in_len - cnt) + break; + + if ((eid == WLAN_EID_VENDOR_SPECIFIC) && (in_ie[cnt + 1] >= 4) && + (!memcmp(&in_ie[cnt + 2], wps_oui, 4))) { wpsie_ptr = &in_ie[cnt]; if (wps_ie) -- 2.34.1