From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9D2839DBEF for ; Fri, 26 Jun 2026 02:59:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782442766; cv=none; b=Gl3IwiE4mbIdXZZA5ZvUDFYMIS8BbRHoMTdXdtNu3b3VaB6Npu02EoiDAdODKBmjGM418yd4KGSPDKjCh9feOG/WaSNxcX2HEuYOww0gVogbWRngC+HmtkEd3hP0TcYgzaBJahQhvRqaAJXdOeFTtxry0d6hzcLlcmA5CwfV4FQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782442766; c=relaxed/simple; bh=tQZ+TbPP0OfRqvbdFrI+mIBSR8Nopvc3RSiL9bMw4Y0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KM9ebyKZXiF7Km8vk4bUODAcKMypgvLiIGh943x7C4yt34wXmjKRFYPLjKCiTkjwxD1wmMoy+NxPsIk0Os6biFmM6spGgCo7JVFhgOflX5orcYo0YJGr+tRpu2mtmmJNe9NmqTH7LM6Ct92Btfr/d6o+GaCEYNi7eLLkKYntEJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L9KzUsUJ; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L9KzUsUJ" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2c7cfa17fedso5674745ad.3 for ; Thu, 25 Jun 2026 19:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782442765; x=1783047565; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4muAkhfm5VzCuxMXlVVQ1rf7i8L/csvKiPTRJAXnMMY=; b=L9KzUsUJIeyCXWmA04VzEm9u6qyVvP5RYKkW/gQOIgkiSsD2bnEnNTJyjL1/+i03ZE yOxPD6MEEphNKrUdTUQiLy/1YEObHa3q0eJ3E6UfkwxMzEIxQEqNY2htUHB0lYUzktBC MTferVPkkS4f9fCWskHI531MdUPdaDyThiO9vPf2v/bOHHNp3llZlHhFQBvdEW/n7/cC Zkm78YUYpE9mais+DhJOlwaU3vzU9l4W73+K5dj3xJJ8VZvHh3wNvvEb3TMDbETqtM0j uQQjuRF8xFt59Z9OkoMHccTfAC8MZ2ShEMEzmDku9HXbX1ZxE5MVYDxgY3aDv3N7AtUB aoYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782442765; x=1783047565; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4muAkhfm5VzCuxMXlVVQ1rf7i8L/csvKiPTRJAXnMMY=; b=EoI7a5+LvWN+fVH3QcVRp+nM6WefeHuRhFu3U9x6RgC96G3rEcFYgrYYOOPJzOwIHK L4xxCpf7Fj5vuCyLK4hgX15BJRQJqKddul/3EQLoNdW7KydgTfU+vjsnEckhZ0sVWDZW km0TSYVWqQi3DEMWTcbUxgvVmSRAWe8JLQFCBoReBjnM1ZoLLoiLetKf6MnDzaRT0fEV 8w2VqMXDCWlJznWIfH2gTzJ56XAROZA7cziIFtEUSxw/h8oTsrtIePnVerrvbpVFST/5 ExiJNn6PjgUncbY5ZEu13927PE13FygjJEsq+4Ay3LP4e+PAvaKUse1219HWfPiRDmnv 0isg== X-Forwarded-Encrypted: i=1; AHgh+Rr0Vaj6XehYDwXdYw4hbxaKq3RnUwO/85M6RgWnHNxcUvu8gr084gSE5J50ZEVUQhq47Chsk5IxjlmMe+s=@vger.kernel.org X-Gm-Message-State: AOJu0YwHYpcloDjoro98z7cyw9YMnqmhxWI/jMmL1DK4uUMgdt6725ij CM/1XsqnjTUes7/v9PiRWnHw41dpJ78UNErVUk63E8SWrABq/04abgkG X-Gm-Gg: AfdE7cm7sNQxUb/tnc3GCXS0dUxT8/x7eT6Ov0nM320pFaSDqex44E4TGF4cmW0sNhj VuFZJn6c6rp+f411wZsa5bvxesLzqvdRJLwRqH5W7QMdMlorE8NeyrDZqQ6ARnwukvXYBQIgE2S hw/8GYE52VqGixlZfRZxuqEjBT1TmtbTXm05EqWCHgGPwv5OXyvNlhfp0YBg9imuVp9pHIKw2bn UU0inTAcrObrzDsk2HcOZB11b+jF5Jv0g/m8NzdaKo14kDGggevhmp7kXHJuR+kfmW98W7uVhEU +tsHRBfp6VbKeMeQ0miRQyVPdobMI1a8L7y51JjUOfaa6HLY6HYyyCBzrP+gYCCk3DYRqjLSGIE fe/bRoBIabzRqwEZplfBlfjP/qqf3avEoxbpAFSszASL/lSaAKYGGLwZ7gqzVaV7XjH7oiCdds9 M77ZqOC7/KRz8= X-Received: by 2002:a17:902:e545:b0:2c1:ed61:36ab with SMTP id d9443c01a7336-2c7fc73b73dmr47872215ad.19.1782442764905; Thu, 25 Jun 2026 19:59:24 -0700 (PDT) Received: from archermind.. ([182.150.55.91]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7f5afb1e0sm31252535ad.29.2026.06.25.19.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 19:59:24 -0700 (PDT) From: Liem To: frank.li@oss.nxp.com Cc: Frank.Li@nxp.com, andi.shyti@kernel.org, biwen.li@nxp.com, festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de, liem16213@gmail.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, o.rempel@pengutronix.de, s.hauer@pengutronix.de, stable@vger.kernel.org, wsa@kernel.org Subject: [PATCH v3 2/2] i2c: imx: Cancel hrtimer before clearing slave pointer Date: Fri, 26 Jun 2026 10:58:46 +0800 Message-Id: <20260626025846.106157-3-liem16213@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260626025846.106157-1-liem16213@gmail.com> References: <20260626025846.106157-1-liem16213@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In i2c_imx_unreg_slave(), the slave pointer is set to NULL after disabling interrupts. However, a pending interrupt might already have started the hrtimer (i2c_imx_slave_timeout) before the pointer was cleared. If the hrtimer fires after i2c_imx->slave is set to NULL, the timer callback i2c_imx_slave_finish_op() will call i2c_imx_slave_event() with a NULL slave pointer,which results in a use-after-free / NULL pointer dereference. Fix by canceling the hrtimer and waiting for it to complete after disabling interrupts, before clearing the slave pointer. Fixes: f7414cd6923f ("i2c: imx: support slave mode for imx I2C driver") Cc: stable@vger.kernel.org Signed-off-by: Liem --- drivers/i2c/busses/i2c-imx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 17defb470776..f02c216ba299 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -959,6 +959,7 @@ static int i2c_imx_unreg_slave(struct i2c_client *client) i2c_imx_reset_regs(i2c_imx); + hrtimer_cancel(&i2c_imx->slave_timer); i2c_imx->slave = NULL; /* Suspend */ -- 2.34.1