From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Tzung-Bi Shih <tzungbi@kernel.org>,
David Rhodes <david.rhodes@cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Cheng-Yi Chiang <cychiang@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Benson Leung <bleung@chromium.org>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
povik+lin@cutebit.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com,
chrome-platform@lists.linux.dev, asahi@lists.linux.dev,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 17/24] ASoC: codecs: cs43130: Use guard() for mutex locks
Date: Fri, 26 Jun 2026 13:13:22 +0700 [thread overview]
Message-ID: <20260626061329.23264-18-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260626061329.23264-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Clean up the code using guard() for mutex locks.
Merely code refactoring, and no behavior change.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/codecs/cs43130.c | 72 +++++++++++++++++++-------------------
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c
index e7b06f962790..48d88dad4ceb 100644
--- a/sound/soc/codecs/cs43130.c
+++ b/sound/soc/codecs/cs43130.c
@@ -6,6 +6,7 @@
*
* Authors: Li Xu <li.xu@cirrus.com>
*/
+#include <linux/cleanup.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/kernel.h>
@@ -818,26 +819,26 @@ static int cs43130_dsd_hw_params(struct snd_pcm_substream *substream,
unsigned int required_clk;
u8 dsd_speed;
- mutex_lock(&cs43130->clk_mutex);
- if (!cs43130->clk_req) {
- /* no DAI is currently using clk */
- if (!(CS43130_MCLK_22M % params_rate(params)))
- required_clk = CS43130_MCLK_22M;
- else
- required_clk = CS43130_MCLK_24M;
+ scoped_guard(mutex, &cs43130->clk_mutex) {
+ if (!cs43130->clk_req) {
+ /* no DAI is currently using clk */
+ if (!(CS43130_MCLK_22M % params_rate(params)))
+ required_clk = CS43130_MCLK_22M;
+ else
+ required_clk = CS43130_MCLK_24M;
+
+ cs43130_set_pll(component, 0, 0, cs43130->mclk, required_clk);
+ if (cs43130->pll_bypass)
+ cs43130_change_clksrc(component, CS43130_MCLK_SRC_EXT);
+ else
+ cs43130_change_clksrc(component, CS43130_MCLK_SRC_PLL);
+ }
- cs43130_set_pll(component, 0, 0, cs43130->mclk, required_clk);
- if (cs43130->pll_bypass)
- cs43130_change_clksrc(component, CS43130_MCLK_SRC_EXT);
- else
- cs43130_change_clksrc(component, CS43130_MCLK_SRC_PLL);
+ cs43130->clk_req++;
+ if (cs43130->clk_req == 2)
+ cs43130_pcm_dsd_mix(true, cs43130->regmap);
}
- cs43130->clk_req++;
- if (cs43130->clk_req == 2)
- cs43130_pcm_dsd_mix(true, cs43130->regmap);
- mutex_unlock(&cs43130->clk_mutex);
-
switch (params_rate(params)) {
case 176400:
dsd_speed = 0;
@@ -881,26 +882,26 @@ static int cs43130_hw_params(struct snd_pcm_substream *substream,
unsigned int required_clk;
u8 dsd_speed;
- mutex_lock(&cs43130->clk_mutex);
- if (!cs43130->clk_req) {
- /* no DAI is currently using clk */
- if (!(CS43130_MCLK_22M % params_rate(params)))
- required_clk = CS43130_MCLK_22M;
- else
- required_clk = CS43130_MCLK_24M;
+ scoped_guard(mutex, &cs43130->clk_mutex) {
+ if (!cs43130->clk_req) {
+ /* no DAI is currently using clk */
+ if (!(CS43130_MCLK_22M % params_rate(params)))
+ required_clk = CS43130_MCLK_22M;
+ else
+ required_clk = CS43130_MCLK_24M;
+
+ cs43130_set_pll(component, 0, 0, cs43130->mclk, required_clk);
+ if (cs43130->pll_bypass)
+ cs43130_change_clksrc(component, CS43130_MCLK_SRC_EXT);
+ else
+ cs43130_change_clksrc(component, CS43130_MCLK_SRC_PLL);
+ }
- cs43130_set_pll(component, 0, 0, cs43130->mclk, required_clk);
- if (cs43130->pll_bypass)
- cs43130_change_clksrc(component, CS43130_MCLK_SRC_EXT);
- else
- cs43130_change_clksrc(component, CS43130_MCLK_SRC_PLL);
+ cs43130->clk_req++;
+ if (cs43130->clk_req == 2)
+ cs43130_pcm_dsd_mix(true, cs43130->regmap);
}
- cs43130->clk_req++;
- if (cs43130->clk_req == 2)
- cs43130_pcm_dsd_mix(true, cs43130->regmap);
- mutex_unlock(&cs43130->clk_mutex);
-
switch (dai->id) {
case CS43130_ASP_DOP_DAI:
case CS43130_XSP_DOP_DAI:
@@ -988,14 +989,13 @@ static int cs43130_hw_free(struct snd_pcm_substream *substream,
struct snd_soc_component *component = dai->component;
struct cs43130_private *cs43130 = snd_soc_component_get_drvdata(component);
- mutex_lock(&cs43130->clk_mutex);
+ guard(mutex)(&cs43130->clk_mutex);
cs43130->clk_req--;
if (!cs43130->clk_req) {
/* no DAI is currently using clk */
cs43130_change_clksrc(component, CS43130_MCLK_SRC_RCO);
cs43130_pcm_dsd_mix(false, cs43130->regmap);
}
- mutex_unlock(&cs43130->clk_mutex);
return 0;
}
--
2.43.0
next prev parent reply other threads:[~2026-06-26 6:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 6:13 [PATCH 00/24] ASoC: codecs: Use guard() for mutex & spin locks phucduc.bui
2026-06-26 6:13 ` [PATCH 01/24] ASoC: codecs: ab8500: Use guard() for mutex locks phucduc.bui
2026-06-26 6:13 ` [PATCH 02/24] ASoC: codecs: ak4613: " phucduc.bui
2026-06-26 6:13 ` [PATCH 03/24] ASoC: codecs: arizona-jack: Use guard() cleanup helpers phucduc.bui
2026-06-26 12:06 ` Charles Keepax
2026-06-26 6:13 ` [PATCH 04/24] ASoC: codecs: arizona: Use guard() for mutex locks phucduc.bui
2026-06-26 10:40 ` Charles Keepax
2026-06-26 6:13 ` [PATCH 05/24] ASoC: codecs: aw87390: " phucduc.bui
2026-06-26 6:13 ` [PATCH 06/24] ASoC: codecs: aw88081: " phucduc.bui
2026-06-26 6:13 ` [PATCH 07/24] ASoC: codecs: aw88166: " phucduc.bui
2026-06-26 6:13 ` [PATCH 08/24] ASoC: codecs: aw88261: " phucduc.bui
2026-06-26 6:13 ` [PATCH 09/24] ASoC: codecs: aw88395: " phucduc.bui
2026-06-26 6:13 ` [PATCH 10/24] ASoC: codecs: aw88399: " phucduc.bui
2026-06-26 6:13 ` [PATCH 11/24] ASoC: codecs: cros_ec_codec: " phucduc.bui
2026-06-26 6:13 ` [PATCH 12/24] ASoC: codecs: cs-amp-lib: " phucduc.bui
2026-06-26 8:47 ` Richard Fitzgerald
2026-06-26 9:36 ` Bui Duc Phuc
2026-06-26 6:13 ` [PATCH 13/24] ASoC: codecs: cs35l56: Use guard() and PM runtime scope helpers phucduc.bui
2026-06-26 6:13 ` [PATCH 14/24] ASoC: codecs: cs42l42: Use guard() cleanup helpers phucduc.bui
2026-06-26 12:18 ` Charles Keepax
2026-06-26 6:13 ` [PATCH 15/24] ASoC: codecs: cs42l43: Use guard() and PM runtime scope helpers phucduc.bui
2026-06-26 10:56 ` Charles Keepax
2026-06-26 12:57 ` Bui Duc Phuc
2026-06-26 6:13 ` [PATCH 16/24] ASoC: codecs: cs42l84: Use guard() for mutex locks phucduc.bui
2026-06-26 10:58 ` Charles Keepax
2026-06-26 6:13 ` phucduc.bui [this message]
2026-06-26 6:13 ` [PATCH 18/24] ASoC: codecs: cs47l15: " phucduc.bui
2026-06-26 12:02 ` Charles Keepax
2026-06-26 6:13 ` [PATCH 19/24] ASoC: codecs: cs47l35: " phucduc.bui
2026-06-26 12:03 ` Charles Keepax
2026-06-26 6:13 ` [PATCH 20/24] ASoC: codecs: cs47l85: " phucduc.bui
2026-06-26 12:03 ` Charles Keepax
2026-06-26 6:13 ` [PATCH 21/24] ASoC: codecs: cs47l90: " phucduc.bui
2026-06-26 12:03 ` Charles Keepax
2026-06-26 6:13 ` [PATCH 22/24] ASoC: codecs: cs47l92: " phucduc.bui
2026-06-26 12:04 ` Charles Keepax
2026-06-26 6:13 ` [PATCH 23/24] ASoC: codecs: cs48l32: " phucduc.bui
2026-06-26 12:15 ` Charles Keepax
2026-06-26 6:13 ` [PATCH 24/24] ASoC: codecs: cs2072x: " phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260626061329.23264-18-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=ckeepax@opensource.cirrus.com \
--cc=cychiang@chromium.org \
--cc=david.rhodes@cirrus.com \
--cc=groeck@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox