From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69EF0239567 for ; Fri, 26 Jun 2026 06:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782455864; cv=none; b=frjihZJo98Int65cZE4Gwdv4G+Z+T1ulJqN4nv7J29DNoteyRuZNw9RxbP1dZs0i1Qp1qQGM3QpuR2IFHwKo6OiJZCEghOVYaT7CYpS4+q6PFOJSNAagBR0DmzP60/azUWil6NyJJ9VCzlH5H9GaCeU02TW1Lv4WT7knfKO618A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782455864; c=relaxed/simple; bh=RhfvoNIQ3vgDXvsc+EwD7rUams8lOO7yahncw/ijWB0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ksjwvhaeoSHs/ENZKebEtV/hf8ml4PKQEZtACZsMQlnyZfT7GitpsNXkY8/XXxV4upbYmD/bldywlc7xCJURSIk8d+7Qv5mNGXJlrO8sr2mOgS5qBKePPaeu/1xR31jej32THrNFtcbLV9vpgFI3EhYX48dJaFgFwsb/4pzUKJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 6431168C4E; Fri, 26 Jun 2026 08:37:38 +0200 (CEST) Date: Fri, 26 Jun 2026 08:37:38 +0200 From: Christoph Hellwig To: Nilay Shroff Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, elver@google.com, gjoyce@linux.ibm.com Subject: Re: [PATCHv2 04/17] nvme: add Clang context annotations for nvme_ns_head::requeue_list Message-ID: <20260626063738.GD10731@lst.de> References: <20260614131541.2017845-1-nilay@linux.ibm.com> <20260614131541.2017845-5-nilay@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260614131541.2017845-5-nilay@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) > diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c > index a275c03e7c59..9e7f12fe8cd6 100644 > --- a/drivers/nvme/host/multipath.c > +++ b/drivers/nvme/host/multipath.c > @@ -706,8 +706,8 @@ int nvme_mpath_alloc_disk(struct nvme_ctrl *ctrl, struct nvme_ns_head *head) > struct queue_limits lim; > > mutex_init(&head->lock); > - bio_list_init(&head->requeue_list); > - spin_lock_init(&head->requeue_lock); > + scoped_guard(spinlock_init, &head->requeue_lock) > + bio_list_init(&head->requeue_list); We had that discussion before, but this kind of annotation is just idiotic :( We really to be able to just initialize fields without annotations before they are first published. Now bio_list_init is actually a no-op on a zero-allocated structure, so we could just drop it here, but this is a more general problem.