The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: eprobe: read the complete FILTER_PTR_STRING pointer
Date: Fri, 26 Jun 2026 06:42:23 -0400	[thread overview]
Message-ID: <20260626064223.60ffeeaa@fedora> (raw)
In-Reply-To: <aj5SdK9gUIVoPmmE@akranes.kaiser.cx>

On Fri, 26 Jun 2026 12:20:36 +0200
Martin Kaiser <martin@kaiser.cx> wrote:

> > That is, to have +u0() say "this is going to be dereferencing user space".  
> 
> > I'll add Martin's patch and see if it makes the above work.  
> 
> I've just tried your command with my patch. It works for me, filenames are
> logged correctly.

Yep, this definitely looks like a fix. We have;

	addr = rec + field->offset;

Where addr points to the location of the field on the ring buffer, thus
your change to make it:

	val = *(unsigned long *)addr;

Reads the full "long size" of the event on the ring buffer, instead of
reading just one byte. It is "val" that gets dereferenced later by the
probe logic (the "+0u()"), which has all the protections we need.

I'll queue this up.

Thanks!

-- Steve

  reply	other threads:[~2026-06-26 10:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15 14:54 [PATCH] tracing: eprobe: read the complete FILTER_PTR_STRING pointer Martin Kaiser
2026-06-16  2:09 ` Masami Hiramatsu
2026-06-17  8:32   ` Martin Kaiser
2026-06-18  1:52     ` Masami Hiramatsu
2026-06-20 15:05       ` Martin Kaiser
2026-06-22  3:58         ` Masami Hiramatsu
2026-06-26  9:54           ` Steven Rostedt
2026-06-26 10:20             ` Martin Kaiser
2026-06-26 10:42               ` Steven Rostedt [this message]
2026-06-26 15:45                 ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260626064223.60ffeeaa@fedora \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=martin@kaiser.cx \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox