From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACE681C84A6 for ; Fri, 26 Jun 2026 11:07:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782472067; cv=none; b=r2KLd23tTV7zenpPpMvVVl7CD9fiMK/+kFAlkYEtWvUZXM2kVLTiAnIP4RUXDhMoUKCyVLvZo8sJ8QAzgDfZCnJin3sXHwgIYPxddRfZ0Qw6GhbvsbbCUcs8meia3RnQ/giDbEp5Bi/qWE5CxxCfQZrtpEXbUEgH+NKjKu6plOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782472067; c=relaxed/simple; bh=MA3OVJEUNkdMomBsMxjyee+rPW4jpDgQPCabfzgQF74=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RlO2t70PetX3ya1j2EPg8MbyeHqxGXlcknIQhMN/2aXDwScuKvaVKxe9zdSAGFfi3mBWvXLo9LxUpOhdh8jLm5p0YfDfcnNyHc6O/Yjz8+GDdwKYg9F7LVw4ouv9zKpHEdLh+SuwQ+jXFED0NEaYpwuLkr5277I/pU5GON83CCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=pacMIG9t; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="pacMIG9t" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782472064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=MGc6VVjGp64vB8J0Golhy+1n3cqG9BmD37kVmIrQuUE=; b=pacMIG9thAzNG6DkEioZQp+nD+sKMEXS1T6f5EKezioOtsf10cwM3hRAUVf/JwXno9NWg8 QIPXHL2/eBmOdfQdLivZovAMVrKuEHMHtQyvBmsnO3h7qIABpB3d+mJTVXNt0oxnz1n7Xl UaQh1zYOkOqOcD83RplrgCbmwwvR+PM= From: Thorsten Blum To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Kees Cook Cc: Thorsten Blum , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc/pseries: Simplify attribute description check in papr_init() Date: Fri, 26 Jun 2026 13:07:18 +0200 Message-ID: <20260626110718.4367-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1041; i=thorsten.blum@linux.dev; h=from:subject; bh=MA3OVJEUNkdMomBsMxjyee+rPW4jpDgQPCabfzgQF74=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDFl2selFXBXd1z8ppNhP0hWO2mwgn79alHuuwNKgjol1Q S/uBhl1lLIwiHExyIopsjyY9WOGb2lN5SaTiJ0wc1iZQIYwcHEKwESuHmH4X/Bkuvi0b71m/Z4F 4veehW14um32uQSNe/+WPprMndBuO4mR4X7f2u7F3Rf/zmqaXRhzK3jbDx+d2Zzd02Z1yvyT+c2 5jhMA X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Check only the first byte instead of scanning the entire string with strnlen(). Signed-off-by: Thorsten Blum --- arch/powerpc/platforms/pseries/papr_platform_attributes.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/powerpc/platforms/pseries/papr_platform_attributes.c b/arch/powerpc/platforms/pseries/papr_platform_attributes.c index c6159870de0e..ff8adda02341 100644 --- a/arch/powerpc/platforms/pseries/papr_platform_attributes.c +++ b/arch/powerpc/platforms/pseries/papr_platform_attributes.c @@ -325,12 +325,8 @@ static int __init papr_init(void) } for (idx = 0; idx < num_attrs; idx++) { - bool show_val_desc = true; - /* Do not add the value desc attr if it does not exist */ - if (strnlen(esi_attrs[idx].value_desc, - sizeof(esi_attrs[idx].value_desc)) == 0) - show_val_desc = false; + bool show_val_desc = *esi_attrs[idx].value_desc != '\0'; if (add_attr_group(be64_to_cpu(esi_attrs[idx].id), &papr_groups[idx],