From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m16.yeah.net (mail-m16.yeah.net [220.197.32.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EBC229BD91 for ; Sat, 27 Jun 2026 10:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782555086; cv=none; b=g4/VtQkVsNkBUWSDBMz2YJdTNZrSG7zeuVfGT/u62O8VOW51Y3jVm2XyEbCFkoW7ZmPz1QmaaH2v0LdRZxW/gBzokTw/OV8zC5+rLt2Gkycd+jZP9wrJu9D6V/zXIFNHG4KkwPPufk/vomxvlUjnY/BRBuW6VSvrfU0MrVa7W2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782555086; c=relaxed/simple; bh=J2oepJpEwaFpf9pVLSuTd0p2gxKcB5AAMs5rpj5XUdk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OHvIwICAxwFAynnJ6YQwL1lJzTBHad9adcdb8PFhEns/BfHPnb1qSk3ie2s44Kaxl6PvzZq7mMFAzqz6Yb9Jd32Vw4krQrNwJ5ZaOrdz4evU1rNmbuNB/+xPJgu1Rwc2y23t4zqLqrzwkH3ep7nH5g+7jWcV311NrHX6O2Vkv5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net; spf=pass smtp.mailfrom=yeah.net; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b=Dr8VXd1u; arc=none smtp.client-ip=220.197.32.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yeah.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b="Dr8VXd1u" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=KW X5+vprFnXLDKPTmWQAkhi6vZfjmPxXd9dYCoHzojI=; b=Dr8VXd1uP/X5z2lU3X S/dlpNPP1mXeNE0P/WlJ2rhd9mtMvqFI9SnBpFunZN7yMtRF6hlT1u9oomgenOqd 2YYlhdMN5/n0bpASw6s7Y/PAnl2CiPrnxdRVXQq+K+buFnqw0tT/2crl+6GTCZUJ vC8/1GUnSAXzxbVyCl3os//RI= Received: from zhang.. (unknown []) by gzsmtp1 (Coremail) with UTF8SMTPSA id Mc8vCgD3vy2boT9q9PdfAA--.30002S4; Sat, 27 Jun 2026 18:10:41 +0800 (CST) From: Ziran Zhang To: Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , Markus Elfring Cc: Rodrigo Siqueira , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ziran Zhang Subject: [PATCH v2] drm/amd/display: Remove redundant NULL check before kfree in mod_power_create() Date: Sat, 27 Jun 2026 18:09:45 +0800 Message-ID: <20260627100945.5826-1-zhangcoder@yeah.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260627092612.5282-1-zhangcoder@yeah.net> References: <20260627092612.5282-1-zhangcoder@yeah.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:Mc8vCgD3vy2boT9q9PdfAA--.30002S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZF17KFy8Ar48CFyDCw1Dtrb_yoW8urWUpF srKw15tw48G3W8KFnFg3W8XFy8Wa1kAFW3Wr47C3Wa9a43Zr9YkF18Aw1YgFWDWFy7tF1x tF1UWF4UXFy3Cw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRUUUUUUUUU= X-CM-SenderInfo: x2kd0wpfrgv2o61htxgoqh3/1tbiNgH6u2o-oaHlNQAA3z kfree() safely handles NULL pointers, so there is no need to check for NULL before calling kfree(). Remove redundant NULL check. Found by Coccinelle ifnullfree script. Signed-off-by: Ziran Zhang --- Changes in v2: - Remove unnecessary brackets. .../gpu/drm/amd/display/modules/power/power.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/power/power.c b/drivers/gpu/drm/amd/display/modules/power/power.c index 5659a38b3..97889867a 100644 --- a/drivers/gpu/drm/amd/display/modules/power/power.c +++ b/drivers/gpu/drm/amd/display/modules/power/power.c @@ -270,13 +270,11 @@ struct mod_power *mod_power_create(struct dc *dc, fail_bad_brightness_range: fail_alloc_backlight_array: for (inst = 0; inst < edp_num; inst++) - if (core_power->bl_prop[inst].backlight_lut) - kfree(core_power->bl_prop[inst].backlight_lut); + kfree(core_power->bl_prop[inst].backlight_lut); fail_construct: - for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) { - if (core_power->map[i].psr_context) - kfree(core_power->map[i].psr_context); - } + for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) + kfree(core_power->map[i].psr_context); + kfree(core_power->map); fail_alloc_map: @@ -295,8 +293,7 @@ void mod_power_destroy(struct mod_power *mod_power) MOD_POWER_TO_CORE(mod_power); for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) - if (core_power->map[i].psr_context) - kfree(core_power->map[i].psr_context); + kfree(core_power->map[i].psr_context); for (i = 0; i < core_power->num_entities; i++) if (core_power->map[i].stream) @@ -305,8 +302,7 @@ void mod_power_destroy(struct mod_power *mod_power) kfree(core_power->map); for (i = 0; i < MAX_NUM_EDP; i++) - if (core_power->bl_prop[i].backlight_lut) - kfree(core_power->bl_prop[i].backlight_lut); + kfree(core_power->bl_prop[i].backlight_lut); kfree(core_power); } -- 2.43.0