From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m16.yeah.net (mail-m16.yeah.net [220.197.32.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E00CC17A2FC for ; Sat, 27 Jun 2026 13:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782565736; cv=none; b=T0UiGTsixZBnKmbu/MKzCESyP35rR/AKa6twpxGuI/02DuqmDk0xfeYyOJnTodzyi7kDi/w7tg5lWrFF/1WLFsnIdshEIDCtcru6PiUQgpqQIhG+ezAf8qSuq0u04TjBUnrxYj//Q15fkEZarFut/lrKNbbhS6d6tNSxy/Qhh0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782565736; c=relaxed/simple; bh=ikseeglLSk5t6g9zL0MNqJpXxYk0Qpq+q7j3uXzCSIs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MOyUwK2zQ1y/kL19EzPK5Vjp/mRlc/ZWtUJgGisskO8X4zIL/udslkjs3VMn0O/KuPr8L1Iife2nQ9kkynrKaFB8fIodgEx+rY1goMJLIQZPRbVMyKZk2l4vXkrUV3gmeVQrTo+9aQ2lfvAqHrMK70tOV8I9i7rtrdoIbxSwY+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net; spf=pass smtp.mailfrom=yeah.net; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b=LJWJ7WI8; arc=none smtp.client-ip=220.197.32.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yeah.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b="LJWJ7WI8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version: Content-Type; bh=tw6vHd1kpotBxMS/R2XHC2hK5mWlceulqu+FlD1T30o=; b=LJWJ7WI8NIEqO2XToldTO86DDmhZnJ4LwRTfkTMmNKpuJUBKXZbFYXwNP2u39i zbs3wIi5EXoPHJEmN4V/YKSEI9Z8n6UYADzzVerCaj4/fxAFXF9JiKpg2p0UZrG/ lBkr62UpArvUAm2BmV4xCnhCkQNT042uN+18jGK5KydHs= Received: from zhang.. (unknown []) by gzsmtp1 (Coremail) with UTF8SMTPSA id Mc8vCgD3vy05yz9qcWJiAA--.32977S4; Sat, 27 Jun 2026 21:08:12 +0800 (CST) From: Ziran Zhang To: markus.elfring@web.de Cc: airlied@gmail.com, alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org, christian.koenig@amd.com, dri-devel@lists.freedesktop.org, harry.wentland@amd.com, linux-kernel@vger.kernel.org, simona@ffwll.ch, siqueira@igalia.com, sunpeng.li@amd.com, zhangcoder@yeah.net Subject: Re: [PATCH] drm/amd/display: Remove redundant NULL check before kfree() in mod_power_create() Date: Sat, 27 Jun 2026 21:07:03 +0800 Message-ID: <20260627130712.4339-1-zhangcoder@yeah.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <0d82b2ff-5451-4ba5-9a02-fec93b93484f@web.de> References: <0d82b2ff-5451-4ba5-9a02-fec93b93484f@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:Mc8vCgD3vy05yz9qcWJiAA--.32977S4 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4RJUUUUUUUU X-CM-SenderInfo: x2kd0wpfrgv2o61htxgoqh3/1tbiNhxsLWo-yzwqdQAA3W On Sat, 27 Jun 2026 13:53:13 +0200, Markus Elfring wrote: > > kfree() safely handles NULL pointers, so there is no need to check for > > NULL before calling kfree(). > … > How do you think about to append parentheses to another function name > in the summary phrase? > Regards, > Markus Oops! I will send a v3. Thanks for the review! Regards, Ziran Zhang