From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m16.yeah.net (mail-m16.yeah.net [220.197.32.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB17015B998 for ; Sat, 27 Jun 2026 13:19:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782566360; cv=none; b=SbjJcmOEpNRlmqsRmFnGnkyw3M4rBncILTPPEOqEmxmY9Z9ix4tDppUsd+A02sk666vsLGO96WbBDdIL/BqqvPObTg54mV4k2ONdKj89t21EEfrMEUBaAAanXFyIHDRlVjddfMdQEuvHr6eBJhyNnzt+IpsxBIo07E096MbO33I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782566360; c=relaxed/simple; bh=QQ2cilzrD5m4Q0wn9y68h8Nv+HHd0pEEIKWz6Iy8RK4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jMRk9/V/RVAx84dCBW9gOR8/Ke8FSgrnLJfREPxgeE4zHssX9lhDzBypWJ9MF/JSS5f9OH9Fzo3oeKD4cuqzhI+O3mjP4Bmow9zLNxAOnALISxTQlfi7fjGZ9WwC+zTssTFmJup33jV50rkWAiidGaUfo9y3HWlAtI5WlXXUwwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net; spf=pass smtp.mailfrom=yeah.net; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b=Epgq3UxM; arc=none smtp.client-ip=220.197.32.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yeah.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b="Epgq3UxM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=rS cztThxqMJbnsrmUCiqJo7gdmh7LmFjJRjuznF/ZKU=; b=Epgq3UxMFPfUkowsbX A9p9PBTPo9kX1vMzfnmJ1ZC9TQs3USqKlroecITzE3N4MIXhUJgFYhMHoVrj8NTc PAuTCYJhN49160VDBs747R2aBEYcYb2uefP7wdIKiN91LnZ0ScAk9WbGoNyS7Ql/ 3BJOa+ocI8BXSrS898pJ/veAc= Received: from zhang.. (unknown []) by gzsmtp3 (Coremail) with UTF8SMTPSA id M88vCgD3nzkfzT9qCdkOAw--.16958S4; Sat, 27 Jun 2026 21:16:17 +0800 (CST) From: Ziran Zhang To: Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , Markus Elfring Cc: Rodrigo Siqueira , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ziran Zhang Subject: [PATCH v3] drm/amd/display: Remove redundant NULL check before kfree() in mod_power_create() Date: Sat, 27 Jun 2026 21:13:54 +0800 Message-ID: <20260627131354.5811-1-zhangcoder@yeah.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260627100945.5826-1-zhangcoder@yeah.net> References: <20260627100945.5826-1-zhangcoder@yeah.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:M88vCgD3nzkfzT9qCdkOAw--.16958S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZF17KFy8AF47Cr4DXFy8uFg_yoW8uF4xpF 4DKw15tw48G3W8KFnFg3W8XFy8Wa1kAFW3Wr47C3Wa9a45Zr9YkF18A34YgFWDWFy7tF18 tF1UKF4UXFy3Cw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRUUUUUUUUU= X-CM-SenderInfo: x2kd0wpfrgv2o61htxgoqh3/1tbiIQLlpmo-zSI18AAA3f kfree() safely handles NULL pointers, so there is no need to check for NULL before calling kfree(). Remove redundant NULL check. Found by Coccinelle ifnullfree script. Signed-off-by: Ziran Zhang --- Changes in v3: - Add parentheses to "kfree" in subject line for consistency. .../gpu/drm/amd/display/modules/power/power.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/power/power.c b/drivers/gpu/drm/amd/display/modules/power/power.c index 5659a38b3..97889867a 100644 --- a/drivers/gpu/drm/amd/display/modules/power/power.c +++ b/drivers/gpu/drm/amd/display/modules/power/power.c @@ -270,13 +270,11 @@ struct mod_power *mod_power_create(struct dc *dc, fail_bad_brightness_range: fail_alloc_backlight_array: for (inst = 0; inst < edp_num; inst++) - if (core_power->bl_prop[inst].backlight_lut) - kfree(core_power->bl_prop[inst].backlight_lut); + kfree(core_power->bl_prop[inst].backlight_lut); fail_construct: - for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) { - if (core_power->map[i].psr_context) - kfree(core_power->map[i].psr_context); - } + for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) + kfree(core_power->map[i].psr_context); + kfree(core_power->map); fail_alloc_map: @@ -295,8 +293,7 @@ void mod_power_destroy(struct mod_power *mod_power) MOD_POWER_TO_CORE(mod_power); for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) - if (core_power->map[i].psr_context) - kfree(core_power->map[i].psr_context); + kfree(core_power->map[i].psr_context); for (i = 0; i < core_power->num_entities; i++) if (core_power->map[i].stream) @@ -305,8 +302,7 @@ void mod_power_destroy(struct mod_power *mod_power) kfree(core_power->map); for (i = 0; i < MAX_NUM_EDP; i++) - if (core_power->bl_prop[i].backlight_lut) - kfree(core_power->bl_prop[i].backlight_lut); + kfree(core_power->bl_prop[i].backlight_lut); kfree(core_power); } -- 2.43.0