From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E38D29BD95 for ; Sun, 28 Jun 2026 17:13:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782666835; cv=none; b=MVLDCb4qAnaFso5YxLFZkw/eRf2ULIWNqtAXCX+cpk2zH7EHlNp2WJXcw8yt8QH34z2cc09ZLx++ESpNvupmYHSgAUJXPSjfJ1bdaVPTb7p0HlGQudjkVwHag5R/0K9OxwfsEetLbUmIhwv1Z3l0IstayVJGG4ulLg+y/gliL3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782666835; c=relaxed/simple; bh=kBrCFlkQB2Fwi5kxRZcJtwJ2NN36YlUGN/+bRnndk8M=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kgfOB2j0yZAolLm6mHFnZp574yV2tqX/iT9GHU2vOkAi+aHsIkJauYU/zc4spsJmoRS/XwfqM2o17mAd0fqW1bYOte2POQHykqfLEpe/xDkXgYWb28BFzSU357WD2G1utXLdPxIySjh7l5oNa/uvcMIuoXwjldRzxxevMKJKdxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cSbUCuEG; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cSbUCuEG" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4720f3bf164so437536f8f.1 for ; Sun, 28 Jun 2026 10:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782666832; x=1783271632; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DvMolz84u/CbpdbNk+f/k43XZGQjIqU3Ys7Lwiebayg=; b=cSbUCuEG+XtTa7Y0WQgSFxLXGJwQL7LOqyuPnaGLgRdqTF4ionNGM0fkrRdQTm6n2a xu2jcpIN27oHVjK6dPl2CCbFkCv+tq+U308EdoWWUB3yZgJtq8uqsd6Tmf+K6WemG49v ByYkqutFYQeeGndSHBZDLPc2oGR+6JEQKr4jZ8uVL5GmoSE0XCQj7cjmLQx66SKf9zBJ bZUuET/sENT1BmFIU0huHVztZQl+fh2kyC+z7F52ztqwBYhsyStvIkIHiEsOWHe4IoQB lwr3XMDPJ+HoPopax5aZiX3lFIq9aFudeU9fJ8zs/F1xK+/JZfZhTzeO7zKVJ7M36Zuu CKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782666832; x=1783271632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DvMolz84u/CbpdbNk+f/k43XZGQjIqU3Ys7Lwiebayg=; b=ZeA0AWiCU/qgrYrbCm9q81/Iy3pNwkcmLwQjfW4Z+ifM8jWbU2Y5aJxmDjys74KZav kA+TmPzrDRJaNF18t30KW2ZOqGIXAnDQ4g0P+5VkmVA2QQPcQqww+Ut3jKBgno/5NQ2J 42UWe7KEwXVA9pE1lNyIiiA8VxSKr6CXWF4xpTKjKu8zYUOEEhnRrUnuPHhHqe42czit gCduS2beq0LvPwZz6PaoCOR8/FAOcJ0zexFH272l/mq9bC7OvxT363Yf7s4di3b74wbQ Hab3kfSNqh2MKTMgrHYDWjT4T4DGXge6rJlKsRic1U6b5+S2hs8v7F0i8/bWLwdTAQwe vLJQ== X-Forwarded-Encrypted: i=1; AHgh+RqhnzX+sJmFYnanqXHfVRhatabBO9oYYeJ7Mt6ugH8hqq8va9j4LNOyADbwE5MmSd7mU9K7y1I37lT2ZtY=@vger.kernel.org X-Gm-Message-State: AOJu0YyDz3Tz63EVAcsrDYxNzfMFXyV16hjcxVSMHgTPXeoac96uKSOV X6awuSI5LkytBYjHfem606TENdxBxNFzZFxff/KzxgmG+WvshiurWyK3 X-Gm-Gg: AfdE7clp08NAFk77xX6e5TtpaSariqMYl2x9nmUNqkEgWMVmA+XHrETaPuBt5KQYgfe olSbdLI6sOZLRJORZD4akpMMnRbdSNkg2Gyg2YtKVICMxrVf79xbM5T5i0BHn6utHx/9JOgq9Ap T4GPjjGRE5Wj016sV0XwseRcu7vbltBSwrDeZtcdPBUmZlofw5QCLofoD9Kq3K/mEDLLq0I/gAd rRBFnELXiP7Pxd0ygp2od1YEpLLWFlG8z0ia3Qbxdw9G7TNsFoN6VzDDwqAGKovle6Sn7a1meem KOl8Rw6IY3UMFDmwfMFeUECAyK4LQ5wh72rxtSTGTv/2Fvwoz3pbeytPS1FwF4+7OHWJ/Qjk3gK RBrhZOdT5zIloZ/+GhzSTrzGNd+8tjKzM5f/jJfPW9gjEg296VOQO7e/ETfqjnJyDPa+wwrFTel nWaL9aan2JgDlHY+phr1NX5IbFtxCez6m0KLqg1ER2AjE+qlKYaeyd9MjaiXOW1tiCdGp2t4Ssd 5yajqz4kAfhuq2OE9hYn937E+S7lAo2JP4Yk4bgmE0G26T21KVhMbEVk6BksYe/Rh3o4TkH9JWq 26t05A== X-Received: by 2002:a05:6000:71e:b0:472:8043:f00b with SMTP id ffacd0b85a97d-4728043f1d4mr5023483f8f.14.1782666832292; Sun, 28 Jun 2026 10:13:52 -0700 (PDT) Received: from systembl0wer ([2a02:8308:4092:11f0::f9f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-473563c2df7sm4145748f8f.24.2026.06.28.10.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 10:13:52 -0700 (PDT) Date: Sun, 28 Jun 2026 19:13:50 +0200 From: Joshua Crofts To: Moksh Panicker Cc: jic23@kernel.org, nuno.sa@analog.com, Michael.Hennerich@analog.com, dlechner@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org Subject: Re: [PATCH v2 0/2] iio: adc: ad7779: Remove dead code and redundant error message Message-ID: <20260628191350.583470a7@systembl0wer> In-Reply-To: <20260628145734.77191-1-mokshpanicker.7@gmail.com> References: <20260628145734.77191-1-mokshpanicker.7@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 28 Jun 2026 14:57:32 +0000 Moksh Panicker wrote: > These two patches address review feedback from Joshua Crofts on the > ad7779 driver: > > 1. Remove an unused completion field that was initialized but never > waited on or signaled anywhere in the driver. > > 2. Remove a redundant dev_err_probe() wrapper around devm_request_irq(), > which already calls dev_err_probe() internally. > > Moksh Panicker (2): > iio: adc: ad7779: Remove unused completion field > iio: adc: ad7779: Remove redundant dev_err_probe() after > devm_request_irq() > > drivers/iio/adc/ad7779.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > You forgot to pull my Reviewed-by tags, no need to resend: Reviewed-by: Joshua Crofts -- Kind regards CJD